From patchwork Thu Mar 24 07:40:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joerg Roedel X-Patchwork-Id: 658051 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p2O7efjH032453 for ; Thu, 24 Mar 2011 07:40:41 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933549Ab1CXHkg (ORCPT ); Thu, 24 Mar 2011 03:40:36 -0400 Received: from ch1outboundpool.messaging.microsoft.com ([216.32.181.185]:28366 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933505Ab1CXHke (ORCPT ); Thu, 24 Mar 2011 03:40:34 -0400 Received: from mail92-ch1-R.bigfish.com (216.32.181.170) by CH1EHSOBE015.bigfish.com (10.43.70.65) with Microsoft SMTP Server id 14.1.225.8; Thu, 24 Mar 2011 07:40:33 +0000 Received: from mail92-ch1 (localhost.localdomain [127.0.0.1]) by mail92-ch1-R.bigfish.com (Postfix) with ESMTP id 34EF015102FE; Thu, 24 Mar 2011 07:40:33 +0000 (UTC) X-SpamScore: -2 X-BigFish: VPS-2(zzbb2cKzz1202hzz8275bhz32i668h62h) X-Spam-TCS-SCL: 1:0 X-Forefront-Antispam-Report: KIP:(null); UIP:(null); IPVD:NLI; H:ausb3twp02.amd.com; RD:none; EFVD:NLI Received: from mail92-ch1 (localhost.localdomain [127.0.0.1]) by mail92-ch1 (MessageSwitch) id 1300952431680457_28777; Thu, 24 Mar 2011 07:40:31 +0000 (UTC) Received: from CH1EHSMHS025.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.244]) by mail92-ch1.bigfish.com (Postfix) with ESMTP id A2B538D0053; Thu, 24 Mar 2011 07:40:31 +0000 (UTC) Received: from ausb3twp02.amd.com (163.181.249.109) by CH1EHSMHS025.bigfish.com (10.43.70.25) with Microsoft SMTP Server id 14.1.225.8; Thu, 24 Mar 2011 07:40:30 +0000 X-WSS-ID: 0LIJXBA-02-EUA-02 X-M-MSG: Received: from sausexedgep02.amd.com (sausexedgep02-ext.amd.com [163.181.249.73]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ausb3twp02.amd.com (Tumbleweed MailGate 3.7.2) with ESMTP id 2B84AC8AE9; Thu, 24 Mar 2011 02:40:22 -0500 (CDT) Received: from sausexhtp02.amd.com (163.181.3.152) by sausexedgep02.amd.com (163.181.36.59) with Microsoft SMTP Server (TLS) id 8.3.106.1; Thu, 24 Mar 2011 02:47:50 -0500 Received: from storexhtp01.amd.com (172.24.4.3) by sausexhtp02.amd.com (163.181.3.152) with Microsoft SMTP Server (TLS) id 8.3.83.0; Thu, 24 Mar 2011 02:40:29 -0500 Received: from gwo.osrc.amd.com (165.204.16.204) by storexhtp01.amd.com (172.24.4.3) with Microsoft SMTP Server id 8.3.83.0; Thu, 24 Mar 2011 03:40:28 -0400 Received: from lemmy.osrc.amd.com (lemmy.osrc.amd.com [165.204.15.93]) by gwo.osrc.amd.com (Postfix) with ESMTP id DBC4349C599; Thu, 24 Mar 2011 07:40:26 +0000 (GMT) Received: by lemmy.osrc.amd.com (Postfix, from userid 1000) id CF96E100BE1; Thu, 24 Mar 2011 08:40:26 +0100 (CET) From: Joerg Roedel To: Avi Kivity , Marcelo Tosatti CC: Zachary Amsden , , Joerg Roedel Subject: [PATCH 6/6] KVM: X86: Implement userspace interface to set virtual_tsc_khz Date: Thu, 24 Mar 2011 08:40:24 +0100 Message-ID: <1300952424-32014-7-git-send-email-joerg.roedel@amd.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1300952424-32014-1-git-send-email-joerg.roedel@amd.com> References: <1300952424-32014-1-git-send-email-joerg.roedel@amd.com> MIME-Version: 1.0 X-OriginatorOrg: amd.com Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 24 Mar 2011 07:40:41 +0000 (UTC) diff --git a/Documentation/kvm/api.txt b/Documentation/kvm/api.txt index 9bef4e4..e4e4a44 100644 --- a/Documentation/kvm/api.txt +++ b/Documentation/kvm/api.txt @@ -1263,6 +1263,28 @@ struct kvm_assigned_msix_entry { __u16 padding[3]; }; +4.54 KVM_SET_TSC_KHZ + +Capability: KVM_CAP_TSC_CONTROL +Architectures: x86 +Type: vm ioctl +Parameters: __u32 (in) +Returns: 0 on success, -1 on error + +Specifies the tsc frequency for the virtual machine. This IOCTL must be +used before any vcpu is created. The unit of the frequency is KHz. + +4.55 KVM_GET_TSC_KHZ + +Capability: KVM_CAP_GET_TSC_KHZ +Architectures: x86 +Type: vm ioctl +Parameters: __u32 (out) +Returns: 0 on success, -1 on error + +Returns the tsc frequency of the guest. The unit of the return value is +KHz. If the host has unstable tsc this ioctl return an error. + 5. The kvm_run structure Application code obtains a pointer to the kvm_run structure by diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 6fe1e84..5b96b76 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -632,6 +632,13 @@ u8 kvm_get_guest_memory_type(struct kvm_vcpu *vcpu, gfn_t gfn); extern bool tdp_enabled; +/* control of guest tsc rate supported? */ +extern bool kvm_has_tsc_control; +/* minimum supported tsc_khz for guests */ +extern u32 kvm_min_guest_tsc_khz; +/* maximum supported tsc_khz for guests */ +extern u32 kvm_max_guest_tsc_khz; + enum emulation_result { EMULATE_DONE, /* no further processing */ EMULATE_DO_MMIO, /* kvm_run filled with mmio request */ diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 32d444f..368577b 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -64,6 +64,8 @@ MODULE_LICENSE("GPL"); #define DEBUGCTL_RESERVED_BITS (~(0x3fULL)) #define TSC_RATIO_RSVD 0xffffff0000000000ULL +#define TSC_RATIO_MIN 0x0000000000000001ULL +#define TSC_RATIO_MAX 0x000000ffffffffffULL static bool erratum_383_found __read_mostly; @@ -198,6 +200,7 @@ static int nested_svm_intercept(struct vcpu_svm *svm); static int nested_svm_vmexit(struct vcpu_svm *svm); static int nested_svm_check_exception(struct vcpu_svm *svm, unsigned nr, bool has_error_code, u32 error_code); +static u64 __scale_tsc(u64 ratio, u64 tsc); enum { VMCB_INTERCEPTS, /* Intercept vectors, TSC offset, @@ -799,6 +802,18 @@ static __init int svm_hardware_setup(void) if (boot_cpu_has(X86_FEATURE_FXSR_OPT)) kvm_enable_efer_bits(EFER_FFXSR); + if (boot_cpu_has(X86_FEATURE_TSCRATEMSR)) { + u64 min, max; + + kvm_has_tsc_control = true; + + min = max(1ULL, __scale_tsc(tsc_khz, TSC_RATIO_MIN)); + max = min(0xffffffffULL, __scale_tsc(tsc_khz, TSC_RATIO_MAX)); + + kvm_min_guest_tsc_khz = min; + kvm_max_guest_tsc_khz = max; + } + if (nested) { printk(KERN_INFO "kvm: Nested Virtualization enabled\n"); kvm_enable_efer_bits(EFER_SVME | EFER_LMSLE); diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 7754079..416b016 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -100,6 +100,13 @@ EXPORT_SYMBOL_GPL(kvm_x86_ops); int ignore_msrs = 0; module_param_named(ignore_msrs, ignore_msrs, bool, S_IRUGO | S_IWUSR); +bool kvm_has_tsc_control; +EXPORT_SYMBOL_GPL(kvm_has_tsc_control); +u32 kvm_min_guest_tsc_khz; +EXPORT_SYMBOL_GPL(kvm_min_guest_tsc_khz); +u32 kvm_max_guest_tsc_khz; +EXPORT_SYMBOL_GPL(kvm_max_guest_tsc_khz); + #define KVM_NR_SHARED_MSRS 16 struct kvm_shared_msrs_global { @@ -2000,6 +2007,7 @@ int kvm_dev_ioctl_check_extension(long ext) case KVM_CAP_X86_ROBUST_SINGLESTEP: case KVM_CAP_XSAVE: case KVM_CAP_ASYNC_PF: + case KVM_CAP_GET_TSC_KHZ: r = 1; break; case KVM_CAP_COALESCED_MMIO: @@ -2026,6 +2034,9 @@ int kvm_dev_ioctl_check_extension(long ext) case KVM_CAP_XCRS: r = cpu_has_xsave; break; + case KVM_CAP_TSC_CONTROL: + r = kvm_has_tsc_control; + break; default: r = 0; break; @@ -3580,6 +3591,52 @@ long kvm_arch_vm_ioctl(struct file *filp, r = 0; break; } + case KVM_SET_TSC_KHZ: { + u32 user_tsc_khz; + + if (!kvm_has_tsc_control) + break; + + r = -EFAULT; + if (copy_from_user(&user_tsc_khz, argp, sizeof(__u32))) + goto out; + + r = -EINVAL; + if (user_tsc_khz < kvm_min_guest_tsc_khz || + user_tsc_khz > kvm_max_guest_tsc_khz) + goto out; + + mutex_lock(&kvm->lock); + /* + * We force the tsc frequency to be set before any + * vcpu is created + */ + if (atomic_read(&kvm->online_vcpus) > 0) { + mutex_unlock(&kvm->lock); + goto out; + } + + kvm_arch_set_tsc_khz(kvm, user_tsc_khz); + + mutex_unlock(&kvm->lock); + + r = 0; + goto out; + } + case KVM_GET_TSC_KHZ: { + u32 vtsc_khz = kvm->arch.virtual_tsc_khz; + + r = -EIO; + if (check_tsc_unstable()) + goto out; + + r = -EFAULT; + if (copy_to_user(argp, &vtsc_khz, sizeof(__u32))) + goto out; + + r = 0; + goto out; + } default: ; diff --git a/include/linux/kvm.h b/include/linux/kvm.h index ea2dc1a..ea16c57 100644 --- a/include/linux/kvm.h +++ b/include/linux/kvm.h @@ -541,6 +541,8 @@ struct kvm_ppc_pvinfo { #define KVM_CAP_PPC_GET_PVINFO 57 #define KVM_CAP_PPC_IRQ_LEVEL 58 #define KVM_CAP_ASYNC_PF 59 +#define KVM_CAP_TSC_CONTROL 60 +#define KVM_CAP_GET_TSC_KHZ 61 #ifdef KVM_CAP_IRQ_ROUTING @@ -677,6 +679,9 @@ struct kvm_clock_data { #define KVM_SET_PIT2 _IOW(KVMIO, 0xa0, struct kvm_pit_state2) /* Available with KVM_CAP_PPC_GET_PVINFO */ #define KVM_PPC_GET_PVINFO _IOW(KVMIO, 0xa1, struct kvm_ppc_pvinfo) +/* Available with KVM_CAP_TSC_CONTROL */ +#define KVM_SET_TSC_KHZ _IOW(KVMIO, 0xa2, __u32) +#define KVM_GET_TSC_KHZ _IOR(KVMIO, 0xa2, __u32) /* * ioctls for vcpu fds