From patchwork Fri Apr 8 20:33:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas Meneghel Rodrigues X-Patchwork-Id: 695521 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p38KXHb7022738 for ; Fri, 8 Apr 2011 20:33:17 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757877Ab1DHUdO (ORCPT ); Fri, 8 Apr 2011 16:33:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48741 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757843Ab1DHUdO (ORCPT ); Fri, 8 Apr 2011 16:33:14 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p38KXCp4010086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Apr 2011 16:33:12 -0400 Received: from freedom.redhat.com (vpn-11-221.rdu.redhat.com [10.11.11.221]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p38KXA9l003136; Fri, 8 Apr 2011 16:33:11 -0400 From: Lucas Meneghel Rodrigues To: autotest@test.kernel.org Cc: kvm@vger.kernel.org, Lucas Meneghel Rodrigues Subject: [PATCH 1/3] KVM test: Unattended install - Fix incorrect verify_kernel_crash Date: Fri, 8 Apr 2011 17:33:06 -0300 Message-Id: <1302294788-10078-1-git-send-email-lmr@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 08 Apr 2011 20:33:17 +0000 (UTC) The idea was to put the kernel crash verification during the install loop, not at the beginning of the test. Signed-off-by: Lucas Meneghel Rodrigues --- client/tests/kvm/tests/unattended_install.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py index 4868053..955f8d6 100644 --- a/client/tests/kvm/tests/unattended_install.py +++ b/client/tests/kvm/tests/unattended_install.py @@ -16,7 +16,6 @@ def run_unattended_install(test, params, env): """ vm = env.get_vm(params["main_vm"]) vm.verify_alive() - vm.verify_kernel_crash() install_timeout = int(params.get("timeout", 3000)) post_install_delay = int(params.get("post_install_delay", 0)) @@ -34,6 +33,7 @@ def run_unattended_install(test, params, env): start_time = time.time() while (time.time() - start_time) < install_timeout: vm.verify_alive() + vm.verify_kernel_crash() client = socket.socket(socket.AF_INET, socket.SOCK_STREAM) try: client.connect((vm.get_address(), port))