From patchwork Wed Jun 29 18:02:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 929892 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5TI4f9W001053 for ; Wed, 29 Jun 2011 18:04:41 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756806Ab1F2SEg (ORCPT ); Wed, 29 Jun 2011 14:04:36 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:41584 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754092Ab1F2SEd (ORCPT ); Wed, 29 Jun 2011 14:04:33 -0400 Received: by qwk3 with SMTP id 3so740259qwk.19 for ; Wed, 29 Jun 2011 11:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=u9xO4hPRaQ7JwOCKslkYLo/5mmfuxHEDdVWTYtfraaQ=; b=fBfaE/eMbzr0zye3mYdv8H7senfBwvpMm62z/oeivfRWfD8++9KgeYAjeFN2XYkzUW gYC+aYXo7m8AJmgvuYfQSf7XSJgSUXu0Yku0jx5F87/wJttRY7Bf8l7KOgf7Q9FxLSTa f+SiaHPE19rCfLp7pCHQ1leKJVoRDCl1cwNJI= Received: by 10.229.52.13 with SMTP id f13mr840595qcg.106.1309370673044; Wed, 29 Jun 2011 11:04:33 -0700 (PDT) Received: from localhost.localdomain (c-71-232-157-243.hsd1.ma.comcast.net [71.232.157.243]) by mx.google.com with ESMTPS id e18sm1067677qcs.29.2011.06.29.11.04.31 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 29 Jun 2011 11:04:32 -0700 (PDT) From: Sasha Levin To: penberg@kernel.org Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com, Sasha Levin Subject: [PATCH 4/9] kvm tools: Provide instance name when running 'kvm debug' Date: Wed, 29 Jun 2011 14:02:13 -0400 Message-Id: <1309370538-7947-4-git-send-email-levinsasha928@gmail.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1309370538-7947-1-git-send-email-levinsasha928@gmail.com> References: <1309370538-7947-1-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 29 Jun 2011 18:04:41 +0000 (UTC) Instead of sending a signal to the first instance found, send it to a specific instance. Signed-off-by: Sasha Levin --- tools/kvm/kvm-debug.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tools/kvm/kvm-debug.c b/tools/kvm/kvm-debug.c index 58782dd..432ae84 100644 --- a/tools/kvm/kvm-debug.c +++ b/tools/kvm/kvm-debug.c @@ -1,11 +1,22 @@ -#include -#include - #include #include #include +#include + +#include +#include +#include int kvm_cmd_debug(int argc, const char **argv, const char *prefix) { - return system("kill -3 $(pidof kvm)"); + int pid; + + if (argc != 1) + die("Usage: kvm debug [instance name]\n"); + + pid = kvm__get_pid_by_instance(argv[0]); + if (pid < 0) + die("Failed locating instance name"); + + return kill(pid, SIGQUIT); }