From patchwork Sat Jul 2 23:52:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 939632 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p61NrRbl021037 for ; Fri, 1 Jul 2011 23:53:27 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754133Ab1GAXxV (ORCPT ); Fri, 1 Jul 2011 19:53:21 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:59838 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753981Ab1GAXxV (ORCPT ); Fri, 1 Jul 2011 19:53:21 -0400 Received: by mail-wy0-f174.google.com with SMTP id 8so2484528wyg.19 for ; Fri, 01 Jul 2011 16:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=u9xO4hPRaQ7JwOCKslkYLo/5mmfuxHEDdVWTYtfraaQ=; b=trFgwdcO4yrXVNBDexXhn6g57rmlScXs6ZiFxDpFQdB6Hakvp2s1dSGL/6MqpNwvUM 0qFbPHlxgTnrcnsZ2crQSWp41L8WWK6OqvORvUzYr/NkYHVCQa1JEsss/HG47GmouzRG X6ktjRkcUwxOwGZ+Bpc04AoEx1AQcWJRBkLcw= Received: by 10.216.69.196 with SMTP id n46mr3189918wed.86.1309564400260; Fri, 01 Jul 2011 16:53:20 -0700 (PDT) Received: from localhost.localdomain ([31.210.184.221]) by mx.google.com with ESMTPS id l53sm1858198weq.23.2011.07.01.16.53.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 01 Jul 2011 16:53:20 -0700 (PDT) From: Sasha Levin To: penberg@kernel.org Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com, Sasha Levin Subject: [PATCH v2 4/8] kvm tools: Provide instance name when running 'kvm debug' Date: Sat, 2 Jul 2011 19:52:06 -0400 Message-Id: <1309650731-5796-4-git-send-email-levinsasha928@gmail.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1309650731-5796-1-git-send-email-levinsasha928@gmail.com> References: <1309650731-5796-1-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 01 Jul 2011 23:53:27 +0000 (UTC) Instead of sending a signal to the first instance found, send it to a specific instance. Signed-off-by: Sasha Levin --- tools/kvm/kvm-debug.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tools/kvm/kvm-debug.c b/tools/kvm/kvm-debug.c index 58782dd..432ae84 100644 --- a/tools/kvm/kvm-debug.c +++ b/tools/kvm/kvm-debug.c @@ -1,11 +1,22 @@ -#include -#include - #include #include #include +#include + +#include +#include +#include int kvm_cmd_debug(int argc, const char **argv, const char *prefix) { - return system("kill -3 $(pidof kvm)"); + int pid; + + if (argc != 1) + die("Usage: kvm debug [instance name]\n"); + + pid = kvm__get_pid_by_instance(argv[0]); + if (pid < 0) + die("Failed locating instance name"); + + return kill(pid, SIGQUIT); }