From patchwork Thu Aug 18 12:18:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 1076382 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7ICKJPR017911 for ; Thu, 18 Aug 2011 12:20:19 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755912Ab1HRMT7 (ORCPT ); Thu, 18 Aug 2011 08:19:59 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:36990 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755825Ab1HRMT6 (ORCPT ); Thu, 18 Aug 2011 08:19:58 -0400 Received: by fxh19 with SMTP id 19so1238929fxh.19 for ; Thu, 18 Aug 2011 05:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=xeD48FUssQuKrzr7Gr0n1J/HL/Vrhn8IGRCQazC0D2Y=; b=tib+TTRAr7v5ydTeSAM2FleIAvxKXhMhiVEi6rWeB3IqduQz75EWYbq0BinbiI+3w9 ECbte7i5PndA9jrRInVEJ2qcc261x9ab91xs8W5qcUgLltDHnvZR0UeB1enRQaDlHxgo UTCnc3nCvb9UuiYIQhjB5qzCbavnsEZmBqDg8= Received: by 10.223.1.201 with SMTP id 9mr1014688fag.91.1313669996772; Thu, 18 Aug 2011 05:19:56 -0700 (PDT) Received: from localhost.localdomain (87.68.211.185.adsl.012.net.il [87.68.211.185]) by mx.google.com with ESMTPS id d1sm1697583fai.4.2011.08.18.05.19.54 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 18 Aug 2011 05:19:56 -0700 (PDT) From: Sasha Levin To: penberg@kernel.org Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com, Sasha Levin Subject: [PATCH 2/7] kvm tools: Add guest compatability warning to virtio-rng Date: Thu, 18 Aug 2011 15:18:32 +0300 Message-Id: <1313669917-21192-2-git-send-email-levinsasha928@gmail.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1313669917-21192-1-git-send-email-levinsasha928@gmail.com> References: <1313669917-21192-1-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 18 Aug 2011 12:20:19 +0000 (UTC) Signed-off-by: Sasha Levin --- tools/kvm/virtio/rng.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/tools/kvm/virtio/rng.c b/tools/kvm/virtio/rng.c index 5f29ded..a540e2e 100644 --- a/tools/kvm/virtio/rng.c +++ b/tools/kvm/virtio/rng.c @@ -11,6 +11,7 @@ #include "kvm/threadpool.h" #include "kvm/irq.h" #include "kvm/ioeventfd.h" +#include "kvm/guest_compat.h" #include #include @@ -41,6 +42,7 @@ struct rng_dev { int fd; u32 vq_vector[NUM_VIRT_QUEUES]; u32 msix_io_block; + int compat_id; /* virtio queue */ u16 queue_selector; @@ -137,6 +139,8 @@ static bool virtio_rng_pci_io_out(struct ioport *ioport, struct kvm *kvm, u16 po struct rng_dev_job *job; void *p; + compat__remove_message(rdev->compat_id); + queue = &rdev->vqs[rdev->queue_selector]; queue->pfn = ioport__read32(data); p = guest_pfn_to_host(kvm, queue->pfn); @@ -279,6 +283,12 @@ void virtio_rng__init(struct kvm *kvm) ioeventfd__add_event(&ioevent); } + + rdev->compat_id = compat__add_message("virtio-rng device was not detected", + "While you have requested a virtio-rng device, " + "the guest kernel didn't seem to detect it.\n" + "Please make sure that the kernel was compiled" + "with CONFIG_HW_RANDOM_VIRTIO."); } void virtio_rng__delete_all(struct kvm *kvm)