From patchwork Tue Jul 24 22:34:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nicholas A. Bellinger" X-Patchwork-Id: 1233541 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 650084025E for ; Tue, 24 Jul 2012 22:37:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755504Ab2GXWhY (ORCPT ); Tue, 24 Jul 2012 18:37:24 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:40999 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274Ab2GXWhU (ORCPT ); Tue, 24 Jul 2012 18:37:20 -0400 Received: from linux-iscsi.org (localhost [127.0.0.1]) by linux-iscsi.org (Postfix) with ESMTP id 8DE3222D9DA; Tue, 24 Jul 2012 22:34:18 +0000 (UTC) From: "Nicholas A. Bellinger" To: target-devel Cc: lf-virt , kvm-devel , qemu-devel , Stefan Hajnoczi , Zhi Yong Wu , Anthony Liguori , Paolo Bonzini , "Michael S. Tsirkin" , Christoph Hellwig , Jens Axboe , Hannes Reinecke , Anthony Liguori Subject: [RFC 3/9] virtio-pci: check that event notification worked Date: Tue, 24 Jul 2012 22:34:00 +0000 Message-Id: <1343169246-17636-4-git-send-email-nab@linux-iscsi.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1343169246-17636-1-git-send-email-nab@linux-iscsi.org> References: <1343169246-17636-1-git-send-email-nab@linux-iscsi.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Stefan Hajnoczi For sanity assert that event notification succeeds. Signed-off-by: Stefan Hajnoczi Cc: Anthony Liguori Cc: Paolo Bonzini Signed-off-by: Nicholas Bellinger --- hw/virtio-pci.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 538eef4..0f0f766 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -261,8 +261,11 @@ static void virtio_pci_queue_notify(VirtIOPCIProxy *proxy, uint32_t n) vq = virtio_get_queue(proxy->vdev, n); notifier = virtio_queue_get_host_notifier(vq); if (event_notifier_valid(notifier)) { + int r; + printf("notifying vq %u host notifier from userspace\n", n); - event_notifier_notify(notifier); + r = event_notifier_notify(notifier); + assert(r == 0); } else { virtio_queue_notify_vq(vq); }