diff mbox

[2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.

Message ID 1349187938-39712-3-git-send-email-borntraeger@de.ibm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Christian Borntraeger Oct. 2, 2012, 2:25 p.m. UTC 
From: Cornelia Huck <cornelia.huck@de.ibm.com>

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Comments

Marcelo Tosatti Oct. 10, 2012, 4:27 p.m. UTC | #1 
On Tue, Oct 02, 2012 at 04:25:37PM +0200, Christian Borntraeger wrote:
> From: Cornelia Huck <cornelia.huck@de.ibm.com>
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 36befa7..c533338 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1984,6 +1984,39 @@ return the hash table order in the parameter.  (If the guest is using
>  the virtualized real-mode area (VRMA) facility, the kernel will
>  re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
>  
> +4.77 KVM_S390_INTERRUPT
> +
> +Capability: basic
> +Archtectures: s390

typo.

> +Type: vm ioctl, vcpu ioctl
> +Parameters: struct kvm_s390_interrupt (in)
> +Returns: 0 on success, -1 on error
> +
> +Allows to inject an interrupt to the guest. Interrupts can be floating
> +(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
> +
> +Interrupt parameters are passed via kvm_s390_interrupt:
> +
> +struct kvm_s390_interrupt {
> +	__u32 type;
> +	__u32 parm;
> +	__u64 parm64;
> +};

No need for a reserved area for extensibility?

> +
> +type can be one of the following:
> +
> +KVM_S390_SIGP_STOP (vcpu) - sigp restart
> +KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
> +KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
> +KVM_S390_RESTART (vcpu) - restart
> +KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
> +			   parameters in parm and parm64
> +KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
> +KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
> +KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
> +
> +Note that the vcpu ioctl is asynchronous to vpcu execution.

typo


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexander Graf Oct. 10, 2012, 4:32 p.m. UTC | #2 
On 10.10.2012, at 18:27, Marcelo Tosatti wrote:

> On Tue, Oct 02, 2012 at 04:25:37PM +0200, Christian Borntraeger wrote:
>> From: Cornelia Huck <cornelia.huck@de.ibm.com>
>> 
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>> 
>> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
>> index 36befa7..c533338 100644
>> --- a/Documentation/virtual/kvm/api.txt
>> +++ b/Documentation/virtual/kvm/api.txt
>> @@ -1984,6 +1984,39 @@ return the hash table order in the parameter.  (If the guest is using
>> the virtualized real-mode area (VRMA) facility, the kernel will
>> re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
>> 
>> +4.77 KVM_S390_INTERRUPT
>> +
>> +Capability: basic
>> +Archtectures: s390
> 
> typo.
> 
>> +Type: vm ioctl, vcpu ioctl
>> +Parameters: struct kvm_s390_interrupt (in)
>> +Returns: 0 on success, -1 on error
>> +
>> +Allows to inject an interrupt to the guest. Interrupts can be floating
>> +(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
>> +
>> +Interrupt parameters are passed via kvm_s390_interrupt:
>> +
>> +struct kvm_s390_interrupt {
>> +	__u32 type;
>> +	__u32 parm;
>> +	__u64 parm64;
>> +};
> 
> No need for a reserved area for extensibility?

This is documentation for an existing ioctl, no?
And yes, a reserved area would've been nice ;). But it's too late for that one now.


Alex

> 
>> +
>> +type can be one of the following:
>> +
>> +KVM_S390_SIGP_STOP (vcpu) - sigp restart
>> +KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
>> +KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
>> +KVM_S390_RESTART (vcpu) - restart
>> +KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
>> +			   parameters in parm and parm64
>> +KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
>> +KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
>> +KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
>> +
>> +Note that the vcpu ioctl is asynchronous to vpcu execution.
> 
> typo
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Cornelia Huck Oct. 10, 2012, 4:37 p.m. UTC | #3 
On Wed, 10 Oct 2012 13:27:09 -0300
Marcelo Tosatti <mtosatti@redhat.com> wrote:

> > +Archtectures: s390
> 
> typo.

> > +Note that the vcpu ioctl is asynchronous to vpcu execution.
> 
> typo
> 
> 

Would you like a respin with the typos fixed?

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Cornelia Huck Oct. 10, 2012, 4:38 p.m. UTC | #4 
On Wed, 10 Oct 2012 18:32:14 +0200
Alexander Graf <agraf@suse.de> wrote:

> 
> On 10.10.2012, at 18:27, Marcelo Tosatti wrote:
> 
> > On Tue, Oct 02, 2012 at 04:25:37PM +0200, Christian Borntraeger wrote:
> >> From: Cornelia Huck <cornelia.huck@de.ibm.com>
> >> 
> >> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> >> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> >> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >> ---
> >> Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
> >> 1 file changed, 33 insertions(+)
> >> 
> >> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> >> index 36befa7..c533338 100644
> >> --- a/Documentation/virtual/kvm/api.txt
> >> +++ b/Documentation/virtual/kvm/api.txt
> >> @@ -1984,6 +1984,39 @@ return the hash table order in the parameter.  (If the guest is using
> >> the virtualized real-mode area (VRMA) facility, the kernel will
> >> re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
> >> 
> >> +4.77 KVM_S390_INTERRUPT
> >> +
> >> +Capability: basic
> >> +Archtectures: s390
> > 
> > typo.
> > 
> >> +Type: vm ioctl, vcpu ioctl
> >> +Parameters: struct kvm_s390_interrupt (in)
> >> +Returns: 0 on success, -1 on error
> >> +
> >> +Allows to inject an interrupt to the guest. Interrupts can be floating
> >> +(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
> >> +
> >> +Interrupt parameters are passed via kvm_s390_interrupt:
> >> +
> >> +struct kvm_s390_interrupt {
> >> +	__u32 type;
> >> +	__u32 parm;
> >> +	__u64 parm64;
> >> +};
> > 
> > No need for a reserved area for extensibility?
> 
> This is documentation for an existing ioctl, no?
> And yes, a reserved area would've been nice ;). But it's too late for that one now.

Indeed. We'll have to keep this for backward compatibility and introduce
a new mechanism for larger interrupt structures.

> 
> 
> Alex
> 
> > 
> >> +
> >> +type can be one of the following:
> >> +
> >> +KVM_S390_SIGP_STOP (vcpu) - sigp restart
> >> +KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
> >> +KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
> >> +KVM_S390_RESTART (vcpu) - restart
> >> +KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
> >> +			   parameters in parm and parm64
> >> +KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
> >> +KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
> >> +KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
> >> +
> >> +Note that the vcpu ioctl is asynchronous to vpcu execution.
> > 
> > typo
> > 
> > 
> 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marcelo Tosatti Oct. 10, 2012, 6:43 p.m. UTC | #5 
On Wed, Oct 10, 2012 at 06:37:57PM +0200, Cornelia Huck wrote:
> On Wed, 10 Oct 2012 13:27:09 -0300
> Marcelo Tosatti <mtosatti@redhat.com> wrote:
> 
> > > +Archtectures: s390
> > 
> > typo.
> 
> > > +Note that the vcpu ioctl is asynchronous to vpcu execution.
> > 
> > typo
> > 
> > 
> 
> Would you like a respin with the typos fixed?

No.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marcelo Tosatti Oct. 10, 2012, 6:57 p.m. UTC | #6 
On Wed, Oct 10, 2012 at 03:43:10PM -0300, Marcelo Tosatti wrote:
> On Wed, Oct 10, 2012 at 06:37:57PM +0200, Cornelia Huck wrote:
> > On Wed, 10 Oct 2012 13:27:09 -0300
> > Marcelo Tosatti <mtosatti@redhat.com> wrote:
> > 
> > > > +Archtectures: s390
> > > 
> > > typo.
> > 
> > > > +Note that the vcpu ioctl is asynchronous to vpcu execution.
> > > 
> > > typo
> > > 
> > > 
> > 
> > Would you like a respin with the typos fixed?
> 
> No.

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index 36befa7..c533338 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -1984,6 +1984,39 @@  return the hash table order in the parameter.  (If the guest is using
 the virtualized real-mode area (VRMA) facility, the kernel will
 re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
 
+4.77 KVM_S390_INTERRUPT
+
+Capability: basic
+Archtectures: s390
+Type: vm ioctl, vcpu ioctl
+Parameters: struct kvm_s390_interrupt (in)
+Returns: 0 on success, -1 on error
+
+Allows to inject an interrupt to the guest. Interrupts can be floating
+(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
+
+Interrupt parameters are passed via kvm_s390_interrupt:
+
+struct kvm_s390_interrupt {
+	__u32 type;
+	__u32 parm;
+	__u64 parm64;
+};
+
+type can be one of the following:
+
+KVM_S390_SIGP_STOP (vcpu) - sigp restart
+KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
+KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
+KVM_S390_RESTART (vcpu) - restart
+KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
+			   parameters in parm and parm64
+KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
+KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
+KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
+
+Note that the vcpu ioctl is asynchronous to vpcu execution.
+
 
 5. The kvm_run structure
 ------------------------