| Message ID | 1351083066-3748-3-git-send-email-william@gandi.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 24 Oct 2012, William Dauchy wrote: > when registering the config interrupt, the later is registered in > vcpi->config_vector and not in vpci->vq_vector > > introduced in: > a841f15 kvm tools: Use the new KVM_SIGNAL_MSI ioctl to inject > interrupts directly. > > Signed-off-by: William Dauchy <william@gandi.net> > --- > tools/kvm/virtio/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c > index ab1119a..f4ea3c9 100644 > --- a/tools/kvm/virtio/pci.c > +++ b/tools/kvm/virtio/pci.c > @@ -288,7 +288,7 @@ int virtio_pci__signal_config(struct kvm *kvm, struct virtio_device *vdev) > } > > if (vpci->features & VIRTIO_PCI_F_SIGNAL_MSI) > - virtio_pci__signal_msi(kvm, vpci, vpci->vq_vector[vpci->config_vector]); > + virtio_pci__signal_msi(kvm, vpci, vpci->config_vector); > else > kvm__irq_trigger(kvm, vpci->config_gsi); > } else { Sasha? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 25, 2012 at 3:03 AM, Pekka Enberg <penberg@kernel.org> wrote: > On Wed, 24 Oct 2012, William Dauchy wrote: >> when registering the config interrupt, the later is registered in >> vcpi->config_vector and not in vpci->vq_vector >> >> introduced in: >> a841f15 kvm tools: Use the new KVM_SIGNAL_MSI ioctl to inject >> interrupts directly. >> >> Signed-off-by: William Dauchy <william@gandi.net> >> --- >> tools/kvm/virtio/pci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c >> index ab1119a..f4ea3c9 100644 >> --- a/tools/kvm/virtio/pci.c >> +++ b/tools/kvm/virtio/pci.c >> @@ -288,7 +288,7 @@ int virtio_pci__signal_config(struct kvm *kvm, struct virtio_device *vdev) >> } >> >> if (vpci->features & VIRTIO_PCI_F_SIGNAL_MSI) >> - virtio_pci__signal_msi(kvm, vpci, vpci->vq_vector[vpci->config_vector]); >> + virtio_pci__signal_msi(kvm, vpci, vpci->config_vector); >> else >> kvm__irq_trigger(kvm, vpci->config_gsi); >> } else { > > Sasha? Indeed, we tried signaling the config vector by signaling vq0, woops. Acked-by: Sasha Levin <levinsasha928@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 25 Oct 2012, Sasha Levin wrote: > On Thu, Oct 25, 2012 at 3:03 AM, Pekka Enberg <penberg@kernel.org> wrote: > > On Wed, 24 Oct 2012, William Dauchy wrote: > >> when registering the config interrupt, the later is registered in > >> vcpi->config_vector and not in vpci->vq_vector > >> > >> introduced in: > >> a841f15 kvm tools: Use the new KVM_SIGNAL_MSI ioctl to inject > >> interrupts directly. > >> > >> Signed-off-by: William Dauchy <william@gandi.net> > >> --- > >> tools/kvm/virtio/pci.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c > >> index ab1119a..f4ea3c9 100644 > >> --- a/tools/kvm/virtio/pci.c > >> +++ b/tools/kvm/virtio/pci.c > >> @@ -288,7 +288,7 @@ int virtio_pci__signal_config(struct kvm *kvm, struct virtio_device *vdev) > >> } > >> > >> if (vpci->features & VIRTIO_PCI_F_SIGNAL_MSI) > >> - virtio_pci__signal_msi(kvm, vpci, vpci->vq_vector[vpci->config_vector]); > >> + virtio_pci__signal_msi(kvm, vpci, vpci->config_vector); > >> else > >> kvm__irq_trigger(kvm, vpci->config_gsi); > >> } else { > > > > Sasha? > > Indeed, we tried signaling the config vector by signaling vq0, woops. > > Acked-by: Sasha Levin <levinsasha928@gmail.com> Applied, thanks guys! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c index ab1119a..f4ea3c9 100644 --- a/tools/kvm/virtio/pci.c +++ b/tools/kvm/virtio/pci.c @@ -288,7 +288,7 @@ int virtio_pci__signal_config(struct kvm *kvm, struct virtio_device *vdev) } if (vpci->features & VIRTIO_PCI_F_SIGNAL_MSI) - virtio_pci__signal_msi(kvm, vpci, vpci->vq_vector[vpci->config_vector]); + virtio_pci__signal_msi(kvm, vpci, vpci->config_vector); else kvm__irq_trigger(kvm, vpci->config_gsi); } else {
when registering the config interrupt, the later is registered in vcpi->config_vector and not in vpci->vq_vector introduced in: a841f15 kvm tools: Use the new KVM_SIGNAL_MSI ioctl to inject interrupts directly. Signed-off-by: William Dauchy <william@gandi.net> --- tools/kvm/virtio/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)