diff mbox

[5/5] kvm tools: specify the amount to balloon is in MB

Message ID 1351083066-3748-6-git-send-email-william@gandi.net (mailing list archive)
State New, archived
Headers show

Commit Message

William Dauchy Oct. 24, 2012, 12:51 p.m. UTC 
Signed-off-by: William Dauchy <william@gandi.net>
---
 tools/kvm/builtin-balloon.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Pekka Enberg Oct. 25, 2012, 7:10 a.m. UTC | #1 
> Signed-off-by: William Dauchy <william@gandi.net>
> ---
>  tools/kvm/builtin-balloon.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/kvm/builtin-balloon.c b/tools/kvm/builtin-balloon.c
> index 5bd2291..d158ace 100644
> --- a/tools/kvm/builtin-balloon.c
> +++ b/tools/kvm/builtin-balloon.c
> @@ -22,8 +22,8 @@ static const struct option balloon_options[] = {
>  	OPT_GROUP("Instance options:"),
>  	OPT_STRING('n', "name", &instance_name, "name", "Instance name"),
>  	OPT_GROUP("Balloon options:"),
> -	OPT_U64('i', "inflate", &inflate, "Amount to inflate"),
> -	OPT_U64('d', "deflate", &deflate, "Amount to deflate"),
> +	OPT_U64('i', "inflate", &inflate, "Amount to inflate (in MB)"),
> +	OPT_U64('d', "deflate", &deflate, "Amount to deflate (in MB)"),
>  	OPT_END(),
>  };

Applied, thanks!

Btw, looks like tools/kvm/virtio/ballon.c::handle_mem() is broken on 
architectures that don't use 4K pages. I'm happy to apply a patch that 
fixes it :-)

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tools/kvm/builtin-balloon.c b/tools/kvm/builtin-balloon.c
index 5bd2291..d158ace 100644
--- a/tools/kvm/builtin-balloon.c
+++ b/tools/kvm/builtin-balloon.c
@@ -22,8 +22,8 @@  static const struct option balloon_options[] = {
 	OPT_GROUP("Instance options:"),
 	OPT_STRING('n', "name", &instance_name, "name", "Instance name"),
 	OPT_GROUP("Balloon options:"),
-	OPT_U64('i', "inflate", &inflate, "Amount to inflate"),
-	OPT_U64('d', "deflate", &deflate, "Amount to deflate"),
+	OPT_U64('i', "inflate", &inflate, "Amount to inflate (in MB)"),
+	OPT_U64('d', "deflate", &deflate, "Amount to deflate (in MB)"),
 	OPT_END(),
 };