From patchwork Tue Oct 30 12:16:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1670141 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 474823FE1C for ; Tue, 30 Oct 2012 12:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933495Ab2J3MRB (ORCPT ); Tue, 30 Oct 2012 08:17:01 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:35878 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933424Ab2J3MQ7 (ORCPT ); Tue, 30 Oct 2012 08:16:59 -0400 Received: by mail-da0-f46.google.com with SMTP id n41so88016dak.19 for ; Tue, 30 Oct 2012 05:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=4y6Id69jEJMd8jZKB9DsJQrS1nBO8YwqZG4JTSdzN0A=; b=gDMpHnZ1S3EFivJlWGYtCBp5lfHBfGMpD+a2BPYkT0ZvlvNaijVFROrLG7IDYf+JsI +rdUuz6DJLTGgFw447v2vHuL/pxtLKA+UGvfZZaXIDsoUbqCy8nvkf3z/wsZM6uaakNd FyvHgSzCsoY90pOCL8FOAqF+M0HFvtwxdGWrZbHyVrHdJVUtz6bdEjGhNo7aDjM1ADzo rT/yZV/bP8MQvjLLVGbomFH15dOTpJ/nfwVDRth/Q7UCKur3afl0IyHs6bkHKPuEqNJ9 hrby0LNz1Ua0l88LdXB/WEeUb6q9YZpVNc+NlL3D1xjO/tan/fFLi86yfUGx5hFGR28J lw7A== Received: by 10.68.222.138 with SMTP id qm10mr101407155pbc.129.1351599418972; Tue, 30 Oct 2012 05:16:58 -0700 (PDT) Received: from yakj.usersys.redhat.com (93-34-169-1.ip50.fastwebnet.it. [93.34.169.1]) by mx.google.com with ESMTPS id o10sm319041paz.37.2012.10.30.05.16.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 30 Oct 2012 05:16:58 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: avi@redhat.com, mtosatti@redhat.com, jan.kiszka@siemens.com, kvm@vger.kernel.org Subject: [PATCH 3/3] apic: always update the in-kernel status after loading Date: Tue, 30 Oct 2012 13:16:32 +0100 Message-Id: <1351599394-24876-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.12.1 In-Reply-To: <1351599394-24876-1-git-send-email-pbonzini@redhat.com> References: <1351599394-24876-1-git-send-email-pbonzini@redhat.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org The LAPIC is loaded separately from the rest of the VCPU state. Thus, when restoring the CPU the dummy post-reset state is passed to the in-kernel APIC. This can cause MSI injection to fail if attempted during the restore of another device, because the LAPIC believes it's not enabled. Signed-off-by: Paolo Bonzini --- hw/apic_common.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/apic_common.c b/hw/apic_common.c index f373ba8..1ef52b2 100644 --- a/hw/apic_common.c +++ b/hw/apic_common.c @@ -362,6 +362,7 @@ static int apic_dispatch_post_load(void *opaque, int version_id) if (info->post_load) { info->post_load(s); } + cpu_put_apic_state(DEVICE(s)); return 0; }