From patchwork Thu Feb 21 13:12:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cornelia Huck X-Patchwork-Id: 2171461 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 18B6A3FCA4 for ; Thu, 21 Feb 2013 13:13:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717Ab3BUNNa (ORCPT ); Thu, 21 Feb 2013 08:13:30 -0500 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:41947 "EHLO e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753034Ab3BUNNI (ORCPT ); Thu, 21 Feb 2013 08:13:08 -0500 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 21 Feb 2013 13:11:00 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 21 Feb 2013 13:10:56 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3339F17D805C; Thu, 21 Feb 2013 13:13:31 +0000 (GMT) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r1LDCqX226214416; Thu, 21 Feb 2013 13:12:52 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r1LC9Q8S016412; Thu, 21 Feb 2013 07:09:26 -0500 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r1LC9Qo7016380; Thu, 21 Feb 2013 07:09:26 -0500 From: Cornelia Huck To: KVM Cc: linux-s390 , qemu-devel Subject: [RFC PATCH 1/3] KVM: s390: Move out initialization code. Date: Thu, 21 Feb 2013 14:12:58 +0100 Message-Id: <1361452380-50398-2-git-send-email-cornelia.huck@de.ibm.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1361452380-50398-1-git-send-email-cornelia.huck@de.ibm.com> References: <1361452380-50398-1-git-send-email-cornelia.huck@de.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13022113-5024-0000-0000-00000545A6A7 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org kvm-s390's module initialization code needs to live in a separate module (kvm-s390.ko) if we want to include eventfd (which has its own module init func). Signed-off-by: Cornelia Huck --- arch/s390/kvm/Makefile | 4 +++- arch/s390/kvm/init.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++ arch/s390/kvm/kvm-s390.c | 38 ++++------------------------------- 3 files changed, 59 insertions(+), 35 deletions(-) create mode 100644 arch/s390/kvm/init.c diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile index 3975722..2441ffd 100644 --- a/arch/s390/kvm/Makefile +++ b/arch/s390/kvm/Makefile @@ -11,4 +11,6 @@ common-objs = $(addprefix ../../../virt/kvm/, kvm_main.o) ccflags-y := -Ivirt/kvm -Iarch/s390/kvm kvm-objs := $(common-objs) kvm-s390.o intercept.o interrupt.o priv.o sigp.o diag.o -obj-$(CONFIG_KVM) += kvm.o +kvm_s390-objs := init.o + +obj-$(CONFIG_KVM) += kvm.o kvm_s390.o diff --git a/arch/s390/kvm/init.c b/arch/s390/kvm/init.c new file mode 100644 index 0000000..dc4028a --- /dev/null +++ b/arch/s390/kvm/init.c @@ -0,0 +1,52 @@ +/* + * kvm on s390 module initialization + * + * Copyright IBM Corp. 2013 + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License (version 2 only) + * as published by the Free Software Foundation. + * + * Author(s): Cornelia Huck + */ + +#include +#include +#include +#include "kvm-s390.h" + +extern unsigned long long *facilities; + +static int __init kvm_s390_init(void) +{ + int ret; + ret = kvm_init(NULL, sizeof(struct kvm_vcpu), 0, THIS_MODULE); + if (ret) + return ret; + + /* + * guests can ask for up to 255+1 double words, we need a full page + * to hold the maximum amount of facilities. On the other hand, we + * only set facilities that are known to work in KVM. + */ + facilities = (unsigned long long *) get_zeroed_page(GFP_KERNEL|GFP_DMA); + if (!facilities) { + kvm_exit(); + return -ENOMEM; + } + memcpy(facilities, S390_lowcore.stfle_fac_list, 16); + facilities[0] &= 0xff00fff3f47c0000ULL; + facilities[1] &= 0x001c000000000000ULL; + return 0; +} + +static void __exit kvm_s390_exit(void) +{ + free_page((unsigned long) facilities); + kvm_exit(); +} + +module_init(kvm_s390_init); +module_exit(kvm_s390_exit); + +MODULE_LICENSE("GPL"); diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index f822d36..58a5f03 100644 --- a/arch/s390/kvm/kvm-s390.c +++ b/arch/s390/kvm/kvm-s390.c @@ -36,6 +36,9 @@ #include "trace.h" #include "trace-s390.h" +unsigned long long *facilities; +EXPORT_SYMBOL_GPL(facilities); + #define VCPU_STAT(x) offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU struct kvm_stats_debugfs_item debugfs_entries[] = { @@ -83,8 +86,6 @@ struct kvm_stats_debugfs_item debugfs_entries[] = { { NULL } }; -static unsigned long long *facilities; - /* Section: not file related */ int kvm_arch_hardware_enable(void *garbage) { @@ -823,6 +824,7 @@ int kvm_s390_vcpu_store_status(struct kvm_vcpu *vcpu, unsigned long addr) return -EFAULT; return 0; } +EXPORT_SYMBOL_GPL(kvm_s390_vcpu_store_status); static int kvm_vcpu_ioctl_enable_cap(struct kvm_vcpu *vcpu, struct kvm_enable_cap *cap) @@ -1026,35 +1028,3 @@ void kvm_arch_flush_shadow_memslot(struct kvm *kvm, struct kvm_memory_slot *slot) { } - -static int __init kvm_s390_init(void) -{ - int ret; - ret = kvm_init(NULL, sizeof(struct kvm_vcpu), 0, THIS_MODULE); - if (ret) - return ret; - - /* - * guests can ask for up to 255+1 double words, we need a full page - * to hold the maximum amount of facilities. On the other hand, we - * only set facilities that are known to work in KVM. - */ - facilities = (unsigned long long *) get_zeroed_page(GFP_KERNEL|GFP_DMA); - if (!facilities) { - kvm_exit(); - return -ENOMEM; - } - memcpy(facilities, S390_lowcore.stfle_fac_list, 16); - facilities[0] &= 0xff00fff3f47c0000ULL; - facilities[1] &= 0x001c000000000000ULL; - return 0; -} - -static void __exit kvm_s390_exit(void) -{ - free_page((unsigned long) facilities); - kvm_exit(); -} - -module_init(kvm_s390_init); -module_exit(kvm_s390_exit);