From patchwork Wed Mar 20 08:30:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Guangrong X-Patchwork-Id: 2305791 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id A5887DF24C for ; Wed, 20 Mar 2013 08:33:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934274Ab3CTIau (ORCPT ); Wed, 20 Mar 2013 04:30:50 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:41332 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758059Ab3CTIap (ORCPT ); Wed, 20 Mar 2013 04:30:45 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Mar 2013 13:56:57 +0530 Received: from d28dlp01.in.ibm.com (9.184.220.126) by e28smtp07.in.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 20 Mar 2013 13:56:55 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id A0D11E0059; Wed, 20 Mar 2013 14:02:08 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2K8Ucxa51773606; Wed, 20 Mar 2013 14:00:38 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2K8UeX7016709; Wed, 20 Mar 2013 19:30:40 +1100 Received: from localhost ([9.125.26.89]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r2K8Uc1p016450; Wed, 20 Mar 2013 19:30:39 +1100 From: Xiao Guangrong To: mtosatti@redhat.com Cc: gleb@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Xiao Guangrong Subject: [PATCH v2 2/7] KVM: x86: introduce memslot_set_lpage_disallowed Date: Wed, 20 Mar 2013 16:30:22 +0800 Message-Id: <1363768227-4782-3-git-send-email-xiaoguangrong@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1363768227-4782-1-git-send-email-xiaoguangrong@linux.vnet.ibm.com> References: <1363768227-4782-1-git-send-email-xiaoguangrong@linux.vnet.ibm.com> X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13032008-8878-0000-0000-0000065EB39C Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org It is used to set disallowed lage page on the specified level, can be used in later patch Signed-off-by: Xiao Guangrong --- arch/x86/kvm/x86.c | 53 ++++++++++++++++++++++++++++++++++----------------- 1 files changed, 35 insertions(+), 18 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 6622ac0..e0a7f67 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -6868,12 +6868,45 @@ void kvm_arch_free_memslot(struct kvm_memory_slot *free, } } +static void +memslot_set_lpage_disallowed(struct kvm_memory_slot *slot, + unsigned long npages, int lpage_size, + int lpages) +{ + struct kvm_lpage_info *lpage_info; + unsigned long ugfn; + int level = lpage_size + 1; + + WARN_ON(!lpage_size); + + lpage_info = slot->arch.lpage_info[lpage_size - 1]; + + if (slot->base_gfn & (KVM_PAGES_PER_HPAGE(level) - 1)) + lpage_info[0].write_count = 1; + + if ((slot->base_gfn + npages) & (KVM_PAGES_PER_HPAGE(level) - 1)) + lpage_info[lpages - 1].write_count = 1; + + ugfn = slot->userspace_addr >> PAGE_SHIFT; + /* + * If the gfn and userspace address are not aligned wrt each + * other, or if explicitly asked to, disable large page + * support for this slot + */ + if ((slot->base_gfn ^ ugfn) & (KVM_PAGES_PER_HPAGE(level) - 1) || + !kvm_largepages_enabled()) { + unsigned long j; + + for (j = 0; j < lpages; ++j) + lpage_info[j].write_count = 1; + } +} + int kvm_arch_create_memslot(struct kvm_memory_slot *slot, unsigned long npages) { int i; for (i = 0; i < KVM_NR_PAGE_SIZES; ++i) { - unsigned long ugfn; int lpages; int level = i + 1; @@ -6892,23 +6925,7 @@ int kvm_arch_create_memslot(struct kvm_memory_slot *slot, unsigned long npages) if (!slot->arch.lpage_info[i - 1]) goto out_free; - if (slot->base_gfn & (KVM_PAGES_PER_HPAGE(level) - 1)) - slot->arch.lpage_info[i - 1][0].write_count = 1; - if ((slot->base_gfn + npages) & (KVM_PAGES_PER_HPAGE(level) - 1)) - slot->arch.lpage_info[i - 1][lpages - 1].write_count = 1; - ugfn = slot->userspace_addr >> PAGE_SHIFT; - /* - * If the gfn and userspace address are not aligned wrt each - * other, or if explicitly asked to, disable large page - * support for this slot - */ - if ((slot->base_gfn ^ ugfn) & (KVM_PAGES_PER_HPAGE(level) - 1) || - !kvm_largepages_enabled()) { - unsigned long j; - - for (j = 0; j < lpages; ++j) - slot->arch.lpage_info[i - 1][j].write_count = 1; - } + memslot_set_lpage_disallowed(slot, npages, i, lpages); } return 0;