| Message ID | 1369222162-4857-1-git-send-email-james.hogan@imgtec.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, May 22, 2013 at 12:29:22PM +0100, James Hogan wrote: > According to include/uapi/linux/kvm_para.h architectures should define > kvm_para_available, so add an implementation to asm-generic/kvm_para.h > which just returns false. > What is this fixing? The only user of kvm_para_available() that can benefit from this is in sound/pci/intel8x0.c, but I do not see follow up patch to use it there. > Signed-off-by: James Hogan <james.hogan@imgtec.com> > Cc: Marcelo Tosatti <mtosatti@redhat.com> > Cc: Gleb Natapov <gleb@redhat.com> > Cc: Arnd Bergmann <arnd@arndb.de> > --- > include/asm-generic/kvm_para.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h > index 9d96605..fa25bec 100644 > --- a/include/asm-generic/kvm_para.h > +++ b/include/asm-generic/kvm_para.h > @@ -18,4 +18,9 @@ static inline unsigned int kvm_arch_para_features(void) > return 0; > } > > +static inline bool kvm_para_available(void) > +{ > + return false; > +} > + > #endif > -- > 1.8.1.2 > -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 4 June 2013 10:05, Gleb Natapov <gleb@redhat.com> wrote: > On Wed, May 22, 2013 at 12:29:22PM +0100, James Hogan wrote: >> According to include/uapi/linux/kvm_para.h architectures should define >> kvm_para_available, so add an implementation to asm-generic/kvm_para.h >> which just returns false. >> > What is this fixing? The only user of kvm_para_available() that can > benefit from this is in sound/pci/intel8x0.c, but I do not see follow up > patch to use it there. It was an unintentional config with mips + kvm + intel8x0 that hit it (I think I accidentally based my mips config off an x86_64 config). Kind of equivalent to a randconfig build failure I suppose. Cheers James -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 04, 2013 at 12:33:19PM +0100, James Hogan wrote: > On 4 June 2013 10:05, Gleb Natapov <gleb@redhat.com> wrote: > > On Wed, May 22, 2013 at 12:29:22PM +0100, James Hogan wrote: > >> According to include/uapi/linux/kvm_para.h architectures should define > >> kvm_para_available, so add an implementation to asm-generic/kvm_para.h > >> which just returns false. > >> > > What is this fixing? The only user of kvm_para_available() that can > > benefit from this is in sound/pci/intel8x0.c, but I do not see follow up > > patch to use it there. > > It was an unintentional config with mips + kvm + intel8x0 that hit it > (I think I accidentally based my mips config off an x86_64 config). > Kind of equivalent to a randconfig build failure I suppose. > Yes, I see. I will queue the fix. Thanks! -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h index 9d96605..fa25bec 100644 --- a/include/asm-generic/kvm_para.h +++ b/include/asm-generic/kvm_para.h @@ -18,4 +18,9 @@ static inline unsigned int kvm_arch_para_features(void) return 0; } +static inline bool kvm_para_available(void) +{ + return false; +} + #endif
According to include/uapi/linux/kvm_para.h architectures should define kvm_para_available, so add an implementation to asm-generic/kvm_para.h which just returns false. Signed-off-by: James Hogan <james.hogan@imgtec.com> Cc: Marcelo Tosatti <mtosatti@redhat.com> Cc: Gleb Natapov <gleb@redhat.com> Cc: Arnd Bergmann <arnd@arndb.de> --- include/asm-generic/kvm_para.h | 5 +++++ 1 file changed, 5 insertions(+)