diff mbox

KVM: s390: Add "devname:kvm" alias.

Message ID 1369672953-33705-2-git-send-email-cornelia.huck@de.ibm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Cornelia Huck May 27, 2013, 4:42 p.m. UTC
Providing a "devname:kvm" module alias enables automatic loading of
the kvm module when /dev/kvm is opened.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 arch/s390/kvm/kvm-s390.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Paolo Bonzini May 28, 2013, 9 a.m. UTC | #1
Il 27/05/2013 18:42, Cornelia Huck ha scritto:
> Providing a "devname:kvm" module alias enables automatic loading of
> the kvm module when /dev/kvm is opened.
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 93444c4..3b597e5 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>  
>  module_init(kvm_s390_init);
>  module_exit(kvm_s390_exit);
> +
> +/*
> + * Enable autoloading of the kvm module.
> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
> + * since x86 takes a different approach.
> + */
> +#include <linux/miscdevice.h>
> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
> +MODULE_ALIAS("devname:kvm");
> 

Looks good for 3.10.  Should I take this since Alex is on holiday, or
should I wait for him to come back?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christian Borntraeger May 28, 2013, 9:07 a.m. UTC | #2
On 28/05/13 11:00, Paolo Bonzini wrote:

> Looks good for 3.10.  Should I take this since Alex is on holiday, or
> should I wait for him to come back?

let me refer to 
http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/104230
;-)


Christian 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paolo Bonzini May 28, 2013, 10:44 a.m. UTC | #3
Il 27/05/2013 18:42, Cornelia Huck ha scritto:
> Providing a "devname:kvm" module alias enables automatic loading of
> the kvm module when /dev/kvm is opened.
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 93444c4..3b597e5 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>  
>  module_init(kvm_s390_init);
>  module_exit(kvm_s390_exit);
> +
> +/*
> + * Enable autoloading of the kvm module.
> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
> + * since x86 takes a different approach.
> + */
> +#include <linux/miscdevice.h>
> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
> +MODULE_ALIAS("devname:kvm");
> 

Applied, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paolo Bonzini June 3, 2013, 7:50 a.m. UTC | #4
Il 28/05/2013 12:44, Paolo Bonzini ha scritto:
> Il 27/05/2013 18:42, Cornelia Huck ha scritto:
>> Providing a "devname:kvm" module alias enables automatic loading of
>> the kvm module when /dev/kvm is opened.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 93444c4..3b597e5 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>>  
>>  module_init(kvm_s390_init);
>>  module_exit(kvm_s390_exit);
>> +
>> +/*
>> + * Enable autoloading of the kvm module.
>> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
>> + * since x86 takes a different approach.
>> + */
>> +#include <linux/miscdevice.h>
>> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
>> +MODULE_ALIAS("devname:kvm");
>>
> 
> Applied, thanks.

After discussion with Gleb, we have decided to postpone this patch to
3.11.  Thanks for your understanding. :)

I'll push pending patches to master and queue soon.

Paolo

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index 93444c4..3b597e5 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -1138,3 +1138,12 @@  static void __exit kvm_s390_exit(void)
 
 module_init(kvm_s390_init);
 module_exit(kvm_s390_exit);
+
+/*
+ * Enable autoloading of the kvm module.
+ * Note that we add the module alias here instead of virt/kvm/kvm_main.c
+ * since x86 takes a different approach.
+ */
+#include <linux/miscdevice.h>
+MODULE_ALIAS_MISCDEV(KVM_MINOR);
+MODULE_ALIAS("devname:kvm");