From patchwork Thu Jun 13 15:16:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Chunqi Li X-Patchwork-Id: 2717281 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0424DC1434 for ; Thu, 13 Jun 2013 15:16:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C3E7020385 for ; Thu, 13 Jun 2013 15:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C494920363 for ; Thu, 13 Jun 2013 15:16:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756580Ab3FMPQl (ORCPT ); Thu, 13 Jun 2013 11:16:41 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:51970 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755782Ab3FMPQk (ORCPT ); Thu, 13 Jun 2013 11:16:40 -0400 Received: by mail-pa0-f47.google.com with SMTP id kl14so4864005pab.20 for ; Thu, 13 Jun 2013 08:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=P0X6Y5Q8SB8e59z2qEw/uhiSZud1Z06mgr9brVqpGDE=; b=bZYBZiPr428Sj2E7Qvu38gBwRXKnavaTRq+Pw2iD+q/oKNIAfvCO9PMkhbr082+9Pr lTEWcrnhnoAG+Xp55dlFZLdsc11RK9n9IsDNucOz2/vhOHEvHHG5O6uJUfVOmyFpKzV0 S8diYrUGhHY6f4jIgZNOOOcyEl41XAr08RVUmUjsn9aIbsOLE61luOf0MtAU21Q7lcd6 du07KzQYPN1VOnGxTO9PjOJMb2kzlkaRgeIBCJzGZjxx9iyEpfIXSefn4/IIBTQXdWBs 98diby+UuOErilRCGbSsFPBXzGrN7KMEdnfnIF9ycF21jQ7a/DprPCnm8X/buiy8cWc0 4psg== X-Received: by 10.68.252.194 with SMTP id zu2mr1332272pbc.58.1371136600154; Thu, 13 Jun 2013 08:16:40 -0700 (PDT) Received: from Blade1-02.Blade1-02 ([162.105.146.101]) by mx.google.com with ESMTPSA id vb8sm23762437pbc.11.2013.06.13.08.16.36 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Jun 2013 08:16:39 -0700 (PDT) From: Arthur Chunqi Li To: kvm@vger.kernel.org Cc: gleb@redhat.com, pbonzini@redhat.com, jan.kiszka@web.de, Arthur Chunqi Li Subject: [PATCH 2/2] kvm-unit-tests: Change two cases to use trap_emulator Date: Thu, 13 Jun 2013 23:16:18 +0800 Message-Id: <1371136578-4047-2-git-send-email-yzt356@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1371136578-4047-1-git-send-email-yzt356@gmail.com> References: <1371136578-4047-1-git-send-email-yzt356@gmail.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Change two functions (test_mmx_movq_mf and test_movabs) using unified trap_emulator. Signed-off-by: Arthur Chunqi Li --- x86/emulator.c | 85 +++++++++++++++----------------------------------------- 1 file changed, 23 insertions(+), 62 deletions(-) diff --git a/x86/emulator.c b/x86/emulator.c index 4981bfb..7698f56 100644 --- a/x86/emulator.c +++ b/x86/emulator.c @@ -826,73 +826,34 @@ static void advance_rip_by_3_and_note_exception(struct ex_regs *regs) static void test_mmx_movq_mf(uint64_t *mem, uint8_t *insn_page, uint8_t *alt_insn_page, void *insn_ram) { - uint16_t fcw = 0; // all exceptions unmasked - ulong *cr3 = (ulong *)read_cr3(); - - write_cr0(read_cr0() & ~6); // TS, EM - // Place a trapping instruction in the page to trigger a VMEXIT - insn_page[0] = 0x89; // mov %eax, (%rax) - insn_page[1] = 0x00; - insn_page[2] = 0x90; // nop - insn_page[3] = 0xc3; // ret - // Place the instruction we want the hypervisor to see in the alternate page - alt_insn_page[0] = 0x0f; // movq %mm0, (%rax) - alt_insn_page[1] = 0x7f; - alt_insn_page[2] = 0x00; - alt_insn_page[3] = 0xc3; // ret - - exceptions = 0; - handle_exception(MF_VECTOR, advance_rip_by_3_and_note_exception); - - // Load the code TLB with insn_page, but point the page tables at - // alt_insn_page (and keep the data TLB clear, for AMD decode assist). - // This will make the CPU trap on the insn_page instruction but the - // hypervisor will see alt_insn_page. - install_page(cr3, virt_to_phys(insn_page), insn_ram); - asm volatile("fninit; fldcw %0" : : "m"(fcw)); - asm volatile("fldz; fldz; fdivp"); // generate exception - invlpg(insn_ram); - // Load code TLB - asm volatile("call *%0" : : "r"(insn_ram + 3)); - install_page(cr3, virt_to_phys(alt_insn_page), insn_ram); - // Trap, let hypervisor emulate at alt_insn_page - asm volatile("call *%0" : : "r"(insn_ram), "a"(mem)); - // exit MMX mode - asm volatile("fnclex; emms"); - report("movq mmx generates #MF", exceptions == 1); - handle_exception(MF_VECTOR, 0); + uint16_t fcw = 0; // all exceptions unmasked + uint8_t alt_insn[] = {0x0f, 0x7f, 0x00}; // movq %mm0, (%rax) + + write_cr0(read_cr0() & ~6); // TS, EM + exceptions = 0; + handle_exception(MF_VECTOR, advance_rip_by_3_and_note_exception); + asm volatile("fninit; fldcw %0" : : "m"(fcw)); + asm volatile("fldz; fldz; fdivp"); // generate exception + + inregs = (struct regs){ 0 }; + trap_emulator(mem, insn_page, alt_insn_page, insn_ram, + alt_insn, 3, 1); + // exit MMX mode + asm volatile("fnclex; emms"); + report("movq mmx generates #MF", exceptions == 1); + handle_exception(MF_VECTOR, 0); } static void test_movabs(uint64_t *mem, uint8_t *insn_page, uint8_t *alt_insn_page, void *insn_ram) { - uint64_t val = 0; - ulong *cr3 = (ulong *)read_cr3(); - - // Pad with RET instructions - memset(insn_page, 0xc3, 4096); - memset(alt_insn_page, 0xc3, 4096); - // Place a trapping instruction in the page to trigger a VMEXIT - insn_page[0] = 0x89; // mov %eax, (%rax) - insn_page[1] = 0x00; - // Place the instruction we want the hypervisor to see in the alternate - // page. A buggy hypervisor will fetch a 32-bit immediate and return - // 0xffffffffc3c3c3c3. - alt_insn_page[0] = 0x48; // mov $0xc3c3c3c3c3c3c3c3, %rcx - alt_insn_page[1] = 0xb9; - - // Load the code TLB with insn_page, but point the page tables at - // alt_insn_page (and keep the data TLB clear, for AMD decode assist). - // This will make the CPU trap on the insn_page instruction but the - // hypervisor will see alt_insn_page. - install_page(cr3, virt_to_phys(insn_page), insn_ram); - // Load code TLB - invlpg(insn_ram); - asm volatile("call *%0" : : "r"(insn_ram + 3)); - // Trap, let hypervisor emulate at alt_insn_page - install_page(cr3, virt_to_phys(alt_insn_page), insn_ram); - asm volatile("call *%1" : "=c"(val) : "r"(insn_ram), "a"(mem), "c"(0)); - report("64-bit mov imm", val == 0xc3c3c3c3c3c3c3c3); + // mov $0xc3c3c3c3c3c3c3c3, %rcx + uint8_t alt_insn[] = {0x48, 0xb9, 0xc3, 0xc3, 0xc3, + 0xc3, 0xc3, 0xc3, 0xc3, 0xc3}; + inregs = (struct regs){ .rbx = 0x5678, .rcx = 0x1234 }; + trap_emulator(mem, insn_page, alt_insn_page, insn_ram, + alt_insn, 10, 1); + report("64-bit mov imm2", outregs.rcx == 0xc3c3c3c3c3c3c3c3); } static void test_crosspage_mmio(volatile uint8_t *mem)