From patchwork Fri Aug 30 22:59:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 2852247 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CF19D9F313 for ; Fri, 30 Aug 2013 23:00:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 18F9620364 for ; Fri, 30 Aug 2013 23:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49CCD2031C for ; Fri, 30 Aug 2013 23:00:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756259Ab3H3XAK (ORCPT ); Fri, 30 Aug 2013 19:00:10 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:59683 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752833Ab3H3XAI (ORCPT ); Fri, 30 Aug 2013 19:00:08 -0400 Received: by mail-pd0-f171.google.com with SMTP id g10so2409547pdj.30 for ; Fri, 30 Aug 2013 16:00:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qSb5DAyu7ISmamqGqm4/iF/pOJZLJoPlQ/JjlA/Bpac=; b=jwW0je8K+kZNNZ5fRIlC2PpowKZ4jACwBl1bOoxqAsIY57k5UzAfue7nbt0zW+zw+X ang5e1Ndap8n8F+7ttYts8xGwkYf+JMeYWYJqbMyjemBKwBL6Y6TWS6NqCI4/hM19n8E 663mrcEWIuRSysJFhpL2p9gec2yn7XIcfUgYyI6zkw9JDSf/hY0nQPxed9Yt2f2+5YpH CQNvoGZAc4sEMX3RZA5G+1YVUDewi/UTo28T7Eul80KP6JSyht2z4fP6/ut0xulNa/JH 6SvQTJsZ3Zz2VrRuphSEG3e1iEvJdJOJpq+T+2hovT6iMTJrt0FBB2pzH99qOinzeu3e GWzg== X-Gm-Message-State: ALoCoQn/rf+Wkl8zp4UVmz/gpHI/zCVXl27jK4YebrIgD4C3wX4O2Yzc5cgXpZJXuKV7c9Kc6/2D X-Received: by 10.66.159.132 with SMTP id xc4mr13517918pab.27.1377903607479; Fri, 30 Aug 2013 16:00:07 -0700 (PDT) Received: from localhost.localdomain (c-67-169-183-77.hsd1.ca.comcast.net. [67.169.183.77]) by mx.google.com with ESMTPSA id om2sm241835pbc.30.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 16:00:06 -0700 (PDT) From: Christoffer Dall To: Gleb Natapov , Paolo Bonzini Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, patches@linaro.org, Christoffer Dall Subject: [PATCH 1/4] ARM: KVM: Fix kvm_set_pte assignment Date: Fri, 30 Aug 2013 15:59:54 -0700 Message-Id: <1377903597-18704-2-git-send-email-christoffer.dall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1377903597-18704-1-git-send-email-christoffer.dall@linaro.org> References: <1377903597-18704-1-git-send-email-christoffer.dall@linaro.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP THe kvm_set_pte function was actually assigning the entire struct to the structure member, which should work because the structure only has that one member, but it is still not very nice. Acked-by: Marc Zyngier Signed-off-by: Christoffer Dall --- arch/arm/include/asm/kvm_mmu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/kvm_mmu.h b/arch/arm/include/asm/kvm_mmu.h index 472ac70..9b28c41 100644 --- a/arch/arm/include/asm/kvm_mmu.h +++ b/arch/arm/include/asm/kvm_mmu.h @@ -64,7 +64,7 @@ void kvm_clear_hyp_idmap(void); static inline void kvm_set_pte(pte_t *pte, pte_t new_pte) { - pte_val(*pte) = new_pte; + *pte = new_pte; /* * flush_pmd_entry just takes a void pointer and cleans the necessary * cache entries, so we can reuse the function for ptes.