| Message ID | 1391845930-28580-1-git-send-email-ak@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Il 08/02/2014 08:51, Andi Kleen ha scritto: > kvm_rebooting is referenced from assembler code, thus > needs to be visible. > > Cc: gleb@redhat.com > Cc: pbonzini@redhat.com > Cc: kvm@vger.kernel.org > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 03a0381..b5ec7fb 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -102,7 +102,7 @@ static void kvm_release_pfn_dirty(pfn_t pfn); > static void mark_page_dirty_in_slot(struct kvm *kvm, > struct kvm_memory_slot *memslot, gfn_t gfn); > > -bool kvm_rebooting; > +__visible bool kvm_rebooting; > EXPORT_SYMBOL_GPL(kvm_rebooting); > > static bool largepages_enabled = true; > Acked-by: Paolo Bonzini <pbonzini@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 8 Feb 2014 08:51:57 +0100 Andi Kleen <ak@linux.intel.com> wrote: > kvm_rebooting is referenced from assembler code, thus > needs to be visible. So I read the gcc page and looked at the __visible definition but I still don't really get it. What goes wrong if the __visible isn't present on these referenced-from-asm identifiers? > Cc: gleb@redhat.com > Cc: pbonzini@redhat.com Grumble. Email addresses go into commits with display names and <>. At least, 89.3% of them do. Some sucker has to go through these and fix them up. I'd prefer it not be me ;) > > ... > > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -102,7 +102,7 @@ static void kvm_release_pfn_dirty(pfn_t pfn); > static void mark_page_dirty_in_slot(struct kvm *kvm, > struct kvm_memory_slot *memslot, gfn_t gfn); > > -bool kvm_rebooting; > +__visible bool kvm_rebooting; > EXPORT_SYMBOL_GPL(kvm_rebooting); > > static bool largepages_enabled = true; -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 03a0381..b5ec7fb 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -102,7 +102,7 @@ static void kvm_release_pfn_dirty(pfn_t pfn); static void mark_page_dirty_in_slot(struct kvm *kvm, struct kvm_memory_slot *memslot, gfn_t gfn); -bool kvm_rebooting; +__visible bool kvm_rebooting; EXPORT_SYMBOL_GPL(kvm_rebooting); static bool largepages_enabled = true;
kvm_rebooting is referenced from assembler code, thus needs to be visible. Cc: gleb@redhat.com Cc: pbonzini@redhat.com Cc: kvm@vger.kernel.org Signed-off-by: Andi Kleen <ak@linux.intel.com> --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)