From patchwork Wed Jun 11 14:01:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 4336381 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6247B9F357 for ; Wed, 11 Jun 2014 14:02:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 75BAC201FE for ; Wed, 11 Jun 2014 14:02:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 564112022A for ; Wed, 11 Jun 2014 14:02:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932335AbaFKOCH (ORCPT ); Wed, 11 Jun 2014 10:02:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1824 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932307AbaFKOCD (ORCPT ); Wed, 11 Jun 2014 10:02:03 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5BE21fi025341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Jun 2014 10:02:01 -0400 Received: from dhcp-27-201.brq.redhat.com (dhcp-1-235.brq.redhat.com [10.34.1.235]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5BE1Zbg014365; Wed, 11 Jun 2014 10:02:00 -0400 From: Andrew Jones To: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Cc: christoffer.dall@linaro.org, pbonzini@redhat.com Subject: [PATCH v5 16/19] arm: Add spinlock implementation Date: Wed, 11 Jun 2014 16:01:31 +0200 Message-Id: <1402495294-30737-17-git-send-email-drjones@redhat.com> In-Reply-To: <1402495294-30737-1-git-send-email-drjones@redhat.com> References: <1402495294-30737-1-git-send-email-drjones@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Christoffer Dall Add simple busy-wait spinlock implementation for ARM. Signed-off-by: Christoffer Dall Signed-off-by: Andrew Jones --- config/config-arm.mak | 3 ++- lib/arm/asm/spinlock.h | 9 ++------- lib/arm/spinlock.c | 28 ++++++++++++++++++++++++++++ 3 files changed, 32 insertions(+), 8 deletions(-) create mode 100644 lib/arm/spinlock.c diff --git a/config/config-arm.mak b/config/config-arm.mak index 915b1cc318d79..d150807ec6fe4 100644 --- a/config/config-arm.mak +++ b/config/config-arm.mak @@ -35,7 +35,8 @@ cflatobjs += \ lib/virtio.o \ lib/virtio-testdev.o \ lib/arm/io.o \ - lib/arm/setup.o + lib/arm/setup.o \ + lib/arm/spinlock.o libeabi = lib/arm/libeabi.a eabiobjs = lib/arm/eabi_compat.o diff --git a/lib/arm/asm/spinlock.h b/lib/arm/asm/spinlock.h index 04f5a1a5538e2..2118a4b3751e0 100644 --- a/lib/arm/asm/spinlock.h +++ b/lib/arm/asm/spinlock.h @@ -5,12 +5,7 @@ struct spinlock { int v; }; -//TODO -static inline void spin_lock(struct spinlock *lock __unused) -{ -} -static inline void spin_unlock(struct spinlock *lock __unused) -{ -} +extern void spin_lock(struct spinlock *lock); +extern void spin_unlock(struct spinlock *lock); #endif /* _ASMARM_SPINLOCK_H_ */ diff --git a/lib/arm/spinlock.c b/lib/arm/spinlock.c new file mode 100644 index 0000000000000..d8a6d4c3383d6 --- /dev/null +++ b/lib/arm/spinlock.c @@ -0,0 +1,28 @@ +#include "libcflat.h" +#include "asm/spinlock.h" +#include "asm/barrier.h" + +void spin_lock(struct spinlock *lock) +{ + u32 val, fail; + + dmb(); + do { + asm volatile( + "1: ldrex %0, [%2]\n" + " teq %0, #0\n" + " bne 1b\n" + " mov %0, #1\n" + " strex %1, %0, [%2]\n" + : "=&r" (val), "=&r" (fail) + : "r" (&lock->v) + : "cc" ); + } while (fail); + dmb(); +} + +void spin_unlock(struct spinlock *lock) +{ + lock->v = 0; + dmb(); +}