| Message ID | 1427446123-11203-1-git-send-email-wanpeng.li@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2015-03-27 at 16:48 +0800, Wanpeng Li wrote: > After commit 6140a8f56238 ("vfio-pci: Add device request interface") merged, > there is error dump when run guest as below: > > qemu-system-x86_64 -enable-kvm -m 2G -smp 2 -net none /root/cathy/rhel6u5.qcow -device vfio-pci,host=03:10.5 > qemu-system-x86_64: -device vfio-pci,host=03:10.5: vfio: Failed to set up error notification > > This is caused by missing one break, this patch fix it. > > Reported-and-tested-by: Liu Rongrong <rongrongx.liu@intel.com> > Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com> > --- > drivers/vfio/pci/vfio_pci_intrs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c > index f88bfdf..d1b6845 100644 > --- a/drivers/vfio/pci/vfio_pci_intrs.c > +++ b/drivers/vfio/pci/vfio_pci_intrs.c > @@ -868,6 +868,7 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags, > func = vfio_pci_set_err_trigger; > break; > } > + break; > case VFIO_PCI_REQ_IRQ_INDEX: > switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) { > case VFIO_IRQ_SET_ACTION_TRIGGER: Thanks for the report. This was already fixed in v4.0-rc4: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/vfio/pci/vfio_pci_intrs.c?id=ec76f4007079469e86e2e44c3e5d1d11086de9d6 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index f88bfdf..d1b6845 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -868,6 +868,7 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags, func = vfio_pci_set_err_trigger; break; } + break; case VFIO_PCI_REQ_IRQ_INDEX: switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) { case VFIO_IRQ_SET_ACTION_TRIGGER:
After commit 6140a8f56238 ("vfio-pci: Add device request interface") merged, there is error dump when run guest as below: qemu-system-x86_64 -enable-kvm -m 2G -smp 2 -net none /root/cathy/rhel6u5.qcow -device vfio-pci,host=03:10.5 qemu-system-x86_64: -device vfio-pci,host=03:10.5: vfio: Failed to set up error notification This is caused by missing one break, this patch fix it. Reported-and-tested-by: Liu Rongrong <rongrongx.liu@intel.com> Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com> --- drivers/vfio/pci/vfio_pci_intrs.c | 1 + 1 file changed, 1 insertion(+)