| Message ID | 1432893209-27313-14-git-send-email-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/29/2015 11:53 AM, Andre Przywara wrote: > If userspace has provided a base address for the ITS register frame, > we enable the bits that advertise LPIs in the GICv3. > When the guest has enabled LPIs and the ITS, we enable the emulation > part by initializing the ITS data structures and trapping on ITS > register frame accesses by the guest. > Also we enable the KVM_SIGNAL_MSI feature to allow userland to inject > MSIs into the guest. Not having enabled the ITS emulation will lead > to a -ENODEV when trying to inject a MSI. in vgic-v3-emul.c you can now remove the old comments saying LPIs are not supported, at the beginning of the file. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > Documentation/virtual/kvm/api.txt | 2 +- > arch/arm64/kvm/Kconfig | 1 + > include/kvm/arm_vgic.h | 10 ++++++++++ > virt/kvm/arm/its-emul.c | 9 ++++++++- > virt/kvm/arm/vgic-v3-emul.c | 20 +++++++++++++++----- > virt/kvm/arm/vgic.c | 10 ++++++++++ > 6 files changed, 45 insertions(+), 7 deletions(-) > > diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt > index 891d64a..d20fd94 100644 > --- a/Documentation/virtual/kvm/api.txt > +++ b/Documentation/virtual/kvm/api.txt > @@ -2108,7 +2108,7 @@ after pausing the vcpu, but before it is resumed. > 4.71 KVM_SIGNAL_MSI > > Capability: KVM_CAP_SIGNAL_MSI > -Architectures: x86 > +Architectures: x86 arm64 > Type: vm ioctl > Parameters: struct kvm_msi (in) > Returns: >0 on delivery, 0 if guest blocked the MSI, and -1 on error > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > index 5105e29..6c432c0 100644 > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -30,6 +30,7 @@ config KVM > select SRCU > select HAVE_KVM_EVENTFD > select HAVE_KVM_IRQFD > + select HAVE_KVM_MSI > ---help--- > Support hosting virtualized guest machines. > > diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h > index 6bb138d..8f1be6a 100644 > --- a/include/kvm/arm_vgic.h > +++ b/include/kvm/arm_vgic.h > @@ -162,6 +162,7 @@ struct vgic_io_device { > > struct vgic_its { > bool enabled; > + struct vgic_io_device iodev; > spinlock_t lock; > u64 cbaser; > int creadr; > @@ -365,4 +366,13 @@ static inline int vgic_v3_probe(struct device_node *vgic_node, > } > #endif > > +#ifdef CONFIG_HAVE_KVM_MSI > +int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi); > +#else > +static inline int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) > +{ > + return -ENODEV; > +} > +#endif > + > #endif > diff --git a/virt/kvm/arm/its-emul.c b/virt/kvm/arm/its-emul.c > index 35e886c..864de19 100644 > --- a/virt/kvm/arm/its-emul.c > +++ b/virt/kvm/arm/its-emul.c > @@ -964,6 +964,7 @@ int vits_init(struct kvm *kvm) > { > struct vgic_dist *dist = &kvm->arch.vgic; > struct vgic_its *its = &dist->its; > + int ret; > > if (IS_VGIC_ADDR_UNDEF(dist->vgic_its_base)) > return -ENXIO; > @@ -977,9 +978,15 @@ int vits_init(struct kvm *kvm) > INIT_LIST_HEAD(&its->device_list); > INIT_LIST_HEAD(&its->collection_list); > > + ret = vgic_register_kvm_io_dev(kvm, dist->vgic_its_base, > + KVM_VGIC_V3_ITS_SIZE, vgicv3_its_ranges, > + -1, &its->iodev); > + if (ret) > + return ret; > + > its->enabled = false; > > - return -ENXIO; > + return 0; > } > > void vits_destroy(struct kvm *kvm) > diff --git a/virt/kvm/arm/vgic-v3-emul.c b/virt/kvm/arm/vgic-v3-emul.c > index 4513551..71d0bcf 100644 > --- a/virt/kvm/arm/vgic-v3-emul.c > +++ b/virt/kvm/arm/vgic-v3-emul.c > @@ -89,10 +89,11 @@ static bool handle_mmio_ctlr(struct kvm_vcpu *vcpu, > /* > * As this implementation does not provide compatibility > * with GICv2 (ARE==1), we report zero CPUs in bits [5..7]. > - * Also LPIs and MBIs are not supported, so we set the respective bits to 0. > - * Also we report at most 2**10=1024 interrupt IDs (to match 1024 SPIs). > + * Also we report at most 2**10=1024 interrupt IDs (to match 1024 SPIs) > + * and provide 16 bits worth of LPI number space (to give 8192 LPIs). 65536 LPIS > */ > -#define INTERRUPT_ID_BITS 10 > +#define INTERRUPT_ID_BITS_SPIS 10 > +#define INTERRUPT_ID_BITS_ITS 16 > static bool handle_mmio_typer(struct kvm_vcpu *vcpu, > struct kvm_exit_mmio *mmio, phys_addr_t offset) > { > @@ -100,7 +101,12 @@ static bool handle_mmio_typer(struct kvm_vcpu *vcpu, > > reg = (min(vcpu->kvm->arch.vgic.nr_irqs, 1024) >> 5) - 1; > > - reg |= (INTERRUPT_ID_BITS - 1) << 19; > + if (vgic_has_its(vcpu->kvm)) { > + reg |= GICD_TYPER_LPIS; > + reg |= (INTERRUPT_ID_BITS_ITS - 1) << 19; > + } else { > + reg |= (INTERRUPT_ID_BITS_SPIS - 1) << 19; > + } > > vgic_reg_access(mmio, ®, offset, > ACCESS_READ_VALUE | ACCESS_WRITE_IGNORED); > @@ -519,7 +525,9 @@ static bool handle_mmio_ctlr_redist(struct kvm_vcpu *vcpu, > vgic_reg_access(mmio, ®, offset, > ACCESS_READ_VALUE | ACCESS_WRITE_VALUE); > if (!dist->lpis_enabled && (reg & GICR_CTLR_ENABLE_LPIS)) { > - /* Eventually do something */ > + dist->lpis_enabled = true; > + vgic_enable_lpis(vcpu); > + return true; > } > return false; > } > @@ -546,6 +554,8 @@ static bool handle_mmio_typer_redist(struct kvm_vcpu *vcpu, > reg = redist_vcpu->vcpu_id << 8; > if (target_vcpu_id == atomic_read(&vcpu->kvm->online_vcpus) - 1) > reg |= GICR_TYPER_LAST; > + if (vgic_has_its(vcpu->kvm)) > + reg |= GICR_TYPER_PLPIS; > vgic_reg_access(mmio, ®, offset, > ACCESS_READ_VALUE | ACCESS_WRITE_IGNORED); > return false; > diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c > index 9f7b05f..09b1f46 100644 > --- a/virt/kvm/arm/vgic.c > +++ b/virt/kvm/arm/vgic.c > @@ -2254,3 +2254,13 @@ int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e, > { > return 0; > } > + > +#ifdef CONFIG_HAVE_KVM_MSI > +int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) > +{ > + if (kvm->arch.vgic.vm_ops.inject_msi) > + return kvm->arch.vgic.vm_ops.inject_msi(kvm, msi); vits_inject_msi returns 0 on success while KVM API says KVM_SIGNAL_MSI should return > 0 on delivery and 0 is guest blocked the MSI and -1 on error Eric > + else > + return -ENODEV; > +} > +#endif > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/29/2015 11:53 AM, Andre Przywara wrote: > If userspace has provided a base address for the ITS register frame, > we enable the bits that advertise LPIs in the GICv3. > When the guest has enabled LPIs and the ITS, we enable the emulation > part by initializing the ITS data structures and trapping on ITS > register frame accesses by the guest. > Also we enable the KVM_SIGNAL_MSI feature to allow userland to inject > MSIs into the guest. Not having enabled the ITS emulation will lead > to a -ENODEV when trying to inject a MSI. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > Documentation/virtual/kvm/api.txt | 2 +- > arch/arm64/kvm/Kconfig | 1 + > include/kvm/arm_vgic.h | 10 ++++++++++ > virt/kvm/arm/its-emul.c | 9 ++++++++- > virt/kvm/arm/vgic-v3-emul.c | 20 +++++++++++++++----- > virt/kvm/arm/vgic.c | 10 ++++++++++ > 6 files changed, 45 insertions(+), 7 deletions(-) > > diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt > index 891d64a..d20fd94 100644 > --- a/Documentation/virtual/kvm/api.txt > +++ b/Documentation/virtual/kvm/api.txt > @@ -2108,7 +2108,7 @@ after pausing the vcpu, but before it is resumed. > 4.71 KVM_SIGNAL_MSI > > Capability: KVM_CAP_SIGNAL_MSI > -Architectures: x86 > +Architectures: x86 arm64 > Type: vm ioctl > Parameters: struct kvm_msi (in) > Returns: >0 on delivery, 0 if guest blocked the MSI, and -1 on error > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > index 5105e29..6c432c0 100644 > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -30,6 +30,7 @@ config KVM > select SRCU > select HAVE_KVM_EVENTFD > select HAVE_KVM_IRQFD > + select HAVE_KVM_MSI > ---help--- > Support hosting virtualized guest machines. > > diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h > index 6bb138d..8f1be6a 100644 > --- a/include/kvm/arm_vgic.h > +++ b/include/kvm/arm_vgic.h > @@ -162,6 +162,7 @@ struct vgic_io_device { > > struct vgic_its { > bool enabled; > + struct vgic_io_device iodev; > spinlock_t lock; > u64 cbaser; > int creadr; > @@ -365,4 +366,13 @@ static inline int vgic_v3_probe(struct device_node *vgic_node, > } > #endif > > +#ifdef CONFIG_HAVE_KVM_MSI > +int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi); > +#else > +static inline int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) > +{ > + return -ENODEV; > +} > +#endif > + > #endif > diff --git a/virt/kvm/arm/its-emul.c b/virt/kvm/arm/its-emul.c > index 35e886c..864de19 100644 > --- a/virt/kvm/arm/its-emul.c > +++ b/virt/kvm/arm/its-emul.c > @@ -964,6 +964,7 @@ int vits_init(struct kvm *kvm) > { > struct vgic_dist *dist = &kvm->arch.vgic; > struct vgic_its *its = &dist->its; > + int ret; > > if (IS_VGIC_ADDR_UNDEF(dist->vgic_its_base)) > return -ENXIO; > @@ -977,9 +978,15 @@ int vits_init(struct kvm *kvm) > INIT_LIST_HEAD(&its->device_list); > INIT_LIST_HEAD(&its->collection_list); > > + ret = vgic_register_kvm_io_dev(kvm, dist->vgic_its_base, > + KVM_VGIC_V3_ITS_SIZE, vgicv3_its_ranges, > + -1, &its->iodev); > + if (ret) > + return ret; > + > its->enabled = false; > > - return -ENXIO; > + return 0; > } > > void vits_destroy(struct kvm *kvm) > diff --git a/virt/kvm/arm/vgic-v3-emul.c b/virt/kvm/arm/vgic-v3-emul.c > index 4513551..71d0bcf 100644 > --- a/virt/kvm/arm/vgic-v3-emul.c > +++ b/virt/kvm/arm/vgic-v3-emul.c > @@ -89,10 +89,11 @@ static bool handle_mmio_ctlr(struct kvm_vcpu *vcpu, > /* > * As this implementation does not provide compatibility > * with GICv2 (ARE==1), we report zero CPUs in bits [5..7]. > - * Also LPIs and MBIs are not supported, so we set the respective bits to 0. > - * Also we report at most 2**10=1024 interrupt IDs (to match 1024 SPIs). > + * Also we report at most 2**10=1024 interrupt IDs (to match 1024 SPIs) > + * and provide 16 bits worth of LPI number space (to give 8192 LPIs). > */ > -#define INTERRUPT_ID_BITS 10 > +#define INTERRUPT_ID_BITS_SPIS 10 > +#define INTERRUPT_ID_BITS_ITS 16 > static bool handle_mmio_typer(struct kvm_vcpu *vcpu, > struct kvm_exit_mmio *mmio, phys_addr_t offset) > { > @@ -100,7 +101,12 @@ static bool handle_mmio_typer(struct kvm_vcpu *vcpu, > > reg = (min(vcpu->kvm->arch.vgic.nr_irqs, 1024) >> 5) - 1; > > - reg |= (INTERRUPT_ID_BITS - 1) << 19; > + if (vgic_has_its(vcpu->kvm)) { > + reg |= GICD_TYPER_LPIS; > + reg |= (INTERRUPT_ID_BITS_ITS - 1) << 19; > + } else { > + reg |= (INTERRUPT_ID_BITS_SPIS - 1) << 19; > + } > > vgic_reg_access(mmio, ®, offset, > ACCESS_READ_VALUE | ACCESS_WRITE_IGNORED); > @@ -519,7 +525,9 @@ static bool handle_mmio_ctlr_redist(struct kvm_vcpu *vcpu, > vgic_reg_access(mmio, ®, offset, > ACCESS_READ_VALUE | ACCESS_WRITE_VALUE); > if (!dist->lpis_enabled && (reg & GICR_CTLR_ENABLE_LPIS)) { > - /* Eventually do something */ > + dist->lpis_enabled = true; > + vgic_enable_lpis(vcpu); > + return true; > } > return false; > } > @@ -546,6 +554,8 @@ static bool handle_mmio_typer_redist(struct kvm_vcpu *vcpu, > reg = redist_vcpu->vcpu_id << 8; > if (target_vcpu_id == atomic_read(&vcpu->kvm->online_vcpus) - 1) > reg |= GICR_TYPER_LAST; > + if (vgic_has_its(vcpu->kvm)) > + reg |= GICR_TYPER_PLPIS; > vgic_reg_access(mmio, ®, offset, > ACCESS_READ_VALUE | ACCESS_WRITE_IGNORED); > return false; > diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c > index 9f7b05f..09b1f46 100644 > --- a/virt/kvm/arm/vgic.c > +++ b/virt/kvm/arm/vgic.c > @@ -2254,3 +2254,13 @@ int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e, > { > return 0; > } > + > +#ifdef CONFIG_HAVE_KVM_MSI I don't think the if#def is requested since the entry is already prevented in kvm_main.c in, case KVM_SIGNAL_MSI. Eric > +int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) > +{ > + if (kvm->arch.vgic.vm_ops.inject_msi) > + return kvm->arch.vgic.vm_ops.inject_msi(kvm, msi); > + else > + return -ENODEV; > +} > +#endif > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Eric, On 06/18/2015 09:43 AM, Eric Auger wrote: > On 05/29/2015 11:53 AM, Andre Przywara wrote: >> If userspace has provided a base address for the ITS register frame, >> we enable the bits that advertise LPIs in the GICv3. >> When the guest has enabled LPIs and the ITS, we enable the emulation >> part by initializing the ITS data structures and trapping on ITS >> register frame accesses by the guest. >> Also we enable the KVM_SIGNAL_MSI feature to allow userland to inject >> MSIs into the guest. Not having enabled the ITS emulation will lead >> to a -ENODEV when trying to inject a MSI. >> .... >> Signed-off-by: Andre Przywara <andre.przywara@arm.com> >> diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c >> index 9f7b05f..09b1f46 100644 >> --- a/virt/kvm/arm/vgic.c >> +++ b/virt/kvm/arm/vgic.c >> @@ -2254,3 +2254,13 @@ int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e, >> { >> return 0; >> } >> + >> +#ifdef CONFIG_HAVE_KVM_MSI > I don't think the if#def is requested since the entry is already > prevented in kvm_main.c in, case KVM_SIGNAL_MSI. But that fails compilation on ARM (which uses this file as well), because we have a dummy fail function in the header if CONFIG_HAVE_KVM_MSI is not defined. So you get: error: redefinition of 'kvm_send_userspace_msi' Cheers, Andre. >> +int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) >> +{ >> + if (kvm->arch.vgic.vm_ops.inject_msi) >> + return kvm->arch.vgic.vm_ops.inject_msi(kvm, msi); >> + else >> + return -ENODEV; >> +} >> +#endif >> > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello! > But that fails compilation on ARM (which uses this file as well), > because we have a dummy fail function in the header if > CONFIG_HAVE_KVM_MSI is not defined. May be then remove that fail function too? Too many #ifdef's are not good... Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/18/2015 04:03 PM, Pavel Fedin wrote: > Hello! > >> But that fails compilation on ARM (which uses this file as well), >> because we have a dummy fail function in the header if >> CONFIG_HAVE_KVM_MSI is not defined. > > May be then remove that fail function too? Too many #ifdef's are not good... Yes, that seems to work - now. I think I had more code in there before that prevented exposure without #ifdef guarding. Cheers, Andre. > > Kind regards, > Pavel Fedin > Expert Engineer > Samsung Electronics Research center Russia > > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt index 891d64a..d20fd94 100644 --- a/Documentation/virtual/kvm/api.txt +++ b/Documentation/virtual/kvm/api.txt @@ -2108,7 +2108,7 @@ after pausing the vcpu, but before it is resumed. 4.71 KVM_SIGNAL_MSI Capability: KVM_CAP_SIGNAL_MSI -Architectures: x86 +Architectures: x86 arm64 Type: vm ioctl Parameters: struct kvm_msi (in) Returns: >0 on delivery, 0 if guest blocked the MSI, and -1 on error diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig index 5105e29..6c432c0 100644 --- a/arch/arm64/kvm/Kconfig +++ b/arch/arm64/kvm/Kconfig @@ -30,6 +30,7 @@ config KVM select SRCU select HAVE_KVM_EVENTFD select HAVE_KVM_IRQFD + select HAVE_KVM_MSI ---help--- Support hosting virtualized guest machines. diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h index 6bb138d..8f1be6a 100644 --- a/include/kvm/arm_vgic.h +++ b/include/kvm/arm_vgic.h @@ -162,6 +162,7 @@ struct vgic_io_device { struct vgic_its { bool enabled; + struct vgic_io_device iodev; spinlock_t lock; u64 cbaser; int creadr; @@ -365,4 +366,13 @@ static inline int vgic_v3_probe(struct device_node *vgic_node, } #endif +#ifdef CONFIG_HAVE_KVM_MSI +int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi); +#else +static inline int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) +{ + return -ENODEV; +} +#endif + #endif diff --git a/virt/kvm/arm/its-emul.c b/virt/kvm/arm/its-emul.c index 35e886c..864de19 100644 --- a/virt/kvm/arm/its-emul.c +++ b/virt/kvm/arm/its-emul.c @@ -964,6 +964,7 @@ int vits_init(struct kvm *kvm) { struct vgic_dist *dist = &kvm->arch.vgic; struct vgic_its *its = &dist->its; + int ret; if (IS_VGIC_ADDR_UNDEF(dist->vgic_its_base)) return -ENXIO; @@ -977,9 +978,15 @@ int vits_init(struct kvm *kvm) INIT_LIST_HEAD(&its->device_list); INIT_LIST_HEAD(&its->collection_list); + ret = vgic_register_kvm_io_dev(kvm, dist->vgic_its_base, + KVM_VGIC_V3_ITS_SIZE, vgicv3_its_ranges, + -1, &its->iodev); + if (ret) + return ret; + its->enabled = false; - return -ENXIO; + return 0; } void vits_destroy(struct kvm *kvm) diff --git a/virt/kvm/arm/vgic-v3-emul.c b/virt/kvm/arm/vgic-v3-emul.c index 4513551..71d0bcf 100644 --- a/virt/kvm/arm/vgic-v3-emul.c +++ b/virt/kvm/arm/vgic-v3-emul.c @@ -89,10 +89,11 @@ static bool handle_mmio_ctlr(struct kvm_vcpu *vcpu, /* * As this implementation does not provide compatibility * with GICv2 (ARE==1), we report zero CPUs in bits [5..7]. - * Also LPIs and MBIs are not supported, so we set the respective bits to 0. - * Also we report at most 2**10=1024 interrupt IDs (to match 1024 SPIs). + * Also we report at most 2**10=1024 interrupt IDs (to match 1024 SPIs) + * and provide 16 bits worth of LPI number space (to give 8192 LPIs). */ -#define INTERRUPT_ID_BITS 10 +#define INTERRUPT_ID_BITS_SPIS 10 +#define INTERRUPT_ID_BITS_ITS 16 static bool handle_mmio_typer(struct kvm_vcpu *vcpu, struct kvm_exit_mmio *mmio, phys_addr_t offset) { @@ -100,7 +101,12 @@ static bool handle_mmio_typer(struct kvm_vcpu *vcpu, reg = (min(vcpu->kvm->arch.vgic.nr_irqs, 1024) >> 5) - 1; - reg |= (INTERRUPT_ID_BITS - 1) << 19; + if (vgic_has_its(vcpu->kvm)) { + reg |= GICD_TYPER_LPIS; + reg |= (INTERRUPT_ID_BITS_ITS - 1) << 19; + } else { + reg |= (INTERRUPT_ID_BITS_SPIS - 1) << 19; + } vgic_reg_access(mmio, ®, offset, ACCESS_READ_VALUE | ACCESS_WRITE_IGNORED); @@ -519,7 +525,9 @@ static bool handle_mmio_ctlr_redist(struct kvm_vcpu *vcpu, vgic_reg_access(mmio, ®, offset, ACCESS_READ_VALUE | ACCESS_WRITE_VALUE); if (!dist->lpis_enabled && (reg & GICR_CTLR_ENABLE_LPIS)) { - /* Eventually do something */ + dist->lpis_enabled = true; + vgic_enable_lpis(vcpu); + return true; } return false; } @@ -546,6 +554,8 @@ static bool handle_mmio_typer_redist(struct kvm_vcpu *vcpu, reg = redist_vcpu->vcpu_id << 8; if (target_vcpu_id == atomic_read(&vcpu->kvm->online_vcpus) - 1) reg |= GICR_TYPER_LAST; + if (vgic_has_its(vcpu->kvm)) + reg |= GICR_TYPER_PLPIS; vgic_reg_access(mmio, ®, offset, ACCESS_READ_VALUE | ACCESS_WRITE_IGNORED); return false; diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index 9f7b05f..09b1f46 100644 --- a/virt/kvm/arm/vgic.c +++ b/virt/kvm/arm/vgic.c @@ -2254,3 +2254,13 @@ int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e, { return 0; } + +#ifdef CONFIG_HAVE_KVM_MSI +int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) +{ + if (kvm->arch.vgic.vm_ops.inject_msi) + return kvm->arch.vgic.vm_ops.inject_msi(kvm, msi); + else + return -ENODEV; +} +#endif
If userspace has provided a base address for the ITS register frame, we enable the bits that advertise LPIs in the GICv3. When the guest has enabled LPIs and the ITS, we enable the emulation part by initializing the ITS data structures and trapping on ITS register frame accesses by the guest. Also we enable the KVM_SIGNAL_MSI feature to allow userland to inject MSIs into the guest. Not having enabled the ITS emulation will lead to a -ENODEV when trying to inject a MSI. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- Documentation/virtual/kvm/api.txt | 2 +- arch/arm64/kvm/Kconfig | 1 + include/kvm/arm_vgic.h | 10 ++++++++++ virt/kvm/arm/its-emul.c | 9 ++++++++- virt/kvm/arm/vgic-v3-emul.c | 20 +++++++++++++++----- virt/kvm/arm/vgic.c | 10 ++++++++++ 6 files changed, 45 insertions(+), 7 deletions(-)