From patchwork Mon Feb 1 19:03:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Feiner X-Patchwork-Id: 8182931 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CCEBB9F38B for ; Mon, 1 Feb 2016 19:04:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 915332027D for ; Mon, 1 Feb 2016 19:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD0882028D for ; Mon, 1 Feb 2016 19:04:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbcBATD6 (ORCPT ); Mon, 1 Feb 2016 14:03:58 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35716 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591AbcBATD5 (ORCPT ); Mon, 1 Feb 2016 14:03:57 -0500 Received: by mail-pf0-f179.google.com with SMTP id 65so88397298pfd.2 for ; Mon, 01 Feb 2016 11:03:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=j/EZ54HkgpUusuWmZ+IUNgq6zutZAiXguXmzgLYz/NY=; b=oT7kcU+/qdTRn/ZGwkdAzCDS2sP+GErL49NYsxxIqtu7/G3/CM63dBzsqSz9FkcLfk debpOGxI7GE3PCAokWQjEbU/qQEPppK6GvxgoOKkv6hhULqPYDvE3LQwbxBcEokCKyUX iss98ReT6CrzBsk9UrUrJia8tECoeINiZbOWFcqcdd/ayXnhodBLo39p7iZZi1NUGFQx DPb3/0jxIxdkgqqEDNoeQNjfCQE4XH00dd09NbYyTP/jys6KUCmG8xd/d/xlUXLX2Qjx zZvtFCmFmg2nT6Agdejd7EGsCNFuaXimc5Vdc2vQrh4tr9SMe4K1bTJi2PfumxGgHIv1 YDVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=j/EZ54HkgpUusuWmZ+IUNgq6zutZAiXguXmzgLYz/NY=; b=GsqDCQlkCZZer0sfo0fakLGhf8Fi4JmP5yD2FNw+L3Mkcl5gzgJddQvmtNBABmawVv QZxEjo6Y90yy24mIe7obNq0XdIe0hESXKwxk4zh6HvXwadgxuzk+dWlBo4Pwh3l9mJuc jCbpsXW3YAf1pEUzIQfT34w6cV3S2XgEjwmZjek7qOP4rHpHYNyrtPKyKuZgEPPh1Qt8 TWCfCPVZn2k4iP/E93iw6BjE7ToADLqkYfRzbVTHQ3+TyM5Cgtk/vuyWJvjT6MSAwub2 OhUCBDcHNpkWGCkfFRifvKQ7fTJsBWu31WObtMQQisL1bRvaFMCAoOK4UD/sJFDWKZjd C8Yw== X-Gm-Message-State: AG10YOTsc0G1YPB5UpZyB6ARhWEnBJJBesapA25KLQAvzKUPbAPyaIIbSFOlGaYS9Bc0ylxC X-Received: by 10.98.65.91 with SMTP id o88mr40330776pfa.114.1454353436737; Mon, 01 Feb 2016 11:03:56 -0800 (PST) Received: from localhost ([2620:0:1009:3:4927:52df:131c:2eab]) by smtp.gmail.com with ESMTPSA id th10sm45048223pab.3.2016.02.01.11.03.55 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 01 Feb 2016 11:03:56 -0800 (PST) From: Peter Feiner To: kvm@vger.kernel.org Cc: pfeiner@google.com Subject: [kvm-unit-tests PATCH] x86/s3.c: exit with status 0, not *0 Date: Mon, 1 Feb 2016 11:03:51 -0800 Message-Id: <1454353431-13618-1-git-send-email-pfeiner@google.com> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Typo lead to confusing code. The s3 test was writing the contents of address 0 to the output port, not explicitly the number zero! Signed-off-by: Peter Feiner --- x86/s3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x86/s3.c b/x86/s3.c index 8bf71da..c7d78c1 100644 --- a/x86/s3.c +++ b/x86/s3.c @@ -73,7 +73,7 @@ asm ( ".global resume_end\n" ".code16\n" "resume_start:\n" - "mov 0x0, %eax\n" + "mov $0x0, %eax\n" "mov $0xf4, %dx\n" "out %eax, %dx\n" "1: hlt\n"