diff mbox

[kvm-unit-tests,v2] arm: fix parallel build (make -j)

Message ID 1457111087-3736-1-git-send-email-pfeiner@google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Feiner March 4, 2016, 5:04 p.m. UTC
Dependency on asm-offsets.h wasn't made explicit in the Makefiles.
Worked without -j because non-parallel make builds dependencies in
declared order.

Signed-off-by: Peter Feiner <pfeiner@google.com>
---

v2:
	* Removed unnecessary dependency from spinlock-test.o


 arm/Makefile.common | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Jones March 4, 2016, 6:34 p.m. UTC | #1
On Fri, Mar 04, 2016 at 09:04:47AM -0800, Peter Feiner wrote:
> Dependency on asm-offsets.h wasn't made explicit in the Makefiles.
> Worked without -j because non-parallel make builds dependencies in
> declared order.
> 
> Signed-off-by: Peter Feiner <pfeiner@google.com>

Reviewed-by: Andrew Jones <drjones@redhat.com>

> ---
> 
> v2:
> 	* Removed unnecessary dependency from spinlock-test.o
> 
> 
>  arm/Makefile.common | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arm/Makefile.common b/arm/Makefile.common
> index dd3a0ca..9a2d61f 100644
> --- a/arm/Makefile.common
> +++ b/arm/Makefile.common
> @@ -71,3 +71,5 @@ test_cases: $(generated_files) $(tests-common) $(tests)
>  
>  $(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
>  $(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
> +
> +$(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
> -- 
> 2.7.0.rc3.207.g0ac5344
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arm/Makefile.common b/arm/Makefile.common
index dd3a0ca..9a2d61f 100644
--- a/arm/Makefile.common
+++ b/arm/Makefile.common
@@ -71,3 +71,5 @@  test_cases: $(generated_files) $(tests-common) $(tests)
 
 $(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
 $(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
+
+$(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)