From patchwork Mon Apr 4 08:30:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Auger X-Patchwork-Id: 8738561 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EB05AC0553 for ; Mon, 4 Apr 2016 08:31:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 28B702024F for ; Mon, 4 Apr 2016 08:31:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5048B2022A for ; Mon, 4 Apr 2016 08:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932223AbcDDIah (ORCPT ); Mon, 4 Apr 2016 04:30:37 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:32868 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932141AbcDDIae (ORCPT ); Mon, 4 Apr 2016 04:30:34 -0400 Received: by mail-lf0-f54.google.com with SMTP id p188so131016687lfd.0 for ; Mon, 04 Apr 2016 01:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0TXWtQfsMaK3LS/pF5H98JebeiPocEJWsdgpaoOs7GQ=; b=WMwr2c0eS7HDBCeogXMe10taS41OffGqc5i6TqaRalFx8jTX6CQDUEydyyRkPqWtAI apoMRhY51x8nhwlVczIVvelYXkVYPtSwTa3hqCsPlBjxsz9wi4i40dRFOCRzqJqAvGgK NNDh3CGnET7iPOB7PUlf7IgquAr5np5DV1rhk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0TXWtQfsMaK3LS/pF5H98JebeiPocEJWsdgpaoOs7GQ=; b=UnlmwnBaCp/96vU9iUMxJRKjUKgQ81z7WZWlYX9mw0P+i4cvCmM5RcW2Atjg7A88OB wX6NcVw4+CvfkGyARI6/kalTMLIy2ZXbFq/OXQfB63Sdw42CHbfrhgfzxQ9/ok55r8nh Bb92J5lCpX+mKRN/MHyMCgIOlNoRM16izemxh2sJXZMT5R29M5M3H9GfVUztCO6liHIe 6eRssLlGW48tzBeaoMsLL5dqdKn6Ufv1Iq5g7yUDycrTpsdi2D2WuhY8iWoTb68iLwl8 ILSmQ4L5wu3D/eosl7DTH+4dlZjhoJjLr1oo6Ow0hsT5h2ddrKMkHZlUsv0QhHtM/f/u zH8Q== X-Gm-Message-State: AD7BkJIZdXDxiAn+ukOXzkd4mQY1CFkF3TeVrpFeHks1NvONYIvfjUQ8sdTO/YY7svYwOtmu X-Received: by 10.194.87.103 with SMTP id w7mr4786883wjz.13.1459758632478; Mon, 04 Apr 2016 01:30:32 -0700 (PDT) Received: from new-host-2.home (LMontsouris-657-1-37-90.w80-11.abo.wanadoo.fr. [80.11.198.90]) by smtp.gmail.com with ESMTPSA id j71sm1178257wmj.21.2016.04.04.01.30.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Apr 2016 01:30:30 -0700 (PDT) From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, christoffer.dall@linaro.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Cc: suravee.suthikulpanit@amd.com, patches@linaro.org, linux-kernel@vger.kernel.org, Manish.Jaggi@caviumnetworks.com, Bharat.Bhushan@freescale.com, pranav.sawargaonkar@gmail.com, p.fedin@samsung.com, iommu@lists.linux-foundation.org, Jean-Philippe.Brucker@arm.com, julien.grall@arm.com Subject: [PATCH v6 4/5] iommu/arm-smmu: do not advertise IOMMU_CAP_INTR_REMAP Date: Mon, 4 Apr 2016 08:30:10 +0000 Message-Id: <1459758611-2972-5-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459758611-2972-1-git-send-email-eric.auger@linaro.org> References: <1459758611-2972-1-git-send-email-eric.auger@linaro.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Do not advertise IOMMU_CAP_INTR_REMAP for arm-smmu. Indeed the irq_remapping capability is abstracted on irqchip side for ARM as opposed to Intel IOMMU featuring IRQ remapping HW. So to check IRQ remapping capability, the msi domain needs to be checked instead. This commit needs to be applied after "vfio/type1: also check IRQ remapping capability at msi domain" else the legacy interrupt assignment gets broken with arm-smmu. Signed-off-by: Eric Auger --- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 6562752..83d5200 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -1304,7 +1304,7 @@ static bool arm_smmu_capable(enum iommu_cap cap) */ return true; case IOMMU_CAP_INTR_REMAP: - return true; /* MSIs are just memory writes */ + return false; /* interrupt translation handled at MSI controller level */ case IOMMU_CAP_NOEXEC: return true; default: