| Message ID | 1468316323-23835-1-git-send-email-shuo.a.liu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/07/2016 11:38, Liu Shuo wrote: > The failure of create debugfs of VM will return directly without release > the anon file. It will leak memory and file descriptors, even through > be not serious. > > Signed-off-by: Liu Shuo <shuo.a.liu@intel.com> > --- > virt/kvm/kvm_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 48bd520..8322154 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -49,6 +49,7 @@ > #include <linux/slab.h> > #include <linux/sort.h> > #include <linux/bsearch.h> > +#include <linux/syscalls.h> > > #include <asm/processor.h> > #include <asm/io.h> > @@ -3067,6 +3068,7 @@ static int kvm_dev_ioctl_create_vm(unsigned long type) > > if (kvm_create_vm_debugfs(kvm, r) < 0) { > kvm_put_kvm(kvm); > + sys_close(r); > return -ENOMEM; > } > > Thanks, applied to kvm/master. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 48bd520..8322154 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -49,6 +49,7 @@ #include <linux/slab.h> #include <linux/sort.h> #include <linux/bsearch.h> +#include <linux/syscalls.h> #include <asm/processor.h> #include <asm/io.h> @@ -3067,6 +3068,7 @@ static int kvm_dev_ioctl_create_vm(unsigned long type) if (kvm_create_vm_debugfs(kvm, r) < 0) { kvm_put_kvm(kvm); + sys_close(r); return -ENOMEM; }
The failure of create debugfs of VM will return directly without release the anon file. It will leak memory and file descriptors, even through be not serious. Signed-off-by: Liu Shuo <shuo.a.liu@intel.com> --- virt/kvm/kvm_main.c | 2 ++ 1 file changed, 2 insertions(+)