| Message ID | 1469053536-11130-4-git-send-email-bsd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 21/07/2016 00:25, Bandan Das wrote: > That parameter isn't used in the function, > it's probably a historical artifact. Same for spte_clear_dirty and spte_set_dirty, please. Paolo > Signed-off-by: Bandan Das <bsd@redhat.com> > --- > arch/x86/kvm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index def97b3..aaecd10 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep) > * > * Return true if tlb need be flushed. > */ > -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect) > +static bool spte_write_protect(u64 *sptep, bool pt_protect) > { > u64 spte = *sptep; > > @@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm, > bool flush = false; > > for_each_rmap_spte(rmap_head, &iter, sptep) > - flush |= spte_write_protect(kvm, sptep, pt_protect); > + flush |= spte_write_protect(sptep, pt_protect); > > return flush; > } > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Paolo Bonzini <pbonzini@redhat.com> writes: > On 21/07/2016 00:25, Bandan Das wrote: >> That parameter isn't used in the function, >> it's probably a historical artifact. > > Same for spte_clear_dirty and spte_set_dirty, please. Sure! I will fix this in a follow-up. Bandan > Paolo > >> Signed-off-by: Bandan Das <bsd@redhat.com> >> --- >> arch/x86/kvm/mmu.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c >> index def97b3..aaecd10 100644 >> --- a/arch/x86/kvm/mmu.c >> +++ b/arch/x86/kvm/mmu.c >> @@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep) >> * >> * Return true if tlb need be flushed. >> */ >> -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect) >> +static bool spte_write_protect(u64 *sptep, bool pt_protect) >> { >> u64 spte = *sptep; >> >> @@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm, >> bool flush = false; >> >> for_each_rmap_spte(rmap_head, &iter, sptep) >> - flush |= spte_write_protect(kvm, sptep, pt_protect); >> + flush |= spte_write_protect(sptep, pt_protect); >> >> return flush; >> } >> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index def97b3..aaecd10 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep) * * Return true if tlb need be flushed. */ -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect) +static bool spte_write_protect(u64 *sptep, bool pt_protect) { u64 spte = *sptep; @@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm, bool flush = false; for_each_rmap_spte(rmap_head, &iter, sptep) - flush |= spte_write_protect(kvm, sptep, pt_protect); + flush |= spte_write_protect(sptep, pt_protect); return flush; }
That parameter isn't used in the function, it's probably a historical artifact. Signed-off-by: Bandan Das <bsd@redhat.com> --- arch/x86/kvm/mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)