From patchwork Fri Aug 12 06:54:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Guangrong X-Patchwork-Id: 9276511 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6E4F060CDC for ; Fri, 12 Aug 2016 07:09:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D146288CB for ; Fri, 12 Aug 2016 07:09:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 51F4F288CD; Fri, 12 Aug 2016 07:09:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FE6F288CC for ; Fri, 12 Aug 2016 07:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751902AbcHLHIz (ORCPT ); Fri, 12 Aug 2016 03:08:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:45827 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbcHLHIu (ORCPT ); Fri, 12 Aug 2016 03:08:50 -0400 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 12 Aug 2016 00:07:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,509,1464678000"; d="scan'208";a="154662669" Received: from xiaoreal1.sh.intel.com (HELO xiaoreal1.sh.intel.com.sh.intel.com) ([10.239.48.133]) by fmsmga004.fm.intel.com with ESMTP; 12 Aug 2016 00:07:23 -0700 From: Xiao Guangrong To: pbonzini@redhat.com, imammedo@redhat.com Cc: gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, Xiao Guangrong Subject: [PATCH v2 7/8] pc: acpi: memhp: nvdimm hotplug support Date: Fri, 12 Aug 2016 14:54:09 +0800 Message-Id: <1470984850-66891-8-git-send-email-guangrong.xiao@linux.intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It notifies the nvdimm root device if there is a nvdimm device plugged/unplugged A new bit is used to indicates it is a nvdimm device Signed-off-by: Xiao Guangrong --- docs/specs/acpi_mem_hotplug.txt | 4 +++- hw/acpi/memory_hotplug.c | 5 ----- hw/i386/acpi-build.c | 26 ++++++++++++++++++++++---- hw/mem/nvdimm.c | 4 ---- include/hw/acpi/pc-hotplug.h | 1 + 5 files changed, 26 insertions(+), 14 deletions(-) diff --git a/docs/specs/acpi_mem_hotplug.txt b/docs/specs/acpi_mem_hotplug.txt index 3df3620..cd9e233 100644 --- a/docs/specs/acpi_mem_hotplug.txt +++ b/docs/specs/acpi_mem_hotplug.txt @@ -21,7 +21,9 @@ Memory hot-plug interface (IO port 0xa00-0xa17, 1-4 byte access): It's valid only when bit 1 is set. 2: Device remove event, used to distinguish device for which no device eject request to OSPM was issued. - 3-7: reserved and should be ignored by OSPM + 3: reserved and should be ignored by OSPM + 4: Device is a NVDIMM device. + 5-7: reserved and should be ignored by OSPM [0x15-0x17] reserved write access: diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c index 73fa62d..d1c2e92 100644 --- a/hw/acpi/memory_hotplug.c +++ b/hw/acpi/memory_hotplug.c @@ -239,11 +239,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplug_dev, MemHotplugState *mem_st, DeviceState *dev, Error **errp) { MemStatus *mdev; - DeviceClass *dc = DEVICE_GET_CLASS(dev); - - if (!dc->hotpluggable) { - return; - } mdev = acpi_memory_slot_status(mem_st, dev, errp); if (!mdev) { diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b1d0ced..02cfc4d 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1008,9 +1008,10 @@ static Aml *build_crs(PCIHostState *host, CrsRangeSet *range_set) return crs; } -static void build_memory_devices(Aml *sb_scope, int nr_mem, - uint16_t io_base, uint16_t io_len) +static void build_memory_devices(Aml *sb_scope, int nr_mem, uint16_t io_base, + uint16_t io_len, bool enable_nvdimm) { + #define BASEPATH "\\_SB.PCI0." MEMORY_HOTPLUG_DEVICE "." int i; Aml *scope; Aml *crs; @@ -1065,6 +1066,12 @@ static void build_memory_devices(Aml *sb_scope, int nr_mem, aml_append(field, /* initiates device eject, write only */ aml_named_field(MEMORY_SLOT_EJECT, 1)); + + if (enable_nvdimm) { + aml_append(field, + /* initiates nvdimm device, read only */ + aml_named_field(MEMORY_SLOT_NVDIMM, 1)); + } aml_append(scope, field); field = aml_field(MEMORY_HOTPLUG_IO_REGION, AML_DWORD_ACC, @@ -1079,7 +1086,6 @@ static void build_memory_devices(Aml *sb_scope, int nr_mem, aml_append(sb_scope, scope); for (i = 0; i < nr_mem; i++) { - #define BASEPATH "\\_SB.PCI0." MEMORY_HOTPLUG_DEVICE "." const char *s; dev = aml_device("MP%02X", i); @@ -1124,6 +1130,17 @@ static void build_memory_devices(Aml *sb_scope, int nr_mem, method = aml_method(MEMORY_SLOT_NOTIFY_METHOD, 2, AML_NOTSERIALIZED); for (i = 0; i < nr_mem; i++) { ifctx = aml_if(aml_equal(aml_arg(0), aml_int(i))); + + if (enable_nvdimm) { + Aml *ifnvdimm; + + ifnvdimm = aml_if(aml_equal(aml_name(BASEPATH MEMORY_SLOT_NVDIMM), + aml_int(1))); + aml_append(ifnvdimm, aml_notify(aml_name("\\_SB.NVDR"), + aml_int(0x80))); + aml_append(ifctx, ifnvdimm); + } + aml_append(ifctx, aml_notify(aml_name("MP%.02X", i), aml_arg(1)) ); @@ -2285,7 +2302,8 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, sb_scope = aml_scope("\\_SB"); { build_memory_devices(sb_scope, nr_mem, pm->mem_hp_io_base, - pm->mem_hp_io_len); + pm->mem_hp_io_len, + pcms->acpi_nvdimm_state.is_enabled); { Object *pci_host; diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 5bc81fe..af32508 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/nvdimm.c @@ -155,13 +155,9 @@ static void nvdimm_prepare_unplug(DeviceState *dev) static void nvdimm_class_init(ObjectClass *oc, void *data) { - DeviceClass *dc = DEVICE_CLASS(oc); PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc); NVDIMMClass *nvc = NVDIMM_CLASS(oc); - /* nvdimm hotplug has not been supported yet. */ - dc->hotpluggable = false; - ddc->realize = nvdimm_realize; ddc->get_memory_region = nvdimm_get_memory_region; ddc->get_vmstate_memory_region = nvdimm_get_vmstate_memory_region; diff --git a/include/hw/acpi/pc-hotplug.h b/include/hw/acpi/pc-hotplug.h index 6a8d268..a14977d 100644 --- a/include/hw/acpi/pc-hotplug.h +++ b/include/hw/acpi/pc-hotplug.h @@ -43,6 +43,7 @@ #define MEMORY_SLOT_INSERT_EVENT "MINS" #define MEMORY_SLOT_REMOVE_EVENT "MRMV" #define MEMORY_SLOT_EJECT "MEJ" +#define MEMORY_SLOT_NVDIMM "NVDM" #define MEMORY_SLOT_SLECTOR "MSEL" #define MEMORY_SLOT_OST_EVENT "MOEV" #define MEMORY_SLOT_OST_STATUS "MOSC"