| Message ID | 1477939540-28370-1-git-send-email-drjones@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> > --- > x86/kvmclock_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/kvmclock_test.c b/x86/kvmclock_test.c > index f729dbecf38e..cbdcaf6961fe 100644 > --- a/x86/kvmclock_test.c > +++ b/x86/kvmclock_test.c > @@ -33,7 +33,7 @@ static void wallclock_test(void *data) > ksec = ts.tv_sec; > > offset = ksec - sec; > - printf("Raw nanoseconds value from kvmclock: %ld (cpu %d)\n", kvm_clock_read(), smp_id()); > + printf("Raw nanoseconds value from kvmclock: %" PRId64 " (cpu %d)\n", kvm_clock_read(), smp_id()); Looks like the PRId64 here should be PRIu64, as the cycle_t from x86/kvmclock.h uses u64 in x86/kvmclock.h: 14 typedef u64 cycle_t; 39 cycle_t kvm_clock_read(); > printf("Seconds get from kvmclock: %ld (cpu %d, offset: %ld)\n", ksec, smp_id(), offset); > > if (offset > threshold || offset < -threshold) { > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 01, 2016 at 07:37:09PM +0800, Po-Hsu Lin wrote: > > Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> > > --- > > x86/kvmclock_test.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/x86/kvmclock_test.c b/x86/kvmclock_test.c > > index f729dbecf38e..cbdcaf6961fe 100644 > > --- a/x86/kvmclock_test.c > > +++ b/x86/kvmclock_test.c > > @@ -33,7 +33,7 @@ static void wallclock_test(void *data) > > ksec = ts.tv_sec; > > > > offset = ksec - sec; > > - printf("Raw nanoseconds value from kvmclock: %ld (cpu %d)\n", kvm_clock_read(), smp_id()); > > + printf("Raw nanoseconds value from kvmclock: %" PRId64 " (cpu %d)\n", kvm_clock_read(), smp_id()); > > Looks like the PRId64 here should be PRIu64, as the cycle_t from x86/kvmclock.h uses u64 > > in x86/kvmclock.h: > > 14 typedef u64 cycle_t; > 39 cycle_t kvm_clock_read(); Will fix. Thanks, drew > > > printf("Seconds get from kvmclock: %ld (cpu %d, offset: %ld)\n", ksec, smp_id(), offset); > > > > if (offset > threshold || offset < -threshold) { > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 31/10/2016 19:45, Andrew Jones wrote: > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > x86/kvmclock_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/kvmclock_test.c b/x86/kvmclock_test.c > index f729dbecf38e..cbdcaf6961fe 100644 > --- a/x86/kvmclock_test.c > +++ b/x86/kvmclock_test.c > @@ -33,7 +33,7 @@ static void wallclock_test(void *data) > ksec = ts.tv_sec; > > offset = ksec - sec; > - printf("Raw nanoseconds value from kvmclock: %ld (cpu %d)\n", kvm_clock_read(), smp_id()); > + printf("Raw nanoseconds value from kvmclock: %" PRId64 " (cpu %d)\n", kvm_clock_read(), smp_id()); > printf("Seconds get from kvmclock: %ld (cpu %d, offset: %ld)\n", ksec, smp_id(), offset); > > if (offset > threshold || offset < -threshold) { > Committed, thanks (with PRIu64). Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/x86/kvmclock_test.c b/x86/kvmclock_test.c index f729dbecf38e..cbdcaf6961fe 100644 --- a/x86/kvmclock_test.c +++ b/x86/kvmclock_test.c @@ -33,7 +33,7 @@ static void wallclock_test(void *data) ksec = ts.tv_sec; offset = ksec - sec; - printf("Raw nanoseconds value from kvmclock: %ld (cpu %d)\n", kvm_clock_read(), smp_id()); + printf("Raw nanoseconds value from kvmclock: %" PRId64 " (cpu %d)\n", kvm_clock_read(), smp_id()); printf("Seconds get from kvmclock: %ld (cpu %d, offset: %ld)\n", ksec, smp_id(), offset); if (offset > threshold || offset < -threshold) {
Signed-off-by: Andrew Jones <drjones@redhat.com> --- x86/kvmclock_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)