diff mbox

[kvm-unit-tests,v5,01/14] pci: fix missing extern for pci_testdev()

Message ID 1479248709-10281-2-git-send-email-peterx@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Xu Nov. 15, 2016, 10:24 p.m. UTC
Suggested-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 lib/pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Jones Nov. 16, 2016, 9:26 a.m. UTC | #1
On Tue, Nov 15, 2016 at 05:24:56PM -0500, Peter Xu wrote:
> Suggested-by: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  lib/pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/pci.h b/lib/pci.h
> index 30f5381..86d6b42 100644
> --- a/lib/pci.h
> +++ b/lib/pci.h
> @@ -43,7 +43,7 @@ extern bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
>  extern void pci_bar_print(pcidevaddr_t dev, int bar_num);
>  extern void pci_dev_print_id(pcidevaddr_t dev);
>  
> -int pci_testdev(void);
> +extern int pci_testdev(void);
>  
>  /*
>   * pci-testdev is a driver for the pci-testdev qemu pci device. The
> -- 
> 2.7.4
>

I would have allowed this change to be slipped in with the addition
of new declarations, i.e. no need for its own patch, but anyway

Reviewed-by: Andrew Jones <drjones@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/lib/pci.h b/lib/pci.h
index 30f5381..86d6b42 100644
--- a/lib/pci.h
+++ b/lib/pci.h
@@ -43,7 +43,7 @@  extern bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
 extern void pci_bar_print(pcidevaddr_t dev, int bar_num);
 extern void pci_dev_print_id(pcidevaddr_t dev);
 
-int pci_testdev(void);
+extern int pci_testdev(void);
 
 /*
  * pci-testdev is a driver for the pci-testdev qemu pci device. The