From patchwork Mon Mar 20 12:25:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wanpeng Li X-Patchwork-Id: 9633939 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 87995601E9 for ; Mon, 20 Mar 2017 12:27:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83F4D1FF13 for ; Mon, 20 Mar 2017 12:27:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 77AD5200F5; Mon, 20 Mar 2017 12:27:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 340BE1FF13 for ; Mon, 20 Mar 2017 12:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754216AbdCTM0Z (ORCPT ); Mon, 20 Mar 2017 08:26:25 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36863 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753860AbdCTMZ4 (ORCPT ); Mon, 20 Mar 2017 08:25:56 -0400 Received: by mail-pg0-f66.google.com with SMTP id 81so11664561pgh.3; Mon, 20 Mar 2017 05:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QLhIC/Y0lCT8B8ob3sqOhKtWNbSHuawyTteslfQsNtM=; b=nugIGg2uFchOWuiDfSL12XI5IfI8QPjyxRMQC8oEBPhHY58FCQv8OndDq4vTrIvx3r DoWfGHs+oL7DABvwNDM5ms0d+jXTxjdz6F7sh0G8qn/b+FbVWlLvtienQfjVixG+c1SD NNwhuyb61MDE2MyLXCK6XTd9wQdQ7DhoxsbniV3Kcrk28htNPsbpHOpRNPx6uYhg8RKR dLXAGCashJ3OLP7fbFN1P+joN+hhVGuJTYGCpub3OIJh1t0ywXtEac9yfdkkH1FeUZ2G vBGFnbsI/2lvYWw8QjjCrNnTT7vZ9EfCOeg3RiKfCpTHV6T8e18TUGiWKFcIiBhgwzEb E/xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QLhIC/Y0lCT8B8ob3sqOhKtWNbSHuawyTteslfQsNtM=; b=tObLNZyMYIoX5X1yEAm6Xj7RVPF/w0b7VxUPBQXjVJAKWVg6JZ1wCZgbKFN0QKUesk APk0quPouz+KstGGK0hcsDsgiSTQdYsqAzfk6Gq8n78ZkdC6g34K3ZpdemuvS0VyOoNe cxEJ8NmWPF7jKy1V/1TauMuXep3UycfQKv3dQwXa7TZEIVXQ52oAQzxJVQnotPHqhKYO Q8Gz+evcnwFAq7AK2XqV3HJLmETqAaYv2hsOo9UAZw9H2s0JVHuLTyvnb/q6ishyGGWF /dIm82gn/7Rb5Nr0DAGUy9bChUYVRGc6yTvVNdlr3eEV60fRD/mhq2lyY6NWHvZcRkv5 Go/A== X-Gm-Message-State: AFeK/H06+5W7Lly0Vw6Ig3w66qXOApU0RDLRuNZ1DcPTLqQ2iSC4E5qRVAOs5v2b/+lKpw== X-Received: by 10.99.153.1 with SMTP id d1mr31292504pge.44.1490012754977; Mon, 20 Mar 2017 05:25:54 -0700 (PDT) Received: from localhost ([203.205.141.123]) by smtp.gmail.com with ESMTPSA id t133sm33371985pgc.24.2017.03.20.05.25.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 05:25:53 -0700 (PDT) From: Wanpeng Li X-Google-Original-From: Wanpeng Li To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Wanpeng Li Subject: [PATCH] KVM: nVMX: Fix L2 guest crash when VPID is disabled on L0 Date: Mon, 20 Mar 2017 05:25:45 -0700 Message-Id: <1490012745-10122-1-git-send-email-wanpeng.li@hotmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wanpeng Li L2 guest crash during boot if VPID is enabled on L1 and disabled on L0. This also can be catched by kvm-unit-tests/vmx.flat when VPID is disabled on L0. KVM: entry failed, hardware error 0x7 EAX=00000000 EBX=00000000 ECX=00000000 EDX=000306c3 ESI=00000000 EDI=00000000 EBP=00000000 ESP=00000000 EIP=0000fff0 EFL=00000002 [-------] CPL=0 II=0 A20=1 SMM=0 HLT=0 ES =0000 00000000 0000ffff 00009300 CS =f000 ffff0000 0000ffff 00009b00 SS =0000 00000000 0000ffff 00009300 DS =0000 00000000 0000ffff 00009300 FS =0000 00000000 0000ffff 00009300 GS =0000 00000000 0000ffff 00009300 LDT=0000 00000000 0000ffff 00008200 TR =0000 00000000 0000ffff 00008b00 GDT= 00000000 0000ffff IDT= 00000000 0000ffff CR0=60000010 CR2=00000000 CR3=00000000 CR4=00000000 DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000 DR6=00000000ffff0ff0 DR7=0000000000000400 EFER=0000000000000000 The enable_vpid sysfs perm parameter miss the 0 prefix, so the enable_vpid is failed to be disabled though vmcs_config bit is not set. This patch fixes it by utilizing S_IRUGO which includes 0 prefix instead. Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li --- arch/x86/kvm/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 98e82ee..a7e4880 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -66,7 +66,7 @@ static const struct x86_cpu_id vmx_cpu_id[] = { MODULE_DEVICE_TABLE(x86cpu, vmx_cpu_id); static bool __read_mostly enable_vpid = 1; -module_param_named(vpid, enable_vpid, bool, 0444); +module_param_named(vpid, enable_vpid, bool, S_IRUGO); static bool __read_mostly flexpriority_enabled = 1; module_param_named(flexpriority, flexpriority_enabled, bool, S_IRUGO);