From patchwork Wed Jul 5 10:38:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 9826317 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B83E0603B5 for ; Wed, 5 Jul 2017 10:39:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AACA922AFC for ; Wed, 5 Jul 2017 10:39:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9FC3B283D0; Wed, 5 Jul 2017 10:39:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61E03283CB for ; Wed, 5 Jul 2017 10:39:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452AbdGEKiu (ORCPT ); Wed, 5 Jul 2017 06:38:50 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:35354 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751755AbdGEKis (ORCPT ); Wed, 5 Jul 2017 06:38:48 -0400 Received: by mail-wr0-f194.google.com with SMTP id z45so49738530wrb.2; Wed, 05 Jul 2017 03:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=aX8LBO+5PnXdeh0ca5KkUKACnXbda7uX3SL1jM7bYuU=; b=XsZCQjt0i2LqPT1mCk4TSUDMuWX+3ebwq9qp4JwOWnyVCeW8NZnsTyRfhuGHOrr16x LJ+nMw+FEsQAQdDO00hd079TWez6XdQopTA5KNGRrd9TrcQalqp9PjaXSqVoeM/BhHBZ drFbAW7D7l/5m8aKQrxWDiC8ODkEk4bLQAndFMp84/OljB1CB/GaKTi3vkLqzIgJ6x6Y aLCROqQRSdW6j1ALrrG7hz4MuToXo5q2w6/1P6DuXQ/MJE5j3McZnlaX+jRsCUCSfZOZ ofzoxk4bzzZ5e5sQIjDTri6gs1AlkvJwfEb2aGaEitmXBem4jtHyJPpwXAe/lwDGMY22 sSZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=aX8LBO+5PnXdeh0ca5KkUKACnXbda7uX3SL1jM7bYuU=; b=aZ+Kng4JYJP6spJRjXYs2SO3KqRWBgU55wyNtRpP9jklJjpLtt9SlP2XhPU+y3XQO2 NSz73OnYdstqhX0tg90gyi3K3cFHXBJgKIJRd7jc2CHzJ/mRslCey7jldLMF2fp8s3W+ g3eJItuN9KboreUX9i+Y0/9XeM3Qng/lek2q5z1wMedGUQJNKdn8yV2eVCQ5TvP9WFmZ ykxWJgEzsBtq9p9s53Z7vIu5IsrgyTVr/hwCmAlJoVEYszZdYdvStwYzDN9Z5pAZKMap qARmZ90OGuKBa6rWwUdh6wcr0nnK5mzVlyDNlqoWrKyGUX9WHBuSYq8vXN6CprC4au0l gtfw== X-Gm-Message-State: AKS2vOwegLu+lb0KjaZ+uy1rXgakj8JMlkZ63hGJJNkj0Erg3mYt0B1a 8EzzE3iJGjW9s18YRNQ= X-Received: by 10.223.176.218 with SMTP id j26mr38809130wra.192.1499251127053; Wed, 05 Jul 2017 03:38:47 -0700 (PDT) Received: from 640k.lan (94-39-191-51.adsl-ull.clienti.tiscali.it. [94.39.191.51]) by smtp.gmail.com with ESMTPSA id k75sm14623203wmh.10.2017.07.05.03.38.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jul 2017 03:38:46 -0700 (PDT) From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: [PATCH] KVM: vmx: expose more information for KVM_INTERNAL_ERROR_DELIVERY_EV exits Date: Wed, 5 Jul 2017 12:38:44 +0200 Message-Id: <1499251124-35803-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This exit ended up being reported, but the currently exposed data does not provide much of a starting point for debugging. In the reported case, the vmexit was an EPT misconfiguration (MMIO access). Let userspace report ethe exit qualification and, if relevant, the GPA. Signed-off-by: Paolo Bonzini Reviewed-by: David Hildenbrand --- arch/x86/kvm/vmx.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 6dcc4873e435..4be80c3ac24d 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -8408,9 +8408,15 @@ static int vmx_handle_exit(struct kvm_vcpu *vcpu) exit_reason != EXIT_REASON_TASK_SWITCH)) { vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR; vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_DELIVERY_EV; - vcpu->run->internal.ndata = 2; + vcpu->run->internal.ndata = 3; vcpu->run->internal.data[0] = vectoring_info; vcpu->run->internal.data[1] = exit_reason; + vcpu->run->internal.data[2] = vcpu->arch.exit_qualification; + if (exit_reason == EXIT_REASON_EPT_MISCONFIG) { + vcpu->run->internal.ndata++; + vcpu->run->internal.data[3] = + vmcs_read64(GUEST_PHYSICAL_ADDRESS); + } return 0; }