| Message ID | 1506350729-11311-1-git-send-email-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/25/2017 04:45 PM, Thomas Huth wrote: > There is no recent user space application available anymore which still > supports this old virtio transport, so let's disable this by default. > > Signed-off-by: Thomas Huth <thuth@redhat.com> I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack. Via whom is this supposed to go in? Looking at the MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients. Regards, Halil > --- > arch/s390/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index 48af970..923bf04 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -930,7 +930,7 @@ config S390_GUEST > the KVM hypervisor. > > config S390_GUEST_OLD_TRANSPORT > - def_bool y > + def_bool n > prompt "Guest support for old s390 virtio transport (DEPRECATED)" > depends on S390_GUEST > help >
On 09/25/2017 07:54 PM, Halil Pasic wrote: > > > On 09/25/2017 04:45 PM, Thomas Huth wrote: >> There is no recent user space application available anymore which still >> supports this old virtio transport, so let's disable this by default. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> > > I don't have any objections, but there may be something I'm not aware of. > Let's see what Connie says. From my side it's ack. > > Via whom is this supposed to go in? Looking at the MAINTAINERS, I would > say Martin or Heiko but I don't see them among the recipients. FWIW as the original author of that transport Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> I can pick this up for Martins/Heikos tree if you want. > > Regards, > Halil > >> --- >> arch/s390/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig >> index 48af970..923bf04 100644 >> --- a/arch/s390/Kconfig >> +++ b/arch/s390/Kconfig >> @@ -930,7 +930,7 @@ config S390_GUEST >> the KVM hypervisor. >> >> config S390_GUEST_OLD_TRANSPORT >> - def_bool y >> + def_bool n >> prompt "Guest support for old s390 virtio transport (DEPRECATED)" >> depends on S390_GUEST >> help >>
On 25.09.2017 20:37, Christian Borntraeger wrote: > > On 09/25/2017 07:54 PM, Halil Pasic wrote: >> >> >> On 09/25/2017 04:45 PM, Thomas Huth wrote: >>> There is no recent user space application available anymore which still >>> supports this old virtio transport, so let's disable this by default. >>> >>> Signed-off-by: Thomas Huth <thuth@redhat.com> >> >> I don't have any objections, but there may be something I'm not aware of. >> Let's see what Connie says. From my side it's ack. >> >> Via whom is this supposed to go in? Looking at the MAINTAINERS, I would >> say Martin or Heiko but I don't see them among the recipients. > > FWIW as the original author of that transport > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> > > I can pick this up for Martins/Heikos tree if you want. That would be great, yes, thanks! Thomas
On 09/25/2017 04:45 PM, Thomas Huth wrote: > There is no recent user space application available anymore which still > supports this old virtio transport, so let's disable this by default. > > Signed-off-by: Thomas Huth <thuth@redhat.com> thanks applied. > --- > arch/s390/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index 48af970..923bf04 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -930,7 +930,7 @@ config S390_GUEST > the KVM hypervisor. > > config S390_GUEST_OLD_TRANSPORT > - def_bool y > + def_bool n > prompt "Guest support for old s390 virtio transport (DEPRECATED)" > depends on S390_GUEST > help >
On Mon, 25 Sep 2017 16:45:29 +0200 Thomas Huth <thuth@redhat.com> wrote: > There is no recent user space application available anymore which still > supports this old virtio transport, so let's disable this by default. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > arch/s390/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index 48af970..923bf04 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -930,7 +930,7 @@ config S390_GUEST > the KVM hypervisor. > > config S390_GUEST_OLD_TRANSPORT > - def_bool y > + def_bool n > prompt "Guest support for old s390 virtio transport (DEPRECATED)" > depends on S390_GUEST > help Acked-by: Cornelia Huck <cohuck@redhat.com>
On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: > > On 09/25/2017 07:54 PM, Halil Pasic wrote: > > > > > > On 09/25/2017 04:45 PM, Thomas Huth wrote: > >> There is no recent user space application available anymore which still > >> supports this old virtio transport, so let's disable this by default. > >> > >> Signed-off-by: Thomas Huth <thuth@redhat.com> > > > > I don't have any objections, but there may be something I'm not aware of. > > Let's see what Connie says. From my side it's ack. > > > > Via whom is this supposed to go in? Looking at the MAINTAINERS, I would > > say Martin or Heiko but I don't see them among the recipients. > > FWIW as the original author of that transport > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> > > I can pick this up for Martins/Heikos tree if you want. When will this code be removed? When the config option was initially added Conny said it should survive "probably two kernel releases or so, depending on feedback". It was merged for v4.8. Now we are five kernel releases later...
On 09/26/2017 12:40 PM, Heiko Carstens wrote: > On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: >> >> On 09/25/2017 07:54 PM, Halil Pasic wrote: >>> >>> >>> On 09/25/2017 04:45 PM, Thomas Huth wrote: >>>> There is no recent user space application available anymore which still >>>> supports this old virtio transport, so let's disable this by default. >>>> >>>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>> >>> I don't have any objections, but there may be something I'm not aware of. >>> Let's see what Connie says. From my side it's ack. >>> >>> Via whom is this supposed to go in? Looking at the MAINTAINERS, I would >>> say Martin or Heiko but I don't see them among the recipients. >> >> FWIW as the original author of that transport >> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> >> >> I can pick this up for Martins/Heikos tree if you want. > > When will this code be removed? > > When the config option was initially added Conny said it should survive > "probably two kernel releases or so, depending on feedback". > It was merged for v4.8. Now we are five kernel releases later... Lets wait for one release and then get rid of it?
On Tue, Sep 26, 2017 at 12:41:41PM +0200, Christian Borntraeger wrote: > > > On 09/26/2017 12:40 PM, Heiko Carstens wrote: > > On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: > >> > >> On 09/25/2017 07:54 PM, Halil Pasic wrote: > >>> > >>> > >>> On 09/25/2017 04:45 PM, Thomas Huth wrote: > >>>> There is no recent user space application available anymore which still > >>>> supports this old virtio transport, so let's disable this by default. > >>>> > >>>> Signed-off-by: Thomas Huth <thuth@redhat.com> > >>> > >>> I don't have any objections, but there may be something I'm not aware of. > >>> Let's see what Connie says. From my side it's ack. > >>> > >>> Via whom is this supposed to go in? Looking at the MAINTAINERS, I would > >>> say Martin or Heiko but I don't see them among the recipients. > >> > >> FWIW as the original author of that transport > >> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> > >> > >> I can pick this up for Martins/Heikos tree if you want. > > > > When will this code be removed? > > > > When the config option was initially added Conny said it should survive > > "probably two kernel releases or so, depending on feedback". > > It was merged for v4.8. Now we are five kernel releases later... > > Lets wait for one release and then get rid of it? So it's going to be removed with the next merge window. Where is the patch? ;)
On 26.09.2017 12:47, Heiko Carstens wrote: > On Tue, Sep 26, 2017 at 12:41:41PM +0200, Christian Borntraeger wrote: >> >> >> On 09/26/2017 12:40 PM, Heiko Carstens wrote: >>> On Mon, Sep 25, 2017 at 08:37:36PM +0200, Christian Borntraeger wrote: >>>> >>>> On 09/25/2017 07:54 PM, Halil Pasic wrote: >>>>> >>>>> >>>>> On 09/25/2017 04:45 PM, Thomas Huth wrote: >>>>>> There is no recent user space application available anymore which still >>>>>> supports this old virtio transport, so let's disable this by default. >>>>>> >>>>>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>>>> >>>>> I don't have any objections, but there may be something I'm not aware of. >>>>> Let's see what Connie says. From my side it's ack. >>>>> >>>>> Via whom is this supposed to go in? Looking at the MAINTAINERS, I would >>>>> say Martin or Heiko but I don't see them among the recipients. >>>> >>>> FWIW as the original author of that transport >>>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> >>>> >>>> I can pick this up for Martins/Heikos tree if you want. >>> >>> When will this code be removed? >>> >>> When the config option was initially added Conny said it should survive >>> "probably two kernel releases or so, depending on feedback". >>> It was merged for v4.8. Now we are five kernel releases later... >> >> Lets wait for one release and then get rid of it? > > So it's going to be removed with the next merge window. > Where is the patch? ;) Hmm, so far the code was always enabled by default, so in the unlikely case that somebody is still using it, they might not have noticed that this is marked as deprecated. So maybe it's better to keep the code for two more released, but disable it by default, so that people have time to realize that it is going away? ... just my 0.02 € ... but if you prefer, I can also write a patch that removes it immediately instead. Thomas
On Tue, Sep 26, 2017 at 12:57:26PM +0200, Thomas Huth wrote: > On 26.09.2017 12:47, Heiko Carstens wrote: > > So it's going to be removed with the next merge window. > > Where is the patch? ;) > > Hmm, so far the code was always enabled by default, so in the unlikely > case that somebody is still using it, they might not have noticed that > this is marked as deprecated. So maybe it's better to keep the code for > two more released, but disable it by default, so that people have time > to realize that it is going away? ... just my 0.02 € ... but if you > prefer, I can also write a patch that removes it immediately instead. Switching the default from yes to no won't prevent anybody from selecting it again. So I don't see any value in waiting even longer. Besides the original commit already printed a message to the console that the transport is deprecated. See commit 3b2fbb3f06ef ("virtio/s390: deprecate old transport").
On Tue, 26 Sep 2017 13:04:03 +0200 Heiko Carstens <heiko.carstens@de.ibm.com> wrote: > On Tue, Sep 26, 2017 at 12:57:26PM +0200, Thomas Huth wrote: > > On 26.09.2017 12:47, Heiko Carstens wrote: > > > So it's going to be removed with the next merge window. > > > Where is the patch? ;) > > > > Hmm, so far the code was always enabled by default, so in the unlikely > > case that somebody is still using it, they might not have noticed that > > this is marked as deprecated. So maybe it's better to keep the code for > > two more released, but disable it by default, so that people have time > > to realize that it is going away? ... just my 0.02 € ... but if you > > prefer, I can also write a patch that removes it immediately instead. > > Switching the default from yes to no won't prevent anybody from selecting > it again. So I don't see any value in waiting even longer. > > Besides the original commit already printed a message to the console that > the transport is deprecated. > See commit 3b2fbb3f06ef ("virtio/s390: deprecate old transport"). > Would ack a removal as well.
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index 48af970..923bf04 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default. Signed-off-by: Thomas Huth <thuth@redhat.com> --- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)