From patchwork Tue Dec 12 08:44:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Quan Xu X-Patchwork-Id: 10106499 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 591A4602B3 for ; Tue, 12 Dec 2017 08:44:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49C5D29B21 for ; Tue, 12 Dec 2017 08:44:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E96A29B26; Tue, 12 Dec 2017 08:44:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE4F529B21 for ; Tue, 12 Dec 2017 08:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752119AbdLLIoo (ORCPT ); Tue, 12 Dec 2017 03:44:44 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:37291 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbdLLIom (ORCPT ); Tue, 12 Dec 2017 03:44:42 -0500 Received: by mail-oi0-f66.google.com with SMTP id y75so13499236oie.4; Tue, 12 Dec 2017 00:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SojEw37LSZm/mun4Bj0qzKihjsmplcCvGDJMDS+AbU4=; b=kBl8a+wz1JbMEfFMNFUIEZI8uaEpUpYeVqcwTj2QS9hxiNef1elLkZ16FPjKm0J7By 6SOJe2nyTfFzXzCOUryhNdjPrUtMsCLU+GBadtzu+h496OhKur9zrwSAXvdQkpgLfP20 UbWvhuGcMeCEWERTHCVkGKe1GGyCl+XwasodJ339UCKyTLmMALaBADmBKn7AQZ+TXNHo kyDQBQFemlJdeScjNzH0AItjU6xYrkMTjE5rNsXxfe511hRzj62z5P5aAzGMIeZ667d6 YrRiPkJx6MHZbV5iD7UwUZQiEOYFNphQngIehdzINPBngUmyYlJLeOyDbnNfqSXhZtOB FQbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SojEw37LSZm/mun4Bj0qzKihjsmplcCvGDJMDS+AbU4=; b=DcbCshX8w13owfaucfINskhz0Tijlju2QAnNwxSCUTYpwe/G97a1PzckaubqwB5Jo5 10mSFZqjaFoBme5MApRumGKelZJXU59aqAsmFDo9GY9W7bTpka7f6MYAZq/R1VLqqsmv VrtwyEtffj8ELfvOX9BtE+A2qJDDr2gihkmCe/UUwTXsFnM+hvkxAt78FUD9gqpCXNKk gIhx+juPOF8kv+fkE89MW8aK3K4EkbJNES/e5IOre76GRdPZEwLC6hdSPD5zI6MQ/xdh rhHsYMTsCsPYbL2zCESnNTK3v/HAlwzdOTFLh5joZbmtbBaR6eKIyEbejP87WYoXaJIx B+fQ== X-Gm-Message-State: AKGB3mLm0puQpOGxxb91KVDQnn3KmVpZ/CeFTf6xwCz8AX3of4fBuo7r CpbUQuUjPiVBX6Xjocp++tNZ6gQY X-Google-Smtp-Source: ACJfBovbV8EkRA2jZpI8hnE6plTJlhBMEbBLXo+2069CR+FCHlachD4ZTxRxZUmiEvJADvUOSGoivA== X-Received: by 10.202.80.145 with SMTP id e139mr2522426oib.70.1513068281954; Tue, 12 Dec 2017 00:44:41 -0800 (PST) Received: from localhost.localdomain ([121.0.29.66]) by smtp.googlemail.com with ESMTPSA id h12sm7603669oti.38.2017.12.12.00.44.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Dec 2017 00:44:41 -0800 (PST) From: Quan Xu X-Google-Original-From: Quan Xu To: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, rkrcmar@redhat.com, jmattson@google.com, pbonzini@redhat.com, david@redhat.com, Quan Xu Subject: [PATCH v2] KVM: VMX: drop I/O permission bitmaps Date: Tue, 12 Dec 2017 16:44:21 +0800 Message-Id: <1513068261-2019-1-git-send-email-quan.xu0@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quan Xu Since KVM removes the only I/O port 0x80 bypass on Intel hosts, clear CPU_BASED_USE_IO_BITMAPS and set CPU_BASED_UNCOND_IO_EXITING bit. Then these I/O permission bitmaps are not used at all, so drop I/O permission bitmaps. Signed-off-by: Jim Mattson Signed-off-by: Radim Krčmář Signed-off-by: Quan Xu --- arch/x86/kvm/vmx.c | 15 +-------------- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 2fd9a8c..41aaf5e 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -943,8 +943,6 @@ static bool nested_vmx_is_page_fault_vmexit(struct vmcs12 *vmcs12, static DEFINE_PER_CPU(spinlock_t, blocked_vcpu_on_cpu_lock); enum { - VMX_IO_BITMAP_A, - VMX_IO_BITMAP_B, VMX_MSR_BITMAP_LEGACY, VMX_MSR_BITMAP_LONGMODE, VMX_MSR_BITMAP_LEGACY_X2APIC_APICV, @@ -958,8 +956,6 @@ enum { static unsigned long *vmx_bitmap[VMX_BITMAP_NR]; -#define vmx_io_bitmap_a (vmx_bitmap[VMX_IO_BITMAP_A]) -#define vmx_io_bitmap_b (vmx_bitmap[VMX_IO_BITMAP_B]) #define vmx_msr_bitmap_legacy (vmx_bitmap[VMX_MSR_BITMAP_LEGACY]) #define vmx_msr_bitmap_longmode (vmx_bitmap[VMX_MSR_BITMAP_LONGMODE]) #define vmx_msr_bitmap_legacy_x2apic_apicv (vmx_bitmap[VMX_MSR_BITMAP_LEGACY_X2APIC_APICV]) @@ -3632,7 +3628,7 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf) #endif CPU_BASED_CR3_LOAD_EXITING | CPU_BASED_CR3_STORE_EXITING | - CPU_BASED_USE_IO_BITMAPS | + CPU_BASED_UNCOND_IO_EXITING | CPU_BASED_MOV_DR_EXITING | CPU_BASED_USE_TSC_OFFSETING | CPU_BASED_INVLPG_EXITING | @@ -5445,10 +5441,6 @@ static void vmx_vcpu_setup(struct vcpu_vmx *vmx) #endif int i; - /* I/O */ - vmcs_write64(IO_BITMAP_A, __pa(vmx_io_bitmap_a)); - vmcs_write64(IO_BITMAP_B, __pa(vmx_io_bitmap_b)); - if (enable_shadow_vmcs) { vmcs_write64(VMREAD_BITMAP, __pa(vmx_vmread_bitmap)); vmcs_write64(VMWRITE_BITMAP, __pa(vmx_vmwrite_bitmap)); @@ -6751,14 +6743,9 @@ static __init int hardware_setup(void) goto out; } - vmx_io_bitmap_b = (unsigned long *)__get_free_page(GFP_KERNEL); memset(vmx_vmread_bitmap, 0xff, PAGE_SIZE); memset(vmx_vmwrite_bitmap, 0xff, PAGE_SIZE); - memset(vmx_io_bitmap_a, 0xff, PAGE_SIZE); - - memset(vmx_io_bitmap_b, 0xff, PAGE_SIZE); - memset(vmx_msr_bitmap_legacy, 0xff, PAGE_SIZE); memset(vmx_msr_bitmap_longmode, 0xff, PAGE_SIZE);