| Message ID | 1539681150-9374-1-git-send-email-peng.hao2@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] kvm:x86 :remove unnecessary recalculate_apic_map | expand |
On Tue, Oct 16, 2018 at 05:12:30PM +0800, Peng Hao wrote: >In the previous code, the variable sw_apic_disabled influences >recalculate_apic_map. But in "KVM: x86: simplify kvm_apic_map" >(commit:3b5a5ffa928a3f875b0d5dd284eeb7c322e1688a), >the access to sw_apic_disabled in recalculate_apic_map has been >deleted. s/sw_apic_disabled/apic_sw_disabled/ ? > >Signed-off-by: Peng Hao <peng.hao2@zte.com.cn> >--- > arch/x86/kvm/lapic.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c >index 70dcb55..0380e37 100644 >--- a/arch/x86/kvm/lapic.c >+++ b/arch/x86/kvm/lapic.c >@@ -246,10 +246,9 @@ static inline void apic_set_spiv(struct kvm_lapic *apic, u32 val) > > if (enabled != apic->sw_enabled) { > apic->sw_enabled = enabled; >- if (enabled) { >+ if (enabled) > static_key_slow_dec_deferred(&apic_sw_disabled); >- recalculate_apic_map(apic->vcpu->kvm); >- } else >+ else > static_key_slow_inc(&apic_sw_disabled.key); > } > } >-- >1.8.3.1
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 70dcb55..0380e37 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -246,10 +246,9 @@ static inline void apic_set_spiv(struct kvm_lapic *apic, u32 val) if (enabled != apic->sw_enabled) { apic->sw_enabled = enabled; - if (enabled) { + if (enabled) static_key_slow_dec_deferred(&apic_sw_disabled); - recalculate_apic_map(apic->vcpu->kvm); - } else + else static_key_slow_inc(&apic_sw_disabled.key); } }
In the previous code, the variable sw_apic_disabled influences recalculate_apic_map. But in "KVM: x86: simplify kvm_apic_map" (commit:3b5a5ffa928a3f875b0d5dd284eeb7c322e1688a), the access to sw_apic_disabled in recalculate_apic_map has been deleted. Signed-off-by: Peng Hao <peng.hao2@zte.com.cn> --- arch/x86/kvm/lapic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)