From patchwork Thu Aug 1 03:30:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wanpeng Li X-Patchwork-Id: 11070091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1206613A0 for ; Thu, 1 Aug 2019 03:30:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ED803283C3 for ; Thu, 1 Aug 2019 03:30:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1C6828409; Thu, 1 Aug 2019 03:30:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CCE0283B0 for ; Thu, 1 Aug 2019 03:30:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729435AbfHADad (ORCPT ); Wed, 31 Jul 2019 23:30:33 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:43331 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729266AbfHADac (ORCPT ); Wed, 31 Jul 2019 23:30:32 -0400 Received: by mail-pl1-f195.google.com with SMTP id 4so24486838pld.10; Wed, 31 Jul 2019 20:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Jyl7Q+fNfa4JowIqcItEgbQqxdMDKkuTAtedoCYt2UY=; b=eAXWVqyoPQAaeEe6yu4toJk8mRWTJbseagq1nJrw5sMhs4P6uYhFHtTyz9abUsIyoS +1C/gPQOtsY7wYSHqJh6/+ymKVJE4dU2mLklv1+z0EcvlqUsabQxa2dC/07UFd5rkjB+ NipenViZYX+QQxoq1tupXA5esLfuQbOJ9ZLtSoQbYzv8FEDeg3rtPin9IdyRsrAk+BHy qyfBu1pt24TVdvdMkEkAmntraEWxmdLbOayTVvpv53g+CWQK4N6Dcs6jIYJc+mKzyGTK 6uSe/ztCqWFn2JSf7r/tgWwMWlOJrrhMXt7E6bdKMUcOP4E7O9k8nicGVpJ5UvPINXHe 0GIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jyl7Q+fNfa4JowIqcItEgbQqxdMDKkuTAtedoCYt2UY=; b=JPb+6uJML5KU7PharXJUB7CV05abq21qXnsxK/Krmi/NAYaTqWdaI+3BiHB5E818Rt c6CIvFfdHfAld6e7rPZ3dfDhTuF9V77JuK+aJpH4Y7beuKixsH0tUrwBjfPKSd8czGYl cIGR6z+S4Q1OGKoar3EmhvHqF8Fyo15IyFO71jTxHLUvsROaY8JM5SNG+SLGneoT0R0l 9+lEewoLjKxwHmc7uqG9nnpjAdGB4GJD8XGtyChMRrPc4l6y6hJmdUW49HDdzl507Rqa 8r8qrr0oE8AQIj8nlsNLULSNSwjyX76bN0DBrvzxxNiAmjspbyWssKuVRRWgAs8nfP4A r4dg== X-Gm-Message-State: APjAAAULMVeeaRw/Fftu8liHJ3GUK580LsfQECOS2Axs4zz2lvvXZFyr Qij1dSrphmKEqmj57KWkz0Qu6PJY0DM= X-Google-Smtp-Source: APXvYqziS4FRketT79XtL+Ydj0CSV86miadJPbR5wvvXJFppRqj2P83ew5kcYd1GUN55v04+6eLV4w== X-Received: by 2002:a17:902:6b02:: with SMTP id o2mr69055281plk.99.1564630231290; Wed, 31 Jul 2019 20:30:31 -0700 (PDT) Received: from localhost.localdomain ([203.205.141.123]) by smtp.googlemail.com with ESMTPSA id d14sm86158055pfo.154.2019.07.31.20.30.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Jul 2019 20:30:30 -0700 (PDT) From: Wanpeng Li X-Google-Original-From: Wanpeng Li To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Paolo Bonzini , =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= Subject: [PATCH v3 2/3] KVM: LAPIC: Don't need to wakeup vCPU twice afer timer fire Date: Thu, 1 Aug 2019 11:30:13 +0800 Message-Id: <1564630214-28442-2-git-send-email-wanpengli@tencent.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1564630214-28442-1-git-send-email-wanpengli@tencent.com> References: <1564630214-28442-1-git-send-email-wanpengli@tencent.com> MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wanpeng Li kvm_set_pending_timer() will take care to wake up the sleeping vCPU which has pending timer, don't need to check this in apic_timer_expired() again. Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li --- arch/x86/kvm/lapic.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 0aa1586..685d17c 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -1548,7 +1548,6 @@ static void kvm_apic_inject_pending_timer_irqs(struct kvm_lapic *apic) static void apic_timer_expired(struct kvm_lapic *apic) { struct kvm_vcpu *vcpu = apic->vcpu; - struct swait_queue_head *q = &vcpu->wq; struct kvm_timer *ktimer = &apic->lapic_timer; if (atomic_read(&apic->lapic_timer.pending)) @@ -1566,13 +1565,6 @@ static void apic_timer_expired(struct kvm_lapic *apic) atomic_inc(&apic->lapic_timer.pending); kvm_set_pending_timer(vcpu); - - /* - * For x86, the atomic_inc() is serialized, thus - * using swait_active() is safe. - */ - if (swait_active(q)) - swake_up_one(q); } static void start_sw_tscdeadline(struct kvm_lapic *apic)