| Message ID | 1564996902-22600-1-git-send-email-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kvm: remove unnecessary PageReserved check | expand |
On Mon, Aug 05, 2019 at 11:21:42AM +0200, Paolo Bonzini wrote: > The same check is already done in kvm_is_reserved_pfn. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- This patch was effectively submitted in Nov 2018, but was buried at the end of a DAX series. https://patchwork.kernel.org/patch/10886265/ Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com> > virt/kvm/kvm_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 416969d9fefe..c5f1186f4b60 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1855,8 +1855,7 @@ void kvm_set_pfn_dirty(kvm_pfn_t pfn) > if (!kvm_is_reserved_pfn(pfn)) { > struct page *page = pfn_to_page(pfn); > > - if (!PageReserved(page)) > - SetPageDirty(page); > + SetPageDirty(page); > } > } > EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty); > -- > 1.8.3.1 >
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 416969d9fefe..c5f1186f4b60 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1855,8 +1855,7 @@ void kvm_set_pfn_dirty(kvm_pfn_t pfn) if (!kvm_is_reserved_pfn(pfn)) { struct page *page = pfn_to_page(pfn); - if (!PageReserved(page)) - SetPageDirty(page); + SetPageDirty(page); } } EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
The same check is already done in kvm_is_reserved_pfn. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- virt/kvm/kvm_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)