| Message ID | 1566999511-24916-2-git-send-email-alexandru.elisei@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: Run at EL2 | expand |
On Wed, Aug 28, 2019 at 02:38:16PM +0100, Alexandru Elisei wrote: > expected_regs.pstate already has PSR_MODE_EL1h set as the expected > Exception Level. That's true for selftest-vectors-kernel, but not for selftest-vectors-user. Thanks, drew > > Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> > --- > arm/selftest.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arm/selftest.c b/arm/selftest.c > index 28a17f7a7531..176231f32ee1 100644 > --- a/arm/selftest.c > +++ b/arm/selftest.c > @@ -213,10 +213,6 @@ static bool check_regs(struct pt_regs *regs) > { > unsigned i; > > - /* exception handlers should always run in EL1 */ > - if (current_level() != CurrentEL_EL1) > - return false; > - > for (i = 0; i < ARRAY_SIZE(regs->regs); ++i) { > if (regs->regs[i] != expected_regs.regs[i]) > return false; > -- > 2.7.4 >
On 8/28/19 3:32 PM, Andrew Jones wrote: > On Wed, Aug 28, 2019 at 02:38:16PM +0100, Alexandru Elisei wrote: >> expected_regs.pstate already has PSR_MODE_EL1h set as the expected >> Exception Level. > That's true for selftest-vectors-kernel, but not for > selftest-vectors-user. Oops, that's true. This patch is definitely wrong, I'll drop it. Thanks, Alex > > Thanks, > drew > >> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> >> --- >> arm/selftest.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/arm/selftest.c b/arm/selftest.c >> index 28a17f7a7531..176231f32ee1 100644 >> --- a/arm/selftest.c >> +++ b/arm/selftest.c >> @@ -213,10 +213,6 @@ static bool check_regs(struct pt_regs *regs) >> { >> unsigned i; >> >> - /* exception handlers should always run in EL1 */ >> - if (current_level() != CurrentEL_EL1) >> - return false; >> - >> for (i = 0; i < ARRAY_SIZE(regs->regs); ++i) { >> if (regs->regs[i] != expected_regs.regs[i]) >> return false; >> -- >> 2.7.4 >> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
diff --git a/arm/selftest.c b/arm/selftest.c index 28a17f7a7531..176231f32ee1 100644 --- a/arm/selftest.c +++ b/arm/selftest.c @@ -213,10 +213,6 @@ static bool check_regs(struct pt_regs *regs) { unsigned i; - /* exception handlers should always run in EL1 */ - if (current_level() != CurrentEL_EL1) - return false; - for (i = 0; i < ARRAY_SIZE(regs->regs); ++i) { if (regs->regs[i] != expected_regs.regs[i]) return false;
expected_regs.pstate already has PSR_MODE_EL1h set as the expected Exception Level. Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> --- arm/selftest.c | 4 ---- 1 file changed, 4 deletions(-)