| Message ID | 1569245722-23375-6-git-send-email-alexandru.elisei@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm: Allow the user to define the memory layout | expand |
On Mon, 23 Sep 2019 14:35:11 +0100 Alexandru Elisei <alexandru.elisei@arm.com> wrote: > The help text for the -m/--mem argument states that the guest memory size > is in MiB (mebibyte). We all know that MB (megabyte) is the same thing as > MiB, and indeed this is how MB is used throughout kvmtool. > > So replace MiB with MB, so people don't get the wrong idea and start > believing that for kvmtool a MB is 10^6 bytes, because it isn't. > > Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > Documentation/kvmtool.1 | 4 ++-- > builtin-run.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/kvmtool.1 b/Documentation/kvmtool.1 > index 2b8c274dc3ff..25d46f8f51f9 100644 > --- a/Documentation/kvmtool.1 > +++ b/Documentation/kvmtool.1 > @@ -10,7 +10,7 @@ kvmtool is a userland tool for creating and controlling KVM guests. > .SH "KVMTOOL COMMANDS" > .sp > .PP > -.B run -k <kernel\-image> [\-c <cores>] [\-m <MiB>] [\-p <command line>] > +.B run -k <kernel\-image> [\-c <cores>] [\-m <MB>] [\-p <command line>] > .br > .B [\-i <initrd>] [\-d <image file>] [\-\-console serial|virtio|hv] > .br > @@ -30,7 +30,7 @@ The number of virtual CPUs to run. > .sp > .B \-m, \-\-mem <n> > .RS 4 > -Virtual machine memory size in MiB. > +Virtual machine memory size in MB. > .RE > .sp > .B \-p, \-\-params <parameters> > diff --git a/builtin-run.c b/builtin-run.c > index 532c06f90ba0..cff44047bb1c 100644 > --- a/builtin-run.c > +++ b/builtin-run.c > @@ -98,7 +98,7 @@ void kvm_run_set_wrapper_sandbox(void) > "A name for the guest"), \ > OPT_INTEGER('c', "cpus", &(cfg)->nrcpus, "Number of CPUs"), \ > OPT_U64('m', "mem", &(cfg)->ram_size, "Virtual machine memory" \ > - " size in MiB."), \ > + " size in MB."), \ > OPT_CALLBACK('\0', "shmem", NULL, \ > "[pci:]<addr>:<size>[:handle=<handle>][:create]", \ > "Share host shmem with guest via pci device", \
On 23/09/2019 14:35, Alexandru Elisei wrote: > The help text for the -m/--mem argument states that the guest memory size > is in MiB (mebibyte). We all know that MB (megabyte) is the same thing as > MiB, and indeed this is how MB is used throughout kvmtool. > > So replace MiB with MB, so people don't get the wrong idea and start > believing that for kvmtool a MB is 10^6 bytes, because it isn't. > > Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
diff --git a/Documentation/kvmtool.1 b/Documentation/kvmtool.1 index 2b8c274dc3ff..25d46f8f51f9 100644 --- a/Documentation/kvmtool.1 +++ b/Documentation/kvmtool.1 @@ -10,7 +10,7 @@ kvmtool is a userland tool for creating and controlling KVM guests. .SH "KVMTOOL COMMANDS" .sp .PP -.B run -k <kernel\-image> [\-c <cores>] [\-m <MiB>] [\-p <command line>] +.B run -k <kernel\-image> [\-c <cores>] [\-m <MB>] [\-p <command line>] .br .B [\-i <initrd>] [\-d <image file>] [\-\-console serial|virtio|hv] .br @@ -30,7 +30,7 @@ The number of virtual CPUs to run. .sp .B \-m, \-\-mem <n> .RS 4 -Virtual machine memory size in MiB. +Virtual machine memory size in MB. .RE .sp .B \-p, \-\-params <parameters> diff --git a/builtin-run.c b/builtin-run.c index 532c06f90ba0..cff44047bb1c 100644 --- a/builtin-run.c +++ b/builtin-run.c @@ -98,7 +98,7 @@ void kvm_run_set_wrapper_sandbox(void) "A name for the guest"), \ OPT_INTEGER('c', "cpus", &(cfg)->nrcpus, "Number of CPUs"), \ OPT_U64('m', "mem", &(cfg)->ram_size, "Virtual machine memory" \ - " size in MiB."), \ + " size in MB."), \ OPT_CALLBACK('\0', "shmem", NULL, \ "[pci:]<addr>:<size>[:handle=<handle>][:create]", \ "Share host shmem with guest via pci device", \
The help text for the -m/--mem argument states that the guest memory size is in MiB (mebibyte). We all know that MB (megabyte) is the same thing as MiB, and indeed this is how MB is used throughout kvmtool. So replace MiB with MB, so people don't get the wrong idea and start believing that for kvmtool a MB is 10^6 bytes, because it isn't. Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> --- Documentation/kvmtool.1 | 4 ++-- builtin-run.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)