| Message ID | 1582888591-51441-1-git-send-email-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests] x86: VMX: the "noclone" attribute is not needed | expand |
On Fri, Feb 28, 2020 at 3:16 AM Paolo Bonzini <pbonzini@redhat.com> wrote: > > Don't use the "noclone" attribute as it's not needed. > Also, clang does not support it. > > Reported-by: Bill Wendling <morbo@google.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > x86/vmx_tests.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c > index a7abd63..e2fa034 100644 > --- a/x86/vmx_tests.c > +++ b/x86/vmx_tests.c > @@ -4974,7 +4974,7 @@ extern unsigned char test_mtf1; > extern unsigned char test_mtf2; > extern unsigned char test_mtf3; > > -__attribute__((noclone)) static void test_mtf_guest(void) > +static void test_mtf_guest(void) > { > asm ("vmcall;\n\t" > "out %al, $0x80;\n\t" > -- > 1.8.3.1 > Reviewed-by: Oliver Upton <oupton@google.com>
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c index a7abd63..e2fa034 100644 --- a/x86/vmx_tests.c +++ b/x86/vmx_tests.c @@ -4974,7 +4974,7 @@ extern unsigned char test_mtf1; extern unsigned char test_mtf2; extern unsigned char test_mtf3; -__attribute__((noclone)) static void test_mtf_guest(void) +static void test_mtf_guest(void) { asm ("vmcall;\n\t" "out %al, $0x80;\n\t"
Don't use the "noclone" attribute as it's not needed. Also, clang does not support it. Reported-by: Bill Wendling <morbo@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- x86/vmx_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)