diff mbox series

vfio: More vfio_file_is_group() use cases

Message ID 166516896843.1215571.5378890510536477434.stgit@omen (mailing list archive)
State New, archived
Headers show
Series vfio: More vfio_file_is_group() use cases | expand

Commit Message

Alex Williamson Oct. 7, 2022, 6:57 p.m. UTC 
Replace further open coded tests with helper.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

Applies on https://lore.kernel.org/all/0-v2-15417f29324e+1c-vfio_group_disassociate_jgg@nvidia.com/

 drivers/vfio/vfio_main.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jason Gunthorpe Oct. 7, 2022, 7:01 p.m. UTC | #1 
On Fri, Oct 07, 2022 at 12:57:14PM -0600, Alex Williamson wrote:
> Replace further open coded tests with helper.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> 
> Applies on https://lore.kernel.org/all/0-v2-15417f29324e+1c-vfio_group_disassociate_jgg@nvidia.com/

Yes, makes sense

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason
diff mbox series

Patch

diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
index 04099a839a52..2d168793d4e1 100644
--- a/drivers/vfio/vfio_main.c
+++ b/drivers/vfio/vfio_main.c
@@ -1615,7 +1615,7 @@  bool vfio_file_enforced_coherent(struct file *file)
 	struct vfio_group *group = file->private_data;
 	bool ret;
 
-	if (file->f_op != &vfio_group_fops)
+	if (!vfio_file_is_group(file))
 		return true;
 
 	mutex_lock(&group->group_lock);
@@ -1647,7 +1647,7 @@  void vfio_file_set_kvm(struct file *file, struct kvm *kvm)
 {
 	struct vfio_group *group = file->private_data;
 
-	if (file->f_op != &vfio_group_fops)
+	if (!vfio_file_is_group(file))
 		return;
 
 	mutex_lock(&group->group_lock);
@@ -1667,7 +1667,7 @@  bool vfio_file_has_dev(struct file *file, struct vfio_device *device)
 {
 	struct vfio_group *group = file->private_data;
 
-	if (file->f_op != &vfio_group_fops)
+	if (!vfio_file_is_group(file))
 		return false;
 
 	return group == device->group;