diff mbox series

[3/4] i386/cpu: Enable perfmon-v2 and RAS feature bits on EPYC-Genoa

Message ID 1dc29da3f04b4639a3f0b36d0e97d391da9802a0.1718218999.git.babu.moger@amd.com (mailing list archive)
State New, archived
Headers show
Series i386/cpu: Add support for perfmon-v2, RAS bits and EPYC-Turin CPU model | expand

Commit Message

Moger, Babu June 12, 2024, 7:12 p.m. UTC
Following feature bits are added on EPYC-Genoa-v2 model.

perfmon-v2: Allows guests to make use of the PerfMonV2 features.

SUCCOR: Software uncorrectable error containment and recovery capability.
            The processor supports software containment of uncorrectable errors
            through context synchronizing data poisoning and deferred error
            interrupts.

McaOverflowRecov: MCA overflow recovery support.

The feature details are available in APM listed below [1].
[1] AMD64 Architecture Programmer's Manual Volume 2: System Programming
Publication # 24593 Revision 3.41.

Signed-off-by: Babu Moger <babu.moger@amd.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
---
 target/i386/cpu.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Zhao Liu June 13, 2024, 7:11 a.m. UTC | #1
On Wed, Jun 12, 2024 at 02:12:19PM -0500, Babu Moger wrote:
> Date: Wed, 12 Jun 2024 14:12:19 -0500
> From: Babu Moger <babu.moger@amd.com>
> Subject: [PATCH 3/4] i386/cpu: Enable perfmon-v2 and RAS feature bits on
>  EPYC-Genoa
> X-Mailer: git-send-email 2.34.1
> 
> Following feature bits are added on EPYC-Genoa-v2 model.
> 
> perfmon-v2: Allows guests to make use of the PerfMonV2 features.

nit s/Allows/Allow/

> SUCCOR: Software uncorrectable error containment and recovery capability.
>             The processor supports software containment of uncorrectable errors
>             through context synchronizing data poisoning and deferred error
>             interrupts.
> 
> McaOverflowRecov: MCA overflow recovery support.
> 
> The feature details are available in APM listed below [1].
> [1] AMD64 Architecture Programmer's Manual Volume 2: System Programming
> Publication # 24593 Revision 3.41.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
> ---
>  target/i386/cpu.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Moger, Babu June 13, 2024, 2:13 p.m. UTC | #2
On 6/13/24 02:11, Zhao Liu wrote:
> On Wed, Jun 12, 2024 at 02:12:19PM -0500, Babu Moger wrote:
>> Date: Wed, 12 Jun 2024 14:12:19 -0500
>> From: Babu Moger <babu.moger@amd.com>
>> Subject: [PATCH 3/4] i386/cpu: Enable perfmon-v2 and RAS feature bits on
>>  EPYC-Genoa
>> X-Mailer: git-send-email 2.34.1
>>
>> Following feature bits are added on EPYC-Genoa-v2 model.
>>
>> perfmon-v2: Allows guests to make use of the PerfMonV2 features.
> 
> nit s/Allows/Allow/

Sure.

> 
>> SUCCOR: Software uncorrectable error containment and recovery capability.
>>             The processor supports software containment of uncorrectable errors
>>             through context synchronizing data poisoning and deferred error
>>             interrupts.
>>
>> McaOverflowRecov: MCA overflow recovery support.
>>
>> The feature details are available in APM listed below [1].
>> [1] AMD64 Architecture Programmer's Manual Volume 2: System Programming
>> Publication # 24593 Revision 3.41.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
>> ---
>>  target/i386/cpu.c | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
> 
> Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
>
diff mbox series

Patch

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 7f1837cdc9..64e6dc62e2 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -5272,6 +5272,21 @@  static const X86CPUDefinition builtin_x86_defs[] = {
         .xlevel = 0x80000022,
         .model_id = "AMD EPYC-Genoa Processor",
         .cache_info = &epyc_genoa_cache_info,
+        .versions = (X86CPUVersionDefinition[]) {
+            { .version = 1 },
+            {
+                .version = 2,
+                .props = (PropValue[]) {
+                    { "overflow-recov", "on" },
+                    { "succor", "on" },
+                    { "perfmon-v2", "on" },
+                    { "model-id",
+                      "AMD EPYC-Genoa-v2 Processor" },
+                    { /* end of list */ }
+                },
+            },
+            { /* end of list */ }
+        }
     },
 };