diff mbox

kvm: declare kvm_ioapic in kvm_host.h

Message ID 200902261339.36237.borntraeger@de.ibm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Christian Borntraeger Feb. 26, 2009, 12:39 p.m. UTC
With todays git I get the following warnings on s390:

  CC [M]  arch/s390/kvm/kvm-s390.o
In file included from arch/s390/kvm/kvm-s390.c:22:
include/linux/kvm_host.h:357: warning: 'struct kvm_ioapic' declared inside parameter list
include/linux/kvm_host.h:357: warning: its scope is only this definition or declaration, which is probably not what you want
[...]

Declaring struct kvm_ioapic should help.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 include/linux/kvm_host.h |    1 +
 1 file changed, 1 insertion(+)

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Avi Kivity Feb. 26, 2009, 12:43 p.m. UTC | #1
Christian Borntraeger wrote:
> With todays git I get the following warnings on s390:
>
>   CC [M]  arch/s390/kvm/kvm-s390.o
> In file included from arch/s390/kvm/kvm-s390.c:22:
> include/linux/kvm_host.h:357: warning: 'struct kvm_ioapic' declared inside parameter list
> include/linux/kvm_host.h:357: warning: its scope is only this definition or declaration, which is probably not what you want
> [...]
>
> Declaring struct kvm_ioapic should help.
>
>   

Better to limit the declaration to archs that have ioapics... do we have 
a KVM_HAVE_IOAPIC define?
diff mbox

Patch

Index: kvm/include/linux/kvm_host.h
===================================================================
--- kvm.orig/include/linux/kvm_host.h
+++ kvm/include/linux/kvm_host.h
@@ -41,6 +41,7 @@ 
 
 #define KVM_USERSPACE_IRQ_SOURCE_ID	0
 
+struct kvm_ioapic;
 struct kvm_vcpu;
 extern struct kmem_cache *kvm_vcpu_cache;