From patchwork Tue Jun 9 13:13:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 29010 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n59DG9GF004583 for ; Tue, 9 Jun 2009 13:16:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759284AbZFINP5 (ORCPT ); Tue, 9 Jun 2009 09:15:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757077AbZFINP5 (ORCPT ); Tue, 9 Jun 2009 09:15:57 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42147 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757366AbZFINPz (ORCPT ); Tue, 9 Jun 2009 09:15:55 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n59DFwlS009270 for ; Tue, 9 Jun 2009 09:15:58 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n59DFvFI032571; Tue, 9 Jun 2009 09:15:57 -0400 Received: from amt.cnet (vpn-10-7.str.redhat.com [10.32.10.7]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n59DFsEK026734; Tue, 9 Jun 2009 09:15:55 -0400 Received: from amt.cnet (amt.cnet [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id EF94A274FD4; Tue, 9 Jun 2009 10:15:23 -0300 (BRT) Received: (from marcelo@localhost) by amt.cnet (8.14.3/8.14.3/Submit) id n59DFMwD007473; Tue, 9 Jun 2009 10:15:22 -0300 Message-Id: <20090609131405.896285225@localhost.localdomain> References: <20090609131303.446673264@localhost.localdomain> User-Agent: quilt/0.46-1 Date: Tue, 09 Jun 2009 10:13:05 -0300 From: Marcelo Tosatti To: kvm@vger.kernel.org Cc: avi@redhat.com, Marcelo Tosatti Subject: [patch 2/4] KVM: MMU audit: update audit_write_protection Content-Disposition: inline; filename=mmu-audit-2 X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org - Unsync pages contain writable sptes in the rmap. - rmaps do not exclusively contain writable sptes anymore. Signed-off-by: Marcelo Tosatti Index: kvm/arch/x86/kvm/mmu.c =================================================================== --- kvm.orig/arch/x86/kvm/mmu.c +++ kvm/arch/x86/kvm/mmu.c @@ -3231,20 +3231,28 @@ static void audit_write_protection(struc struct kvm_mmu_page *sp; struct kvm_memory_slot *slot; unsigned long *rmapp; + u64 *spte; gfn_t gfn; list_for_each_entry(sp, &vcpu->kvm->arch.active_mmu_pages, link) { if (sp->role.direct) continue; + if (sp->unsync) + continue; gfn = unalias_gfn(vcpu->kvm, sp->gfn); slot = gfn_to_memslot_unaliased(vcpu->kvm, sp->gfn); rmapp = &slot->rmap[gfn - slot->base_gfn]; - if (*rmapp) - printk(KERN_ERR "%s: (%s) shadow page has writable" - " mappings: gfn %lx role %x\n", + + spte = rmap_next(vcpu->kvm, rmapp, NULL); + while (spte) { + if (*spte & PT_WRITABLE_MASK) + printk(KERN_ERR "%s: (%s) shadow page has " + "writable mappings: gfn %lx role %x\n", __func__, audit_msg, sp->gfn, sp->role.word); + spte = rmap_next(vcpu->kvm, rmapp, spte); + } } }