From patchwork Mon Jul 20 23:23:10 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Paris X-Patchwork-Id: 36428 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6KNNFjk024505 for ; Mon, 20 Jul 2009 23:23:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754361AbZGTXXN (ORCPT ); Mon, 20 Jul 2009 19:23:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754362AbZGTXXN (ORCPT ); Mon, 20 Jul 2009 19:23:13 -0400 Received: from jim.sh ([75.150.123.25]:49338 "EHLO psychosis.jim.sh" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754353AbZGTXXN (ORCPT ); Mon, 20 Jul 2009 19:23:13 -0400 Received: from psychosis.jim.sh (localhost [127.0.0.1]) by psychosis.jim.sh (8.14.3/8.14.3/Debian-5) with ESMTP id n6KNNADR031234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 20 Jul 2009 19:23:10 -0400 Received: (from jim@localhost) by psychosis.jim.sh (8.14.3/8.14.3/Submit) id n6KNNA93031233; Mon, 20 Jul 2009 19:23:10 -0400 Date: Mon, 20 Jul 2009 19:23:10 -0400 From: Jim Paris To: G Cc: kvm@vger.kernel.org Subject: Re: KVM crashes when using certain USB device Message-ID: <20090720232310.GA29764@psychosis.jim.sh> References: <20090703161848.GA18195@psychosis.jim.sh> <20090716071526.GA1996@psychosis.jim.sh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Virus-Scanned: ClamAV 0.94.2/9592/Mon Jul 20 17:23:29 2009 on psychosis.jim.sh X-Virus-Status: Clean Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org G wrote: > I'm not too familiar with valgrind output, I have only used it on > smaller programs I've written myself, so I don't know what to think of > the messages (and amount of messages; valgrind told me to use > --error-limit=no). I do get a bit nervous from all the complaints > about uninitialized values and byes, but maybe it's normal for an > application of kvm's size and type. I'd be nervous too :) Many of the complaints look harmless, but it's probably worth fixing them to make the real bugs stand out more. > > Even though you're having problems with -no-kvm, I suspect this is an > > upstream qemu issue, so you should probably try the qemu list too. > > qemu-devel@nongnu.org? I'll try to figure out the -no-kvm issue first, > so I can run any commands they might want me to run. > > And thanks for your help and suggestions so far, btw. Here's a patch to try. I'm not familiar with the code, but it looks like this buffer might be too small versus the packet lengths that you're seeing, and similar definitions in hw/usb-uhci.c. -jim --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -urN kvm-87-orig/usb-linux.c kvm-87/usb-linux.c --- kvm-87-orig/usb-linux.c 2009-06-23 09:32:38.000000000 -0400 +++ kvm-87/usb-linux.c 2009-07-20 19:15:35.000000000 -0400 @@ -115,7 +115,7 @@ uint16_t offset; uint8_t state; struct usb_ctrlrequest req; - uint8_t buffer[1024]; + uint8_t buffer[2048]; }; typedef struct USBHostDevice {