| Message ID | 20090810124851.GA9911@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/10/2009 03:48 PM, Michael S. Tsirkin wrote: > kvm_para.h contains userspace interface and so > should be exported. > > Doesn't it need asm/kvm_para.h as well?
On Sun, Aug 16, 2009 at 03:09:55PM +0300, Avi Kivity wrote: > On 08/10/2009 03:48 PM, Michael S. Tsirkin wrote: >> kvm_para.h contains userspace interface and so >> should be exported. >> >> > > Doesn't it need asm/kvm_para.h as well? Yes, that was v2. > -- > error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/Kbuild b/include/linux/Kbuild index ab93554..598d407 100644 --- a/include/linux/Kbuild +++ b/include/linux/Kbuild @@ -267,6 +267,7 @@ unifdef-y += keyboard.h ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \ $(srctree)/include/asm-$(SRCARCH)/kvm.h),) unifdef-y += kvm.h +unifdef-y += kvm_para.h endif unifdef-y += llc.h unifdef-y += loop.h
kvm_para.h contains userspace interface and so should be exported. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- Avi, this fixes a bug (in build system) that has been there since 2.6.26. Since userspace already uses this header, I think it would be nice to have the fix in 2.6.31. include/linux/Kbuild | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)