| Message ID | 20090810185302.GB13924@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/10/2009 11:53 AM, Michael S. Tsirkin wrote: > vhost net module wants to do copy to/from user from a kernel thread, > which needs switch_mm (like what fs/aio has). > export cpu_tlbstate to make this possible > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > arch/x86/mm/tlb.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index 821e970..e33a5f0 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -13,6 +13,7 @@ > > DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) > = { &init_mm, 0, }; > +EXPORT_PER_CPU_SYMBOL_GPL(cpu_tlbstate); > > /* > * Smarter SMP flushing macros. Wouldn't it be a *lot* better to move use_mm() from fs/aio.c into common code, and export that instead? -hpa -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 10, 2009 at 02:56:46PM -0700, H. Peter Anvin wrote: > On 08/10/2009 11:53 AM, Michael S. Tsirkin wrote: > > vhost net module wants to do copy to/from user from a kernel thread, > > which needs switch_mm (like what fs/aio has). > > export cpu_tlbstate to make this possible > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > arch/x86/mm/tlb.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > > index 821e970..e33a5f0 100644 > > --- a/arch/x86/mm/tlb.c > > +++ b/arch/x86/mm/tlb.c > > @@ -13,6 +13,7 @@ > > > > DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) > > = { &init_mm, 0, }; > > +EXPORT_PER_CPU_SYMBOL_GPL(cpu_tlbstate); > > > > /* > > * Smarter SMP flushing macros. > > Wouldn't it be a *lot* better to move use_mm() from fs/aio.c into common > code, and export that instead? > > -hpa That's easy too. What would a good place for it be? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/10/2009 03:06 PM, Michael S. Tsirkin wrote: >> Wouldn't it be a *lot* better to move use_mm() from fs/aio.c into common >> code, and export that instead? > > That's easy too. What would a good place for it be? Somewhere in mm/, presumably. When in doubt, make it a new file... -hpa -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 821e970..e33a5f0 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -13,6 +13,7 @@ DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) = { &init_mm, 0, }; +EXPORT_PER_CPU_SYMBOL_GPL(cpu_tlbstate); /* * Smarter SMP flushing macros.
vhost net module wants to do copy to/from user from a kernel thread, which needs switch_mm (like what fs/aio has). export cpu_tlbstate to make this possible Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- arch/x86/mm/tlb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)