From patchwork Wed Jan 6 08:29:26 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 71246 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o068aj8V024328 for ; Wed, 6 Jan 2010 08:36:45 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754520Ab0AFIgn (ORCPT ); Wed, 6 Jan 2010 03:36:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755447Ab0AFIgn (ORCPT ); Wed, 6 Jan 2010 03:36:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49176 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987Ab0AFIgm (ORCPT ); Wed, 6 Jan 2010 03:36:42 -0500 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o068acnp030938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jan 2010 03:36:39 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o068ab5l028156; Wed, 6 Jan 2010 03:36:38 -0500 Received: from amt.cnet (vpn-10-227.rdu.redhat.com [10.11.10.227]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o068aa8m022628; Wed, 6 Jan 2010 03:36:36 -0500 Received: from amt.cnet (amt.cnet [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id 70D765880AE; Wed, 6 Jan 2010 06:29:28 -0200 (BRST) Received: (from marcelo@localhost) by amt.cnet (8.14.3/8.14.3/Submit) id o068TQgd003632; Wed, 6 Jan 2010 06:29:26 -0200 Date: Wed, 6 Jan 2010 06:29:26 -0200 From: Marcelo Tosatti To: Thomas Beinicke , Mark McLoughlin Cc: "kvm@vger.kernel.org" Subject: Re: 0.12.x: message "Option 'ipv4': Use 'on' or 'off'" Message-ID: <20100106082926.GA2369@amt.cnet> References: <201001040918.01964.thomas.beinicke@fsd-web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201001040918.01964.thomas.beinicke@fsd-web.de> User-Agent: Mutt/1.5.19 (2009-01-05) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org diff --git a/qemu-sockets.c b/qemu-sockets.c index 8850516..a88b2a7 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -424,7 +424,7 @@ static int inet_parse(QemuOpts *opts, const char *str) __FUNCTION__, str); return -1; } - qemu_opt_set(opts, "ipv6", "yes"); + qemu_opt_set(opts, "ipv6", "on"); } else if (qemu_isdigit(str[0])) { /* IPv4 addr */ if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) { @@ -432,7 +432,7 @@ static int inet_parse(QemuOpts *opts, const char *str) __FUNCTION__, str); return -1; } - qemu_opt_set(opts, "ipv4", "yes"); + qemu_opt_set(opts, "ipv4", "on"); } else { /* hostname */ if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) { @@ -450,9 +450,9 @@ static int inet_parse(QemuOpts *opts, const char *str) if (h) qemu_opt_set(opts, "to", h+4); if (strstr(optstr, ",ipv4")) - qemu_opt_set(opts, "ipv4", "yes"); + qemu_opt_set(opts, "ipv4", "on"); if (strstr(optstr, ",ipv6")) - qemu_opt_set(opts, "ipv6", "yes"); + qemu_opt_set(opts, "ipv6", "on"); return 0; }