From patchwork Mon Feb 7 13:27:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gleb Natapov X-Patchwork-Id: 538011 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p17DRdJK030497 for ; Mon, 7 Feb 2011 13:27:40 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312Ab1BGN1h (ORCPT ); Mon, 7 Feb 2011 08:27:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15017 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252Ab1BGN1g (ORCPT ); Mon, 7 Feb 2011 08:27:36 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p17DRVW8017732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Feb 2011 08:27:31 -0500 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p17DRU7X012253; Mon, 7 Feb 2011 08:27:30 -0500 Received: by dhcp-1-237.tlv.redhat.com (Postfix, from userid 13519) id F1BC518D3E9; Mon, 7 Feb 2011 15:27:29 +0200 (IST) Date: Mon, 7 Feb 2011 15:27:29 +0200 From: Gleb Natapov To: Avi Kivity Cc: Jonathan Nieder , Marcelo Tosatti , kvm@vger.kernel.org, Michael Tokarev , Guillem Jover Subject: Re: [regression] KVM: hangs and "irq timeout" booting HURD unless -no-kvm-irqchip passed Message-ID: <20110207132729.GC14984@redhat.com> References: <1283171743-10766-1-git-send-email-avi@redhat.com> <1283171743-10766-2-git-send-email-avi@redhat.com> <20110207060030.GA1896@elie> <4D4FE7E5.2040308@redhat.com> <20110207124513.GB14984@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110207124513.GB14984@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 07 Feb 2011 13:27:52 +0000 (UTC) diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c index 3cece05..62b1dde 100644 --- a/arch/x86/kvm/i8259.c +++ b/arch/x86/kvm/i8259.c @@ -549,6 +549,9 @@ static void pic_irq_request(struct kvm *kvm, int level) struct kvm_pic *s = pic_irqchip(kvm); int irq = pic_get_irq(&s->pics[0]); + if (s->output && !level) + s->pics[0].isr_ack = 0xff; + s->output = level; if (vcpu && level && (s->pics[0].isr_ack & (1 << irq))) { s->pics[0].isr_ack &= ~(1 << irq);