From patchwork Sat May 7 15:02:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyrill Gorcunov X-Patchwork-Id: 764472 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p47F5X7r012649 for ; Sat, 7 May 2011 15:05:33 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755554Ab1EGPF2 (ORCPT ); Sat, 7 May 2011 11:05:28 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:45087 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755463Ab1EGPFZ (ORCPT ); Sat, 7 May 2011 11:05:25 -0400 Received: by ewy4 with SMTP id 4so1214723ewy.19 for ; Sat, 07 May 2011 08:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:user-agent:date:from:to:cc:subject :references:content-disposition; bh=e988L6NEzlDiqQy0gtpqrLJ9hH7I5Gow7EBBTOu12ZU=; b=OWehjjkF+4G1xFyJe3PkoTEmd6uI35LBRvTYTRyHN4uEwl+fWvfZfVgekvWqwHc3Di 8XKnzesJGRHS3pylMm93Mg8kWJHG8xxOMZeKU5AdHnBmjV/LHVjcgy6Zu5jNxiLVDfFf K4vMvKybIUwTT8bnyKRH7nrDMgzz4virvwjL0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:user-agent:date:from:to:cc:subject:references :content-disposition; b=E3d5QdLGbxpBry3RfCjaE39INkU/vp1TSduZH24TN4YUbW/yvpHuXt9qxHGcfGyadi tIKRj1SkiDPY6wJogngnL/XZUslfR0c2ecCJPmKe9U7z5TdC3peMfDkhM8DXvA29gwCW xh1x9PIo3k1LyNY9Pu7d6veZapcUIzyk9p2R8= Received: by 10.213.0.209 with SMTP id 17mr354726ebc.30.1304780723897; Sat, 07 May 2011 08:05:23 -0700 (PDT) Received: from gorcunov (95-26-151-249.broadband.corbina.ru [95.26.151.249]) by mx.google.com with ESMTPS id s62sm2135347eea.10.2011.05.07.08.05.21 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 07 May 2011 08:05:22 -0700 (PDT) Received: by gorcunov (Postfix, from userid 1000) id 5FBB59E; Sat, 7 May 2011 19:05:20 +0400 (MSD) Message-Id: <20110507150520.198777749@gmail.com> User-Agent: quilt/0.47-1 Date: Sat, 07 May 2011 19:02:57 +0400 From: Cyrill Gorcunov To: penberg@kernel.org Cc: kvm@vger.kernel.org, mingo@elte.hu, levinsasha928@gmail.com, asias.hejun@gmail.com, prasadjoshi124@gmail.com, Cyrill Gorcunov Subject: [patch 1/2] kvm tools: Fix up PCI pin assignment to conform specification References: <20110507150256.898160753@gmail.com> Content-Disposition: inline; filename=kvm-tools-irq-pins Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sat, 07 May 2011 15:05:33 +0000 (UTC) Only 4 pins are allowed for every PCI compilant device. Mutlifunctional devices can use up to all INTA#,B#,C#,D# pins, for our sindle function devices pin INTA# is enough. Signed-off-by: Cyrill Gorcunov --- tools/kvm/irq.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6.git/tools/kvm/irq.c ===================================================================== --- linux-2.6.git.orig/tools/kvm/irq.c +++ linux-2.6.git/tools/kvm/irq.c @@ -7,7 +7,6 @@ #include #include -static u8 next_pin = 1; static u8 next_line = 3; static u8 next_dev = 1; static struct rb_root pci_tree = RB_ROOT; @@ -71,7 +70,13 @@ int irq__register_device(u32 dev, u8 *nu *node = (struct pci_dev) { .id = dev, - .pin = next_pin++, + /* + * PCI supports only INTA#,B#,C#,D# per device. + * A#,B#,C#,D# are allowed for multifunctional + * devices so stick with A# for our single + * function devices. + */ + .pin = 1, }; INIT_LIST_HEAD(&node->lines);