From patchwork Fri Jun 3 16:45:00 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ingo Molnar X-Patchwork-Id: 847852 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p53GjEMx019934 for ; Fri, 3 Jun 2011 16:45:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752291Ab1FCQpK (ORCPT ); Fri, 3 Jun 2011 12:45:10 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:56364 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593Ab1FCQpJ (ORCPT ); Fri, 3 Jun 2011 12:45:09 -0400 Received: from elvis.elte.hu ([157.181.1.14]) by mx3.mail.elte.hu with esmtp (Exim) id 1QSXUb-0005zi-Rz from ; Fri, 03 Jun 2011 18:45:07 +0200 Received: by elvis.elte.hu (Postfix, from userid 1004) id 3938A3E2517; Fri, 3 Jun 2011 18:44:58 +0200 (CEST) Date: Fri, 3 Jun 2011 18:45:00 +0200 From: Ingo Molnar To: Pekka Enberg Cc: kvm@vger.kernel.org, Cyrill Gorcunov , John Floren , Sasha Levin Subject: Re: [PATCH 3/3] kvm tools, ui: Add support for SDL framebuffer output target Message-ID: <20110603164500.GB17964@elte.hu> References: <1307116779-572-1-git-send-email-penberg@kernel.org> <1307116779-572-3-git-send-email-penberg@kernel.org> <20110603162631.GA17203@elte.hu> <20110603162856.GA17415@elte.hu> <20110603163346.GB17415@elte.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 03 Jun 2011 16:45:15 +0000 (UTC) i tried this patch: but it does not trigger. Oh ... because the SDL library is not present on that box and it silently did not get built. Now *that* is not an obvious failure pattern ;-) Thanks, Ingo --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tools/kvm/ui/sdl.c b/tools/kvm/ui/sdl.c index 8bc3f68..403563c 100644 --- a/tools/kvm/ui/sdl.c +++ b/tools/kvm/ui/sdl.c @@ -19,6 +19,8 @@ static void *sdl__thread(void *p) SDL_Surface *screen; SDL_Event ev; + BUG_ON(1); + if (SDL_Init(SDL_INIT_VIDEO) != 0) die("Unable to initialize SDL");