From patchwork Tue Aug 2 19:54:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 1030022 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p72JseTC005698 for ; Tue, 2 Aug 2011 19:54:40 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755184Ab1HBTyf (ORCPT ); Tue, 2 Aug 2011 15:54:35 -0400 Received: from oproxy7-pub.bluehost.com ([67.222.55.9]:42236 "HELO oproxy7-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755180Ab1HBTye (ORCPT ); Tue, 2 Aug 2011 15:54:34 -0400 Received: (qmail 9618 invoked by uid 0); 2 Aug 2011 19:54:33 -0000 Received: from unknown (HELO box742.bluehost.com) (66.147.244.242) by oproxy7.bluehost.com with SMTP; 2 Aug 2011 19:54:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenotime.net; s=default; h=Content-Transfer-Encoding:Content-Type:Mime-Version:References:In-Reply-To:Message-Id:Subject:Cc:To:From:Date; bh=aC291x8t3e30/wlkXfgArz8Go2Z1FkqpdC+cgzkV+5U=; b=mMdQpC4QgpdnNleYFkOKu87oPyxDZSMZmlAlXHkBIK14hDtHXmPB2RAezHHMxbsX2tpFsQnB0O09jMJ74w6hSWZofnbuC+JfLBldNU9AE0Zcdhsl8K4hbPT1lXNxl3ey; Received: from static-50-53-38-135.bvtn.or.frontiernet.net ([50.53.38.135] helo=chimera.site) by box742.bluehost.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1QoL2u-0008FN-Vx; Tue, 02 Aug 2011 13:54:33 -0600 Date: Tue, 2 Aug 2011 12:54:31 -0700 From: Randy Dunlap To: Stephen Rothwell , Avi Kivity , Marcelo Tosatti Cc: linux-next@vger.kernel.org, LKML , kvm@vger.kernel.org Subject: [PATCH -next] kvm: uses TASKSTATS, depends on NET Message-Id: <20110802125431.e1902bd1.rdunlap@xenotime.net> In-Reply-To: <20110802155727.a3d76babdd2c6fd5d33928c5@canb.auug.org.au> References: <20110802155727.a3d76babdd2c6fd5d33928c5@canb.auug.org.au> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 02 Aug 2011 19:54:40 +0000 (UTC) From: Randy Dunlap CONFIG_TASKSTATS just had a change to use netlink, including a change to "depends on NET". Since "select" does not follow dependencies, KVM also needs to depend on NET to prevent build errors when CONFIG_NET is not enabled. Sample of the reported "undefined reference" build errors: taskstats.c:(.text+0x8f686): undefined reference to `nla_put' taskstats.c:(.text+0x8f721): undefined reference to `nla_reserve' taskstats.c:(.text+0x8f8fb): undefined reference to `init_net' taskstats.c:(.text+0x8f905): undefined reference to `netlink_unicast' taskstats.c:(.text+0x8f934): undefined reference to `kfree_skb' taskstats.c:(.text+0x8f9e9): undefined reference to `skb_clone' taskstats.c:(.text+0x90060): undefined reference to `__alloc_skb' taskstats.c:(.text+0x901e9): undefined reference to `skb_put' taskstats.c:(.init.text+0x4665): undefined reference to `genl_register_family' taskstats.c:(.init.text+0x4699): undefined reference to `genl_register_ops' taskstats.c:(.init.text+0x4710): undefined reference to `genl_unregister_ops' taskstats.c:(.init.text+0x471c): undefined reference to `genl_unregister_family' Signed-off-by: Randy Dunlap --- arch/x86/kvm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-next-20110802.orig/arch/x86/kvm/Kconfig +++ linux-next-20110802/arch/x86/kvm/Kconfig @@ -22,6 +22,8 @@ config KVM depends on HAVE_KVM # for device assignment: depends on PCI + # for TASKSTATS/TASK_DELAY_ACCT: + depends on NET select PREEMPT_NOTIFIERS select MMU_NOTIFIER select ANON_INODES